[PATCH] ubi: Depend on MTD
UBI required MTD to build correctly, add it as a Kconfig dependency.
Signed-off-by: John Watts contact@jookia.org --- While working with UBI on my SPI NAND patch series I found it was possible to enable it without enabling the MTD subsystem. Add a Kconfig option to solve this. --- drivers/mtd/ubi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig index 5783d36c04..fd446d6efb 100644 --- a/drivers/mtd/ubi/Kconfig +++ b/drivers/mtd/ubi/Kconfig @@ -9,6 +9,7 @@ config UBI_SILENCE_MSG
config MTD_UBI bool "Enable UBI - Unsorted block images" + depends on MTD select RBTREE select MTD_PARTITIONS help
--- base-commit: 777c28460947371ada40868dc994dfe8537d7115 change-id: 20240411-mtd-d2e811e17cc8
Best regards,
Hi
On Thu, Apr 11, 2024 at 7:06 AM John Watts contact@jookia.org wrote:
UBI required MTD to build correctly, add it as a Kconfig dependency.
Signed-off-by: John Watts contact@jookia.org
While working with UBI on my SPI NAND patch series I found it was possible to enable it without enabling the MTD subsystem. Add a Kconfig option to solve this.
drivers/mtd/ubi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig index 5783d36c04..fd446d6efb 100644 --- a/drivers/mtd/ubi/Kconfig +++ b/drivers/mtd/ubi/Kconfig @@ -9,6 +9,7 @@ config UBI_SILENCE_MSG
config MTD_UBI bool "Enable UBI - Unsorted block images"
depends on MTD select RBTREE select MTD_PARTITIONS help
Reviewed-by: Michael Trimarchi michael@amarulasolutins.com
base-commit: 777c28460947371ada40868dc994dfe8537d7115 change-id: 20240411-mtd-d2e811e17cc8
Best regards,
John Watts contact@jookia.org
Hello Tom,
On 11.04.24 08:09, Michael Nazzareno Trimarchi wrote:
Hi
On Thu, Apr 11, 2024 at 7:06 AM John Watts contact@jookia.org wrote:
UBI required MTD to build correctly, add it as a Kconfig dependency.
Signed-off-by: John Watts contact@jookia.org
While working with UBI on my SPI NAND patch series I found it was possible to enable it without enabling the MTD subsystem. Add a Kconfig option to solve this.
drivers/mtd/ubi/Kconfig | 1 + 1 file changed, 1 insertion(+)
Seems I am too dummy to find this patch in Patchwork, nor is it applied in master ... can you pick it up, or should I do this and send you a pull request?
Thanks!
bye, Heiko
On Fri, Apr 26, 2024 at 07:18:18AM +0200, Heiko Schocher wrote:
Hello Tom,
On 11.04.24 08:09, Michael Nazzareno Trimarchi wrote:
Hi
On Thu, Apr 11, 2024 at 7:06 AM John Watts contact@jookia.org wrote:
UBI required MTD to build correctly, add it as a Kconfig dependency.
Signed-off-by: John Watts contact@jookia.org
While working with UBI on my SPI NAND patch series I found it was possible to enable it without enabling the MTD subsystem. Add a Kconfig option to solve this.
drivers/mtd/ubi/Kconfig | 1 + 1 file changed, 1 insertion(+)
Seems I am too dummy to find this patch in Patchwork, nor is it applied in master ... can you pick it up, or should I do this and send you a pull request?
It's over at https://patchwork.ozlabs.org/project/uboot/patch/20240411-mtd-v1-1-fe300f6ab... currently but you can take it up and send it to me if you like.
Hi Dario
On Fri, Apr 26, 2024 at 5:52 PM Tom Rini trini@konsulko.com wrote:
On Fri, Apr 26, 2024 at 07:18:18AM +0200, Heiko Schocher wrote:
Hello Tom,
On 11.04.24 08:09, Michael Nazzareno Trimarchi wrote:
Hi
On Thu, Apr 11, 2024 at 7:06 AM John Watts contact@jookia.org wrote:
UBI required MTD to build correctly, add it as a Kconfig dependency.
Signed-off-by: John Watts contact@jookia.org
While working with UBI on my SPI NAND patch series I found it was possible to enable it without enabling the MTD subsystem. Add a Kconfig option to solve this.
drivers/mtd/ubi/Kconfig | 1 + 1 file changed, 1 insertion(+)
Seems I am too dummy to find this patch in Patchwork, nor is it applied in master ... can you pick it up, or should I do this and send you a pull request?
It's over at https://patchwork.ozlabs.org/project/uboot/patch/20240411-mtd-v1-1-fe300f6ab... currently but you can take it up and send it to me if you like.
Can you pick it up? Seems that you are delegate and was already reviewed by me
Michael
-- Tom
Hi Michael,
On Fri, Apr 26, 2024 at 5:56 PM Michael Nazzareno Trimarchi michael@amarulasolutions.com wrote:
Hi Dario
On Fri, Apr 26, 2024 at 5:52 PM Tom Rini trini@konsulko.com wrote:
On Fri, Apr 26, 2024 at 07:18:18AM +0200, Heiko Schocher wrote:
Hello Tom,
On 11.04.24 08:09, Michael Nazzareno Trimarchi wrote:
Hi
On Thu, Apr 11, 2024 at 7:06 AM John Watts contact@jookia.org wrote:
UBI required MTD to build correctly, add it as a Kconfig dependency.
Signed-off-by: John Watts contact@jookia.org
While working with UBI on my SPI NAND patch series I found it was possible to enable it without enabling the MTD subsystem. Add a Kconfig option to solve this.
drivers/mtd/ubi/Kconfig | 1 + 1 file changed, 1 insertion(+)
Seems I am too dummy to find this patch in Patchwork, nor is it applied in master ... can you pick it up, or should I do this and send you a pull request?
It's over at https://patchwork.ozlabs.org/project/uboot/patch/20240411-mtd-v1-1-fe300f6ab... currently but you can take it up and send it to me if you like.
Can you pick it up? Seems that you are delegate and was already reviewed by me
Yes, I will apply the patch to nand-next branch and test it with the CI pipeline
Thanks and regards, Dario
Michael
-- Tom
-- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________
Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com
Hello John,
On 11.04.24 07:05, John Watts wrote:
UBI required MTD to build correctly, add it as a Kconfig dependency.
Signed-off-by: John Watts contact@jookia.org
While working with UBI on my SPI NAND patch series I found it was possible to enable it without enabling the MTD subsystem. Add a Kconfig option to solve this.
drivers/mtd/ubi/Kconfig | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Heiko Schocher hs@denx.de
Thanks!
bye, Heiko
participants (5)
-
Dario Binacchi -
Heiko Schocher -
John Watts -
Michael Nazzareno Trimarchi -
Tom Rini