On Mon, Mar 28, 2022 at 2:14 AM Ye Li ye.li@nxp.com wrote:

The mxs_nand_spl driver can support to read from page unaligned offset, so don't need to set bl_len to ask spl_load_simple_fit to handle the page unaligned access.

Actually spl_load_simple_fit has two parts of reading: spl_simple_fit_read and spl_load_fit_image. The spl_load_fit_image can handle the page unaligned offset, but the spl_simple_fit_read can't do it. spl_simple_fit_read requires the FIT location at page aligned offset.

Hence, remove the nand_get_mtd overwrite function from mxs_nand_spl to use page unaligned read by driver.

Signed-off-by: Ye Li ye.li@nxp.com

drivers/mtd/nand/raw/mxs_nand_spl.c | 5 ----- 1 file changed, 5 deletions(-)

diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c index 9e0b8afb..59a67ee 100644 --- a/drivers/mtd/nand/raw/mxs_nand_spl.c +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c @@ -283,11 +283,6 @@ int nand_spl_load_image(uint32_t offs, unsigned int size, void *buf) return 0; }

-struct mtd_info *nand_get_mtd(void) -{

•   return mtd;
  

-}

int nand_default_bbt(struct mtd_info *mtd) { return 0; -- 2.7.4

Ye Li,

Tested-by: Tim Harvey tharvey@gateworks.com #gw_ventana

Note however that I use UBIFS to store the kernel/dtb's and do not use a FIT image

Best Regards,

Tim