[U-Boot] [PULL] u-boot-usb/master
The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5:
Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:
usb: xhci: Set 'Average TRB Length' to 8 for control endpoints (2017-09-23 15:12:29 +0200)
---------------------------------------------------------------- Bin Meng (20): dm: usb: Add a new USB controller operation 'get_max_xfer_size' dm: usb: xhci: Implement get_max_xfer_size() operation dm: usb: ehci: Implement get_max_xfer_size() operation usb: storage: Refactor to use max_xfer_blk from struct us_data dm: usb: storage: Fix broken read/write when both EHCD and xHCD are enabled usb: kbd: Set a default polling mechanism for USB keyboard dm: usb: Fix broken usb_stop() dm: usb: Remove no longer needed blk_unbind_all() usb: xhci: Don't assume LS/FS devices are always behind a HS hub usb: Handle audio extension endpoint descriptor in usb_parse_config() usb: xhci: Add interrupt transfer support
usb: Only get 64 bytes device descriptor for full speed devices
usb: Read device descriptor after device is addressed for xHCI
usb: xhci: Fix max packet size for full speed device endpoint 0
usb: hub: Clear port reset before usb_hub_port_connect_change()
usb: hub: Clear BH reset status change for a 3.0 hub
usb: xhci: Honor endpoint's interval usb: xhci: Program max burst size for endpoint usb: xhci: Set 'Error Count' to 0 for isoch endpoints usb: xhci: Set 'Average TRB Length' to 8 for control endpoints
Eddie Cai (4): usb: rockchip: add the rockusb gadget usb: rockchip: add rockusb command rockchip:usb: add a simple readme for rockusb rockchip: rk3288: enable rockusb support on rk3288 based device
Marek Vasut (1): usb: xhci: Set number of event segments and entries to 1
Philipp Tomsich (3): rockchip: xhci: Convert to livetree usb: dwc2: convert to livetree usb: host: ehci-generic: convert to livetree
Seung-Woo Kim (1): usb: dwc2: Align size of invalidating dcache before starting DMA
arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++++++++++++++ arch/arm/mach-rockchip/Kconfig | 2 + cmd/Kconfig | 9 ++ cmd/Makefile | 1 + cmd/rockusb.c | 74 ++++++++++ common/usb.c | 45 +++--- common/usb_hub.c | 16 ++- common/usb_storage.c | 64 ++++++--- configs/Cyrus_P5020_defconfig | 1 - configs/Cyrus_P5040_defconfig | 1 - configs/MPC8610HPCD_defconfig | 1 - configs/MPC8641HPCN_36BIT_defconfig | 1 - configs/MPC8641HPCN_defconfig | 1 - configs/apalis_imx6_defconfig | 1 - configs/apalis_imx6_nospl_com_defconfig | 1 - configs/apalis_imx6_nospl_it_defconfig | 1 - configs/chromebit_mickey_defconfig | 8 ++ configs/chromebook_jerry_defconfig | 8 ++ configs/chromebook_minnie_defconfig | 8 ++ configs/colibri_imx6_defconfig | 1 - configs/colibri_imx6_nospl_defconfig | 1 - configs/evb-rk3288_defconfig | 10 ++ configs/fennec-rk3288_defconfig | 6 + configs/firefly-rk3288_defconfig | 7 +- configs/miqi-rk3288_defconfig | 6 + configs/mx6cuboxi_defconfig | 1 - configs/phycore-rk3288_defconfig | 7 + configs/popmetal-rk3288_defconfig | 6 + configs/rock2_defconfig | 9 ++ configs/rpi_2_defconfig | 1 - configs/rpi_3_32b_defconfig | 1 - configs/rpi_3_defconfig | 1 - configs/rpi_defconfig | 1 - configs/sandbox_defconfig | 1 - configs/sandbox_flattree_defconfig | 1 - configs/sandbox_noblk_defconfig | 1 - configs/sandbox_spl_defconfig | 1 - configs/seaboard_defconfig | 1 - configs/tinker-rk3288_defconfig | 6 + configs/ventana_defconfig | 1 - doc/README.rockusb | 51 +++++++ drivers/usb/Kconfig | 2 +- drivers/usb/gadget/Kconfig | 8 ++ drivers/usb/gadget/Makefile | 1 + drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 3 +- drivers/usb/gadget/f_rockusb.c | 691 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/usb/host/dwc2.c | 2 +- drivers/usb/host/ehci-generic.c | 2 +- drivers/usb/host/ehci-hcd.c | 12 ++ drivers/usb/host/usb-uclass.c | 30 +++- drivers/usb/host/xhci-mem.c | 24 +++- drivers/usb/host/xhci-rockchip.c | 4 +- drivers/usb/host/xhci.c | 264 ++++++++++++++++++++++++++++++++-- drivers/usb/host/xhci.h | 9 +- include/configs/rk3288_common.h | 12 ++ include/linux/usb/ch9.h | 20 +++ include/usb.h | 22 ++- 57 files changed, 1509 insertions(+), 93 deletions(-) create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h create mode 100644 cmd/rockusb.c create mode 100644 doc/README.rockusb create mode 100644 drivers/usb/gadget/f_rockusb.c
On Sat, Sep 23, 2017 at 03:14:20PM +0200, Marek Vasut wrote:
The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5:
Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:
usb: xhci: Set 'Average TRB Length' to 8 for control endpoints (2017-09-23 15:12:29 +0200)
git bisect says that: commit 5c45fbd38ecd6388f6d3ee1e07126b17d7e0c6b3 Author: Bin Meng bmeng.cn@gmail.com Date: Mon Sep 18 06:40:37 2017 -0700
dm: usb: Fix broken usb_stop()
breaks 'make tests'.
On 09/23/2017 06:11 PM, Tom Rini wrote:
On Sat, Sep 23, 2017 at 03:14:20PM +0200, Marek Vasut wrote:
The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5:
Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:
usb: xhci: Set 'Average TRB Length' to 8 for control endpoints (2017-09-23 15:12:29 +0200)
git bisect says that: commit 5c45fbd38ecd6388f6d3ee1e07126b17d7e0c6b3 Author: Bin Meng bmeng.cn@gmail.com Date: Mon Sep 18 06:40:37 2017 -0700
dm: usb: Fix broken usb_stop()breaks 'make tests'.
Unfortunately, for me the bisect points to: commit 2fa73e784da105419b7d9d07d8f9d4a79afe531a Author: Tom Rini trini@konsulko.com Date: Fri Sep 15 13:15:25 2017 -0400
Makefile: Update minimum dtc version to 1.4.3
With support for overlays and calling the -@ flag to dtc we need to have at least 1.4.3 available now.
Cc: Simon Glass sjg@chromium.org Reported-by: Stephen Warren swarren@wwwdotorg.org Signed-off-by: Tom Rini trini@konsulko.com
And it is broken on EVERY debian system, since every debian system ships with DTC 1.4.2 or older: https://packages.debian.org/search?keywords=device-tree-compiler
On Sat, Sep 23, 2017 at 07:32:31PM +0200, Marek Vasut wrote:
On 09/23/2017 06:11 PM, Tom Rini wrote:
On Sat, Sep 23, 2017 at 03:14:20PM +0200, Marek Vasut wrote:
The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5:
Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:
usb: xhci: Set 'Average TRB Length' to 8 for control endpoints (2017-09-23 15:12:29 +0200)
git bisect says that: commit 5c45fbd38ecd6388f6d3ee1e07126b17d7e0c6b3 Author: Bin Meng bmeng.cn@gmail.com Date: Mon Sep 18 06:40:37 2017 -0700
dm: usb: Fix broken usb_stop()breaks 'make tests'.
Unfortunately, for me the bisect points to: commit 2fa73e784da105419b7d9d07d8f9d4a79afe531a Author: Tom Rini trini@konsulko.com Date: Fri Sep 15 13:15:25 2017 -0400
Makefile: Update minimum dtc version to 1.4.3 With support for overlays and calling the -@ flag to dtc we need to have at least 1.4.3 available now. Cc: Simon Glass <sjg@chromium.org> Reported-by: Stephen Warren <swarren@wwwdotorg.org> Signed-off-by: Tom Rini <trini@konsulko.com>And it is broken on EVERY debian system, since every debian system ships with DTC 1.4.2 or older: https://packages.debian.org/search?keywords=device-tree-compiler
Please make sure that you submit your pull requests to travis-ci before sending them to me. And I'm not trying to single you out here, we have a whole bunch of automated CI and I do get a little cranky when we hit problems that the tools catch.
And yes, sure, don't submit PRs you're absolutely sure won't have problems that CI would have caught (like the SoCFPGA one) or when you've locally run all of the relevant tests yourself.
On 09/23/2017 07:39 PM, Tom Rini wrote:
On Sat, Sep 23, 2017 at 07:32:31PM +0200, Marek Vasut wrote:
On 09/23/2017 06:11 PM, Tom Rini wrote:
On Sat, Sep 23, 2017 at 03:14:20PM +0200, Marek Vasut wrote:
The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5:
Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:
usb: xhci: Set 'Average TRB Length' to 8 for control endpoints (2017-09-23 15:12:29 +0200)
git bisect says that: commit 5c45fbd38ecd6388f6d3ee1e07126b17d7e0c6b3 Author: Bin Meng bmeng.cn@gmail.com Date: Mon Sep 18 06:40:37 2017 -0700
dm: usb: Fix broken usb_stop()breaks 'make tests'.
Unfortunately, for me the bisect points to: commit 2fa73e784da105419b7d9d07d8f9d4a79afe531a Author: Tom Rini trini@konsulko.com Date: Fri Sep 15 13:15:25 2017 -0400
Makefile: Update minimum dtc version to 1.4.3 With support for overlays and calling the -@ flag to dtc we need to have at least 1.4.3 available now. Cc: Simon Glass <sjg@chromium.org> Reported-by: Stephen Warren <swarren@wwwdotorg.org> Signed-off-by: Tom Rini <trini@konsulko.com>And it is broken on EVERY debian system, since every debian system ships with DTC 1.4.2 or older: https://packages.debian.org/search?keywords=device-tree-compiler
Please make sure that you submit your pull requests to travis-ci before sending them to me. And I'm not trying to single you out here, we have a whole bunch of automated CI and I do get a little cranky when we hit problems that the tools catch.
And yes, sure, don't submit PRs you're absolutely sure won't have problems that CI would have caught (like the SoCFPGA one) or when you've locally run all of the relevant tests yourself.
Clearly, travis does not catch "u-boot does not build for any debian system" this time.
The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:
tools/mkimage: Make the path to the dtc binary that mkimage calls configurable (2017-09-24 07:33:03 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to 0184c6fb34b49f0bb1ffc7b0e35a597de339353e:
usb: dwc2: Align size of invalidating dcache before starting DMA (2017-09-24 18:45:56 +0200)
---------------------------------------------------------------- Bin Meng (6): dm: usb: Add a new USB controller operation 'get_max_xfer_size' dm: usb: xhci: Implement get_max_xfer_size() operation dm: usb: ehci: Implement get_max_xfer_size() operation usb: storage: Refactor to use max_xfer_blk from struct us_data dm: usb: storage: Fix broken read/write when both EHCD and xHCD are enabled usb: kbd: Set a default polling mechanism for USB keyboard
Eddie Cai (4): usb: rockchip: add the rockusb gadget usb: rockchip: add rockusb command rockchip:usb: add a simple readme for rockusb rockchip: rk3288: enable rockusb support on rk3288 based device
Marek Vasut (1): usb: xhci: Set number of event segments and entries to 1
Philipp Tomsich (3): rockchip: xhci: Convert to livetree usb: dwc2: convert to livetree usb: host: ehci-generic: convert to livetree
Seung-Woo Kim (1): usb: dwc2: Align size of invalidating dcache before starting DMA
arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++++++++++++++ arch/arm/mach-rockchip/Kconfig | 2 + cmd/Kconfig | 9 ++ cmd/Makefile | 1 + cmd/rockusb.c | 74 ++++++++++ common/usb_storage.c | 64 ++++++--- configs/Cyrus_P5020_defconfig | 1 - configs/Cyrus_P5040_defconfig | 1 - configs/MPC8610HPCD_defconfig | 1 - configs/MPC8641HPCN_36BIT_defconfig | 1 - configs/MPC8641HPCN_defconfig | 1 - configs/apalis_imx6_defconfig | 1 - configs/apalis_imx6_nospl_com_defconfig | 1 - configs/apalis_imx6_nospl_it_defconfig | 1 - configs/chromebit_mickey_defconfig | 8 ++ configs/chromebook_jerry_defconfig | 8 ++ configs/chromebook_minnie_defconfig | 8 ++ configs/colibri_imx6_defconfig | 1 - configs/colibri_imx6_nospl_defconfig | 1 - configs/evb-rk3288_defconfig | 10 ++ configs/fennec-rk3288_defconfig | 6 + configs/firefly-rk3288_defconfig | 7 +- configs/miqi-rk3288_defconfig | 6 + configs/mx6cuboxi_defconfig | 1 - configs/phycore-rk3288_defconfig | 7 + configs/popmetal-rk3288_defconfig | 6 + configs/rock2_defconfig | 9 ++ configs/rpi_2_defconfig | 1 - configs/rpi_3_32b_defconfig | 1 - configs/rpi_3_defconfig | 1 - configs/rpi_defconfig | 1 - configs/sandbox_defconfig | 1 - configs/sandbox_flattree_defconfig | 1 - configs/sandbox_noblk_defconfig | 1 - configs/sandbox_spl_defconfig | 1 - configs/seaboard_defconfig | 1 - configs/tinker-rk3288_defconfig | 6 + configs/ventana_defconfig | 1 - doc/README.rockusb | 51 +++++++ drivers/usb/Kconfig | 2 +- drivers/usb/gadget/Kconfig | 8 ++ drivers/usb/gadget/Makefile | 1 + drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 3 +- drivers/usb/gadget/f_rockusb.c | 691 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/usb/host/dwc2.c | 2 +- drivers/usb/host/ehci-generic.c | 2 +- drivers/usb/host/ehci-hcd.c | 12 ++ drivers/usb/host/usb-uclass.c | 11 ++ drivers/usb/host/xhci-rockchip.c | 4 +- drivers/usb/host/xhci.c | 15 ++ drivers/usb/host/xhci.h | 4 +- include/configs/rk3288_common.h | 12 ++ include/usb.h | 22 ++- 53 files changed, 1173 insertions(+), 51 deletions(-) create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h create mode 100644 cmd/rockusb.c create mode 100644 doc/README.rockusb create mode 100644 drivers/usb/gadget/f_rockusb.c
Hi Marek,
On Tue, Sep 26, 2017 at 12:41 AM, Marek Vasut marex@denx.de wrote:
The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:
tools/mkimage: Make the path to the dtc binary that mkimage calls configurable (2017-09-24 07:33:03 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to 0184c6fb34b49f0bb1ffc7b0e35a597de339353e:
usb: dwc2: Align size of invalidating dcache before starting DMA (2017-09-24 18:45:56 +0200)
Bin Meng (6): dm: usb: Add a new USB controller operation 'get_max_xfer_size' dm: usb: xhci: Implement get_max_xfer_size() operation dm: usb: ehci: Implement get_max_xfer_size() operation usb: storage: Refactor to use max_xfer_blk from struct us_data dm: usb: storage: Fix broken read/write when both EHCD and xHCD are enabled usb: kbd: Set a default polling mechanism for USB keyboard
I see this new PR does not contain the xHCI updates while previous one had. Any reason to drop that?
Eddie Cai (4): usb: rockchip: add the rockusb gadget usb: rockchip: add rockusb command rockchip:usb: add a simple readme for rockusb rockchip: rk3288: enable rockusb support on rk3288 based device
Marek Vasut (1): usb: xhci: Set number of event segments and entries to 1
Philipp Tomsich (3): rockchip: xhci: Convert to livetree usb: dwc2: convert to livetree usb: host: ehci-generic: convert to livetree
Seung-Woo Kim (1): usb: dwc2: Align size of invalidating dcache before starting DMA
Regards, Bin
On Tue, Sep 26, 2017 at 07:10:21AM +0800, Bin Meng wrote:
Hi Marek,
On Tue, Sep 26, 2017 at 12:41 AM, Marek Vasut marex@denx.de wrote:
The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:
tools/mkimage: Make the path to the dtc binary that mkimage calls configurable (2017-09-24 07:33:03 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to 0184c6fb34b49f0bb1ffc7b0e35a597de339353e:
usb: dwc2: Align size of invalidating dcache before starting DMA (2017-09-24 18:45:56 +0200)
Bin Meng (6): dm: usb: Add a new USB controller operation 'get_max_xfer_size' dm: usb: xhci: Implement get_max_xfer_size() operation dm: usb: ehci: Implement get_max_xfer_size() operation usb: storage: Refactor to use max_xfer_blk from struct us_data dm: usb: storage: Fix broken read/write when both EHCD and xHCD are enabled usb: kbd: Set a default polling mechanism for USB keyboard
I see this new PR does not contain the xHCI updates while previous one had. Any reason to drop that?
Yes, these break some of the tests in test/py/ as seen by 'make tests', thanks!
On Mon, Sep 25, 2017 at 06:41:58PM +0200, Marek Vasut wrote:
The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:
tools/mkimage: Make the path to the dtc binary that mkimage calls configurable (2017-09-24 07:33:03 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to 0184c6fb34b49f0bb1ffc7b0e35a597de339353e:
usb: dwc2: Align size of invalidating dcache before starting DMA (2017-09-24 18:45:56 +0200)
This breaks building of vyasa-rk3288 and introduces a bunch of warnings over stuff that's in Kconfig being re-added to config.h files. And I guess the rockusb stuff was applied oddly, all of the comments below the '---' are in the commit message rather than discarded as usual. Sorry, thanks!
The following changes since commit 9241265f29f3670e380a9859a343ddc14873c46f:
Merge git://www.denx.de/git/u-boot-cfi-flash (2017-09-26 19:38:04 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to a939af0c748e2ea1eeb8cf47fa9771a95786de70:
usb: dwc2: Align size of invalidating dcache before starting DMA (2017-09-27 12:12:23 +0200)
---------------------------------------------------------------- Bin Meng (6): dm: usb: Add a new USB controller operation 'get_max_xfer_size' dm: usb: xhci: Implement get_max_xfer_size() operation dm: usb: ehci: Implement get_max_xfer_size() operation usb: storage: Refactor to use max_xfer_blk from struct us_data dm: usb: storage: Fix broken read/write when both EHCD and xHCD are enabled usb: kbd: Set a default polling mechanism for USB keyboard
Marek Vasut (1):
usb: xhci: Set number of event segments and entries to 1
Philipp Tomsich (3): rockchip: xhci: Convert to livetree usb: dwc2: convert to livetree usb: host: ehci-generic: convert to livetree
Seung-Woo Kim (1): usb: dwc2: Align size of invalidating dcache before starting DMA
common/usb_storage.c | 64 +++++++++++++++++++++++++++++++++++++++++++++------------------- configs/Cyrus_P5020_defconfig | 1 - configs/Cyrus_P5040_defconfig | 1 - configs/MPC8610HPCD_defconfig | 1 - configs/MPC8641HPCN_36BIT_defconfig | 1 - configs/MPC8641HPCN_defconfig | 1 - configs/apalis_imx6_defconfig | 1 - configs/apalis_imx6_nospl_com_defconfig | 1 - configs/apalis_imx6_nospl_it_defconfig | 1 - configs/colibri_imx6_defconfig | 1 - configs/colibri_imx6_nospl_defconfig | 1 - configs/firefly-rk3288_defconfig | 1 - configs/mx6cuboxi_defconfig | 1 - configs/rpi_2_defconfig | 1 - configs/rpi_3_32b_defconfig | 1 - configs/rpi_3_defconfig | 1 - configs/rpi_defconfig | 1 - configs/sandbox_defconfig | 1 - configs/sandbox_flattree_defconfig | 1 - configs/sandbox_noblk_defconfig | 1 - configs/sandbox_spl_defconfig | 1 - configs/seaboard_defconfig | 1 - configs/ventana_defconfig | 1 - drivers/usb/Kconfig | 2 +- drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 3 ++- drivers/usb/host/dwc2.c | 2 +- drivers/usb/host/ehci-generic.c | 2 +- drivers/usb/host/ehci-hcd.c | 12 ++++++++++++ drivers/usb/host/usb-uclass.c | 11 +++++++++++ drivers/usb/host/xhci-rockchip.c | 4 +--- drivers/usb/host/xhci.c | 15 +++++++++++++++ drivers/usb/host/xhci.h | 4 ++-- include/usb.h | 22 +++++++++++++++++++++- 33 files changed, 112 insertions(+), 51 deletions(-)
On Wed, Sep 27, 2017 at 03:35:26PM +0200, Marek Vasut wrote:
The following changes since commit 9241265f29f3670e380a9859a343ddc14873c46f:
Merge git://www.denx.de/git/u-boot-cfi-flash (2017-09-26 19:38:04 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to a939af0c748e2ea1eeb8cf47fa9771a95786de70:
usb: dwc2: Align size of invalidating dcache before starting DMA (2017-09-27 12:12:23 +0200)
Applied to u-boot/master, thanks!
participants (3)
-
Bin Meng -
Marek Vasut -
Tom Rini