[U-Boot-Users] Patch for ModNET50 board and NET+50 CPU

Hi all,
I've ported U-Boot for the ModNET50 board from FSForth. The board uses a NET+50 CPU from Netsilicon, an ARM7TDMI without MMU. A patch for this CPU is also included.
The patch is against todays CVS version, I've tested it by downloading, flashing and booting uCLinux, everything seems to work fine. If nevertheless anything is wrong with the code, please let me know.
best regards Thomas
-- Thomas Elste Institut fuer Mikroelektronik- und Mechatronik-Systeme www.imms.de Langewiesener Strasse 22 98693 Ilmenau

In message opr2ycf4kg940igx@smtp.elste.org you wrote:
I've ported U-Boot for the ModNET50 board from FSForth. The board uses a NET+50 CPU from Netsilicon, an ARM7TDMI without MMU. A patch for this CPU is also included.
At first glance I see little difference between your code in cpu/netarm and what we already have in cpu/arm720t - and nothing that could not be implemente dby a few #ifdef's.
Why do you think this is a so different type of CPU that we will need a new CPU directory?
If possible, I would like to avoid creating a new CPU directory which just duplicates existing code.
The patch is against todays CVS version, I've tested it by downloading, flashing and booting uCLinux, everything seems to work fine. If nevertheless anything is wrong with the code, please let me know.
In the meantime I added the patch which changed the ARM memory layout. This obsoletes your patch.
I'm afraid I have to ask you to resubmit this patch.
Best regards,
Wolfgang Denk

I've ported U-Boot for the ModNET50 board from FSForth. The board uses a NET+50 CPU from Netsilicon, an ARM7TDMI without MMU. A patch for this CPU is also included.
If possible, I would like to avoid creating a new CPU directory which just duplicates existing code.
Ok, I've changed the layout, so that the arm720t cpu directory is used. The serial i/o stuff differs a lot, so I've created a new file: serial_netarm.c . Anything else is done by ifdefs now.
In the meantime I added the patch which changed the ARM memory layout. This obsoletes your patch.
I'm afraid I have to ask you to resubmit this patch.
No problem, here's the new one (against todays CVS).
best regards Thomas

In message opr25utze9940igx@smtp.elste.org you wrote:
Ok, I've changed the layout, so that the arm720t cpu directory is used. The serial i/o stuff differs a lot, so I've created a new file: serial_netarm.c . Anything else is done by ifdefs now.
Thanks, added.
I moved some files around to avoid having architecture specific files in the common include/ directory.
Also, I had to cleanup you code a lot - next time please check section "Coding Style" in the README.
Please also submit another patch to add the required entries to the MAINTAINERS and CREDITS files.
Best regards,
Wolfgang Denk
participants (2)
-
Thomas Elste
-
Wolfgang Denk