[PATCH] i2c: mxc_i2c: Use hex notation for the base address
Printing the I2C controller base address in decimal notation is not helpful.
Change it to hex notation, which is the standard format found in the Reference Manual and devicetree.
Signed-off-by: Fabio Estevam festevam@denx.de --- drivers/i2c/mxc_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c index f80ff5383b..9dd349d056 100644 --- a/drivers/i2c/mxc_i2c.c +++ b/drivers/i2c/mxc_i2c.c @@ -938,7 +938,7 @@ static int mxc_i2c_probe(struct udevice *bus) * we can set pinmux here in probe function. */
- debug("i2c : controller bus %d at %lu , speed %d: ", + debug("i2c : controller bus %d at 0x%lx , speed %d: ", dev_seq(bus), i2c_bus->base, i2c_bus->speed);
On 04/01/23 00:33, Fabio Estevam wrote:
Printing the I2C controller base address in decimal notation is not helpful.
Change it to hex notation, which is the standard format found in the Reference Manual and devicetree.
Agree
Signed-off-by: Fabio Estevam festevam@denx.de
Acked-by: Dhruva Gole d-gole@ti.com
drivers/i2c/mxc_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c index f80ff5383b..9dd349d056 100644 --- a/drivers/i2c/mxc_i2c.c +++ b/drivers/i2c/mxc_i2c.c @@ -938,7 +938,7 @@ static int mxc_i2c_probe(struct udevice *bus) * we can set pinmux here in probe function. */
- debug("i2c : controller bus %d at %lu , speed %d: ",
- debug("i2c : controller bus %d at 0x%lx , speed %d: ", dev_seq(bus), i2c_bus->base, i2c_bus->speed);
Hello Fabio,
On 03.01.23 20:03, Fabio Estevam wrote:
Printing the I2C controller base address in decimal notation is not helpful.
Change it to hex notation, which is the standard format found in the Reference Manual and devicetree.
Signed-off-by: Fabio Estevam festevam@denx.de
drivers/i2c/mxc_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Heiko Schocher hs@denx.de
Thanks!
bye, Heiko
Hello Fabio,
On 03.01.23 20:03, Fabio Estevam wrote:
Printing the I2C controller base address in decimal notation is not helpful.
Change it to hex notation, which is the standard format found in the Reference Manual and devicetree.
Signed-off-by: Fabio Estevam festevam@denx.de Acked-by: Dhruva Gole d-gole@ti.com Reviewed-by: Heiko Schocher hs@denx.de
drivers/i2c/mxc_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-i2c.git master
bye, Heiko
participants (3)
-
Dhruva Gole -
Fabio Estevam -
Heiko Schocher