[U-Boot] [PATCH] usb: dwc3: Add missing dependency on MISC uclass
Generic wrapper requires MISC uclass but dependency is not covered in Kconfig.
misc 0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d0000 usb_dev_ge 0 [ + ] dwc3-generic-periphe | | `-- dwc3@fe200000 misc 1 [ ] dwc3-generic-wrapper | |-- usb1@ff9e0000 usb 0 [ ] dwc3-generic-host | | `-- dwc3@fe300000 watchdog 0 [ + ] cdns_wdt | `-- watchdog@fd4d0000
Signed-off-by: Michal Simek michal.simek@xilinx.com ---
drivers/usb/dwc3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 943b7630eba4..9f0b8a2d0b4f 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -39,7 +39,7 @@ config USB_DWC3_OMAP
config USB_DWC3_GENERIC bool "Xilinx ZynqMP and similar Platforms" - depends on DM_USB && USB_DWC3 + depends on DM_USB && USB_DWC3 && MISC help Some platforms can reuse this DWC3 generic implementation.
On 12/05/2018 09:05 AM, Michal Simek wrote:
Generic wrapper requires MISC uclass but dependency is not covered in Kconfig.
misc 0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d0000 usb_dev_ge 0 [ + ] dwc3-generic-periphe | | `-- dwc3@fe200000 misc 1 [ ] dwc3-generic-wrapper | |-- usb1@ff9e0000 usb 0 [ ] dwc3-generic-host | | `-- dwc3@fe300000 watchdog 0 [ + ] cdns_wdt | `-- watchdog@fd4d0000
Signed-off-by: Michal Simek michal.simek@xilinx.com
drivers/usb/dwc3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 943b7630eba4..9f0b8a2d0b4f 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -39,7 +39,7 @@ config USB_DWC3_OMAP
config USB_DWC3_GENERIC bool "Xilinx ZynqMP and similar Platforms"
- depends on DM_USB && USB_DWC3
- depends on DM_USB && USB_DWC3 && MISC
Platforms which do not select MISC will lose DWC3 now, did you verify that no platform is affected ?
help Some platforms can reuse this DWC3 generic implementation.
On 05. 12. 18 14:26, Marek Vasut wrote:
On 12/05/2018 09:05 AM, Michal Simek wrote:
Generic wrapper requires MISC uclass but dependency is not covered in Kconfig.
misc 0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d0000 usb_dev_ge 0 [ + ] dwc3-generic-periphe | | `-- dwc3@fe200000 misc 1 [ ] dwc3-generic-wrapper | |-- usb1@ff9e0000 usb 0 [ ] dwc3-generic-host | | `-- dwc3@fe300000 watchdog 0 [ + ] cdns_wdt | `-- watchdog@fd4d0000
Signed-off-by: Michal Simek michal.simek@xilinx.com
drivers/usb/dwc3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 943b7630eba4..9f0b8a2d0b4f 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -39,7 +39,7 @@ config USB_DWC3_OMAP
config USB_DWC3_GENERIC bool "Xilinx ZynqMP and similar Platforms"
- depends on DM_USB && USB_DWC3
- depends on DM_USB && USB_DWC3 && MISC
Platforms which do not select MISC will lose DWC3 now, did you verify that no platform is affected ?
This is what it is going to happen when MISC is not enabled.
Model: ZynqMP ZCU100 RevC Board: Xilinx ZynqMP I2C: ready DRAM: 2 GiB Cannot find uclass for id 39: please add the UCLASS_DRIVER() declaration for this UCLASS_... id Error binding driver 'dwc3-generic-wrapper': -96 Cannot find uclass for id 39: please add the UCLASS_DRIVER() declaration for this UCLASS_... id Error binding driver 'dwc3-generic-wrapper': -96 Some drivers failed to bind Error binding driver 'generic_simple_bus': -96 Some drivers failed to bind initcall sequence 000000007ff9c3c8 failed at call 0000000008015728 (err=-96) ### ERROR ### Please RESET the board ###
It means if any platform is not enabling MISC then they have bigger problem then just missing DWC3.
Anyway only ZynqMP board enables it and all of them have MISC enabled.
[u-boot](wd)$ git log -n 1 --oneline d452f27b3ea8 Prepare v2019.01-rc1 [u-boot](wd)$ git grep DWC3_GENERIC configs/avnet_ultra96_rev1_defconfig:83:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm015_dc1_defconfig:89:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm016_dc2_defconfig:82:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm017_dc3_defconfig:80:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu100_revC_defconfig:83:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_rev1_0_defconfig:108:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_revA_defconfig:105:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_revB_defconfig:105:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu104_revA_defconfig:88:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu104_revC_defconfig:89:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu106_revA_defconfig:97:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu111_revA_defconfig:90:CONFIG_USB_DWC3_GENERIC=y drivers/usb/dwc3/Kconfig:40:config USB_DWC3_GENERIC drivers/usb/dwc3/Makefile:10:obj-$(CONFIG_USB_DWC3_GENERIC) += dwc3-generic.o
Thanks, Michal
On 12/05/2018 03:17 PM, Michal Simek wrote:
On 05. 12. 18 14:26, Marek Vasut wrote:
On 12/05/2018 09:05 AM, Michal Simek wrote:
Generic wrapper requires MISC uclass but dependency is not covered in Kconfig.
misc 0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d0000 usb_dev_ge 0 [ + ] dwc3-generic-periphe | | `-- dwc3@fe200000 misc 1 [ ] dwc3-generic-wrapper | |-- usb1@ff9e0000 usb 0 [ ] dwc3-generic-host | | `-- dwc3@fe300000 watchdog 0 [ + ] cdns_wdt | `-- watchdog@fd4d0000
Signed-off-by: Michal Simek michal.simek@xilinx.com
drivers/usb/dwc3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 943b7630eba4..9f0b8a2d0b4f 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -39,7 +39,7 @@ config USB_DWC3_OMAP
config USB_DWC3_GENERIC bool "Xilinx ZynqMP and similar Platforms"
- depends on DM_USB && USB_DWC3
- depends on DM_USB && USB_DWC3 && MISC
Platforms which do not select MISC will lose DWC3 now, did you verify that no platform is affected ?
This is what it is going to happen when MISC is not enabled.
Model: ZynqMP ZCU100 RevC Board: Xilinx ZynqMP I2C: ready DRAM: 2 GiB Cannot find uclass for id 39: please add the UCLASS_DRIVER() declaration for this UCLASS_... id Error binding driver 'dwc3-generic-wrapper': -96 Cannot find uclass for id 39: please add the UCLASS_DRIVER() declaration for this UCLASS_... id Error binding driver 'dwc3-generic-wrapper': -96 Some drivers failed to bind Error binding driver 'generic_simple_bus': -96 Some drivers failed to bind initcall sequence 000000007ff9c3c8 failed at call 0000000008015728 (err=-96) ### ERROR ### Please RESET the board ###
It means if any platform is not enabling MISC then they have bigger problem then just missing DWC3.
Anyway only ZynqMP board enables it and all of them have MISC enabled.
[u-boot](wd)$ git log -n 1 --oneline d452f27b3ea8 Prepare v2019.01-rc1 [u-boot](wd)$ git grep DWC3_GENERIC configs/avnet_ultra96_rev1_defconfig:83:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm015_dc1_defconfig:89:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm016_dc2_defconfig:82:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm017_dc3_defconfig:80:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu100_revC_defconfig:83:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_rev1_0_defconfig:108:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_revA_defconfig:105:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_revB_defconfig:105:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu104_revA_defconfig:88:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu104_revC_defconfig:89:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu106_revA_defconfig:97:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu111_revA_defconfig:90:CONFIG_USB_DWC3_GENERIC=y drivers/usb/dwc3/Kconfig:40:config USB_DWC3_GENERIC drivers/usb/dwc3/Makefile:10:obj-$(CONFIG_USB_DWC3_GENERIC) += dwc3-generic.o
I wanted to apply this, but it doesn't apply to u-boot-usb/master .
On 05. 12. 18 15:24, Marek Vasut wrote:
On 12/05/2018 03:17 PM, Michal Simek wrote:
On 05. 12. 18 14:26, Marek Vasut wrote:
On 12/05/2018 09:05 AM, Michal Simek wrote:
Generic wrapper requires MISC uclass but dependency is not covered in Kconfig.
misc 0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d0000 usb_dev_ge 0 [ + ] dwc3-generic-periphe | | `-- dwc3@fe200000 misc 1 [ ] dwc3-generic-wrapper | |-- usb1@ff9e0000 usb 0 [ ] dwc3-generic-host | | `-- dwc3@fe300000 watchdog 0 [ + ] cdns_wdt | `-- watchdog@fd4d0000
Signed-off-by: Michal Simek michal.simek@xilinx.com
drivers/usb/dwc3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 943b7630eba4..9f0b8a2d0b4f 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -39,7 +39,7 @@ config USB_DWC3_OMAP
config USB_DWC3_GENERIC bool "Xilinx ZynqMP and similar Platforms"
- depends on DM_USB && USB_DWC3
- depends on DM_USB && USB_DWC3 && MISC
Platforms which do not select MISC will lose DWC3 now, did you verify that no platform is affected ?
This is what it is going to happen when MISC is not enabled.
Model: ZynqMP ZCU100 RevC Board: Xilinx ZynqMP I2C: ready DRAM: 2 GiB Cannot find uclass for id 39: please add the UCLASS_DRIVER() declaration for this UCLASS_... id Error binding driver 'dwc3-generic-wrapper': -96 Cannot find uclass for id 39: please add the UCLASS_DRIVER() declaration for this UCLASS_... id Error binding driver 'dwc3-generic-wrapper': -96 Some drivers failed to bind Error binding driver 'generic_simple_bus': -96 Some drivers failed to bind initcall sequence 000000007ff9c3c8 failed at call 0000000008015728 (err=-96) ### ERROR ### Please RESET the board ###
It means if any platform is not enabling MISC then they have bigger problem then just missing DWC3.
Anyway only ZynqMP board enables it and all of them have MISC enabled.
[u-boot](wd)$ git log -n 1 --oneline d452f27b3ea8 Prepare v2019.01-rc1 [u-boot](wd)$ git grep DWC3_GENERIC configs/avnet_ultra96_rev1_defconfig:83:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm015_dc1_defconfig:89:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm016_dc2_defconfig:82:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm017_dc3_defconfig:80:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu100_revC_defconfig:83:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_rev1_0_defconfig:108:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_revA_defconfig:105:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_revB_defconfig:105:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu104_revA_defconfig:88:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu104_revC_defconfig:89:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu106_revA_defconfig:97:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu111_revA_defconfig:90:CONFIG_USB_DWC3_GENERIC=y drivers/usb/dwc3/Kconfig:40:config USB_DWC3_GENERIC drivers/usb/dwc3/Makefile:10:obj-$(CONFIG_USB_DWC3_GENERIC) += dwc3-generic.o
I wanted to apply this, but it doesn't apply to u-boot-usb/master .
Good thing on this is that "dwc3-generic: Handle the PHYs, the clocks and the reset lines" has done this change already. (Before I sent this I was checking Jean's patches for DWC3 but didn't find this change :-()
Anyway please ignore this patch.
Thanks, Michal
On 12/05/2018 03:29 PM, Michal Simek wrote:
On 05. 12. 18 15:24, Marek Vasut wrote:
On 12/05/2018 03:17 PM, Michal Simek wrote:
On 05. 12. 18 14:26, Marek Vasut wrote:
On 12/05/2018 09:05 AM, Michal Simek wrote:
Generic wrapper requires MISC uclass but dependency is not covered in Kconfig.
misc 0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d0000 usb_dev_ge 0 [ + ] dwc3-generic-periphe | | `-- dwc3@fe200000 misc 1 [ ] dwc3-generic-wrapper | |-- usb1@ff9e0000 usb 0 [ ] dwc3-generic-host | | `-- dwc3@fe300000 watchdog 0 [ + ] cdns_wdt | `-- watchdog@fd4d0000
Signed-off-by: Michal Simek michal.simek@xilinx.com
drivers/usb/dwc3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 943b7630eba4..9f0b8a2d0b4f 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -39,7 +39,7 @@ config USB_DWC3_OMAP
config USB_DWC3_GENERIC bool "Xilinx ZynqMP and similar Platforms"
- depends on DM_USB && USB_DWC3
- depends on DM_USB && USB_DWC3 && MISC
Platforms which do not select MISC will lose DWC3 now, did you verify that no platform is affected ?
This is what it is going to happen when MISC is not enabled.
Model: ZynqMP ZCU100 RevC Board: Xilinx ZynqMP I2C: ready DRAM: 2 GiB Cannot find uclass for id 39: please add the UCLASS_DRIVER() declaration for this UCLASS_... id Error binding driver 'dwc3-generic-wrapper': -96 Cannot find uclass for id 39: please add the UCLASS_DRIVER() declaration for this UCLASS_... id Error binding driver 'dwc3-generic-wrapper': -96 Some drivers failed to bind Error binding driver 'generic_simple_bus': -96 Some drivers failed to bind initcall sequence 000000007ff9c3c8 failed at call 0000000008015728 (err=-96) ### ERROR ### Please RESET the board ###
It means if any platform is not enabling MISC then they have bigger problem then just missing DWC3.
Anyway only ZynqMP board enables it and all of them have MISC enabled.
[u-boot](wd)$ git log -n 1 --oneline d452f27b3ea8 Prepare v2019.01-rc1 [u-boot](wd)$ git grep DWC3_GENERIC configs/avnet_ultra96_rev1_defconfig:83:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm015_dc1_defconfig:89:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm016_dc2_defconfig:82:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zc1751_xm017_dc3_defconfig:80:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu100_revC_defconfig:83:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_rev1_0_defconfig:108:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_revA_defconfig:105:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu102_revB_defconfig:105:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu104_revA_defconfig:88:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu104_revC_defconfig:89:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu106_revA_defconfig:97:CONFIG_USB_DWC3_GENERIC=y configs/xilinx_zynqmp_zcu111_revA_defconfig:90:CONFIG_USB_DWC3_GENERIC=y drivers/usb/dwc3/Kconfig:40:config USB_DWC3_GENERIC drivers/usb/dwc3/Makefile:10:obj-$(CONFIG_USB_DWC3_GENERIC) += dwc3-generic.o
I wanted to apply this, but it doesn't apply to u-boot-usb/master .
Good thing on this is that "dwc3-generic: Handle the PHYs, the clocks and the reset lines" has done this change already. (Before I sent this I was checking Jean's patches for DWC3 but didn't find this change :-()
Anyway please ignore this patch.
OK, thanks
participants (2)
-
Marek Vasut -
Michal Simek