[U-Boot-Users] [Patch] KVME080 Support
Hi, This patch adds support for KVME080 board. KVME080 is a VME board with MPC8245 CPU.
It also patches drivers/cfi_flash.c.
First, it adds CFG_FLASH_PROTECT_CLEAR because for some flash memories(such as 28F320C3) all banks are protected after reset.
Second, it makes write_buff not to call flash_write_cfibuffer if buffer_size is1. Because for flash memories with buffer_size 1, buffer write is not supported.
Third, it makes 64 bit writes to use FLASH_WRITE64 if FLASH_WRITE64 is defined. Because KVME080 needs it.
Fourth, it makes flash_detect_cfi call FLASH_PORTWIDTH when changing portwidth if FLASH_PORTWIDTH is defined. Because on some CPUs (such as MPC8245), port width should be changed.
Regards, Sangmoon Kim
In message 004e01c5a3db$3840e6f0$212d4cdc@smkim you wrote:
This patch adds support for KVME080 board. KVME080 is a VME board with MPC8245 CPU.
It also patches drivers/cfi_flash.c.
Can you please split your patch into two?
Please see section "Submitting Patches" in the README which explicitely requires:
Changesets that contain different, unrelated modifications shall be submitted as SEPARATE patches, one patch per changeset.
And please cleanup your code before re-submitting:
* It violates the coding style requirements (trailing white space).
* Using globally visible preprocessor defines like FLASH_WRITE64 is not acceptable (you also forgot to document these, but that would help either), and defining such code in the board config file is the wrong way to implement it either. The board config file is - ummm, a _configuration_ file, but does not contain source code.
Also: please read the recent "U-Boot Developer's Information" posting; you are supposed to provide a "sign-off" line for all patches.
Rejected, sorry.
Best regards,
Wolfgang Denk
Hi,
Can you please split your patch into two?
I splited the patch and extracted KVME080 parts only.
And please cleanup your code before re-submitting:
- It violates the coding style requirements (trailing white space).
Sorry, I was suprised that my code had so many white spaces. I am sure I fixed all of it now.
- Using globally visible preprocessor defines like FLASH_WRITE64 is
not acceptable (you also forgot to document these, but that would help either), and defining such code in the board config file is the wrong way to implement it either. The board config file is - ummm, a _configuration_ file, but does not contain source code.
I deleted the 'source code' from the board configuration file. The current version of KVME080 board runs well without patching cfi_flash.c I'll find an alternative way and send the patch for cfi_flash.c later.
Also: please read the recent "U-Boot Developer's Information" posting; you are supposed to provide a "sign-off" line for all patches.
I added the "sign-off" line at the end of the patch.
Regards, Sangmoon Kim
In message 005001c5a46d$4fb80e20$212d4cdc@smkim you wrote:
I splited the patch and extracted KVME080 parts only.
Added, thanks.
But please check your code - it does not compile; it runs into an endless loop when trying to byils the srec image. I guess either your memory map and/or your linker script is broken.
Best regards,
Wolfgang Denk
participants (2)
-
Sangmoon Kim -
Wolfgang Denk