[U-Boot] [PATCH] yaffs2: Remove block number check from summary verification

The summary already has other verification. This one is not needed.
The check caused summaries to be ignored if they were not on the numbered block. This caused problems when a summary was embedded in an image and the image is written to a flash with bad blocks.
Signed-off-by: Charles Manning cdhmanning@gmail.com --- fs/yaffs2/yaffs_summary.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/fs/yaffs2/yaffs_summary.c b/fs/yaffs2/yaffs_summary.c index 46e42f6..e9e1b5d 100644 --- a/fs/yaffs2/yaffs_summary.c +++ b/fs/yaffs2/yaffs_summary.c @@ -232,7 +232,6 @@ int yaffs_summary_read(struct yaffs_dev *dev, if (result == YAFFS_OK) { /* Verify header */ if (hdr.version != YAFFS_SUMMARY_VERSION || - hdr.block != blk || hdr.seq != bi->seq_number || hdr.sum != yaffs_summary_sum(dev)) result = YAFFS_FAIL;

On Mon, Jan 20, 2014 at 03:51:59PM +1300, Charles Manning wrote:
The summary already has other verification. This one is not needed.
The check caused summaries to be ignored if they were not on the numbered block. This caused problems when a summary was embedded in an image and the image is written to a flash with bad blocks.
Signed-off-by: Charles Manning cdhmanning@gmail.com
Applied to u-boot/master, thanks!
participants (2)
-
Charles Manning
-
Tom Rini