[U-Boot] [PATCH v2] net: macb: fix mapping of registers
Some architectures (MIPS) needs mapping to access IOMEM. Fix that.
Fixes: f1dcc19b213d ("net: macb: Convert to driver model")
Signed-off-by: Ramon Fried ramon.fried@gmail.com --- v2: switched to use dev_reamp_addr() to reduce boilerplate code. (as suggested by Daniel Schwierzeck)
drivers/net/macb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 94c89c762b..ede1277901 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -1151,7 +1151,9 @@ static int macb_eth_ofdata_to_platdata(struct udevice *dev) { struct eth_pdata *pdata = dev_get_platdata(dev);
- pdata->iobase = devfdt_get_addr(dev); + pdata->iobase = dev_remap_addr(dev); + if (!pdata->iobase) + return -EINVAL;
return macb_late_eth_ofdata_to_platdata(dev); }
Am 18.12.18 um 21:49 schrieb Ramon Fried:
Some architectures (MIPS) needs mapping to access IOMEM. Fix that.
Fixes: f1dcc19b213d ("net: macb: Convert to driver model")
Signed-off-by: Ramon Fried ramon.fried@gmail.com
v2: switched to use dev_reamp_addr() to reduce boilerplate code. (as suggested by Daniel Schwierzeck)
drivers/net/macb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Daniel Schwierzeck daniel.schwierzeck@gmail.com
On Tue, Dec 18, 2018 at 10:49:03PM +0200, Ramon Fried wrote:
Some architectures (MIPS) needs mapping to access IOMEM. Fix that.
Fixes: f1dcc19b213d ("net: macb: Convert to driver model")
Signed-off-by: Ramon Fried ramon.fried@gmail.com Reviewed-by: Daniel Schwierzeck daniel.schwierzeck@gmail.com
v2: switched to use dev_reamp_addr() to reduce boilerplate code. (as suggested by Daniel Schwierzeck)
On many platforms: arm: w+ sama5d36ek_cmp_nandflash +(sama5d36ek_cmp_nandflash) pdata->iobase = dev_remap_addr(dev); +(sama5d36ek_cmp_nandflash) ^ w+(sama5d36ek_cmp_nandflash) drivers/net/macb.c: In function 'macb_eth_ofdata_to_platdata': w+(sama5d36ek_cmp_nandflash) drivers/net/macb.c:1154:16: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
On Thu, Dec 27, 2018 at 4:35 AM Tom Rini trini@konsulko.com wrote:
On Tue, Dec 18, 2018 at 10:49:03PM +0200, Ramon Fried wrote:
Some architectures (MIPS) needs mapping to access IOMEM. Fix that.
Fixes: f1dcc19b213d ("net: macb: Convert to driver model")
Signed-off-by: Ramon Fried ramon.fried@gmail.com Reviewed-by: Daniel Schwierzeck daniel.schwierzeck@gmail.com
v2: switched to use dev_reamp_addr() to reduce boilerplate code. (as suggested by Daniel Schwierzeck)
On many platforms: arm: w+ sama5d36ek_cmp_nandflash +(sama5d36ek_cmp_nandflash) pdata->iobase = dev_remap_addr(dev); +(sama5d36ek_cmp_nandflash) ^ w+(sama5d36ek_cmp_nandflash) drivers/net/macb.c: In function 'macb_eth_ofdata_to_platdata': w+(sama5d36ek_cmp_nandflash) drivers/net/macb.c:1154:16: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
-- Tom
Thanks Tom, I'll look into it.
participants (3)
-
Daniel Schwierzeck -
Ramon Fried -
Tom Rini