[U-Boot] silencing i2c dev?
If I run i2c dev to set the bus it replies what it did:
=> i2c dev 0 Setting bus to 0
Other commands do not seem to do that. e.g. mw does not tell it has written a value.
Should we make i2c dev silent too? (I'm using this in a script and want to avoid superfluous messages). If desired I can submit a patch.
Btw there might also be a parsing issue. I once mistyped the cmd but still it worked:
=> i2c de v0 Setting bus to 0
Haven't had time to dig into this
Frans
Dear Frans Meulenbroeks,
In message AANLkTike41SDknUxKr+AbEbcu6pAXCLnURw4S1GHjWj=@mail.gmail.com you wrote:
If I run i2c dev to set the bus it replies what it did:
=> i2c dev 0 Setting bus to 0
I actually consider thsi somewhat useful, as you are performing a change of the system state, and it is pretty useful to see that it did what you wanted to do.
Btw there might also be a parsing issue. I once mistyped the cmd but still it worked:
=> i2c de v0 Setting bus to 0
Haven't had time to dig into this
That's simple. We use strtoul to convert the argument to a bus number, and "v0" converts as 0.
If you had typed
=> i2c de v1
you would probably have appeciated the "Setting bus to 0" response...
[Ok, more error checking is an option, too ;-) ]
Best regards,
Wolfgang Denk
participants (2)
-
Frans Meulenbroeks -
Wolfgang Denk