[U-Boot] [PATCH] ddrmc: vybrid: We shall perform bitwise AND, not logical one

With logical AND - we exit the memory setup procedure on any interrupt - also on errors.
Signed-off-by: Lukasz Majewski lukma@denx.de
---
arch/arm/mach-imx/ddrmc-vf610.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/ddrmc-vf610.c b/arch/arm/mach-imx/ddrmc-vf610.c index 3d7da1c25e..ea6a49e0fa 100644 --- a/arch/arm/mach-imx/ddrmc-vf610.c +++ b/arch/arm/mach-imx/ddrmc-vf610.c @@ -231,6 +231,6 @@ void ddrmc_ctrl_init_ddr3(struct ddr3_jedec_timings const *timings, /* all inits done, start the DDR controller */ writel(DDRMC_CR00_DRAM_CLASS_DDR3 | DDRMC_CR00_START, &ddrmr->cr[0]);
- while (!(readl(&ddrmr->cr[80]) && 0x100)) + while (!(readl(&ddrmr->cr[80]) & 0x100)) udelay(10); }

On Fri, Nov 30, 2018 at 10:20 AM Lukasz Majewski lukma@denx.de wrote:
With logical AND - we exit the memory setup procedure on any interrupt - also on errors.
Signed-off-by: Lukasz Majewski lukma@denx.de
Reviewed-by: Fabio Estevam festevam@gmail.com

On 30.11.2018 13:21, Fabio Estevam wrote:
On Fri, Nov 30, 2018 at 10:20 AM Lukasz Majewski lukma@denx.de wrote:
With logical AND - we exit the memory setup procedure on any interrupt - also on errors.
Signed-off-by: Lukasz Majewski lukma@denx.de
Reviewed-by: Fabio Estevam festevam@gmail.com
I have a similar patch downstream which also creates a proper define for the magic 0x100.
Will send soon.
-- Stefan
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
participants (3)
-
Fabio Estevam
-
Lukasz Majewski
-
Stefan Agner