[U-Boot] [PATCH] cmd: date: Do not overwrite arguments

Arguments are const and belong to the caller. Calling date in a hush loop will yield different results from the second invocation.
Signed-off-by: Roman Kapl rka@sysgo.com --- cmd/date.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/cmd/date.c b/cmd/date.c index 1115b6c8d6..7fa950a902 100644 --- a/cmd/date.c +++ b/cmd/date.c @@ -159,18 +159,18 @@ int mk_date (const char *datestr, struct rtc_time *tmp) int len, val; char *ptr;
- ptr = strchr (datestr,'.'); - len = strlen (datestr); + ptr = strchr(datestr, '.'); + len = strlen(datestr);
/* Set seconds */ if (ptr) { int sec;
- *ptr++ = '\0'; + ptr++; if ((len - (ptr - datestr)) != 2) return (-1);
- len = strlen (datestr); + len -= 3;
if (cnvrt2 (ptr, &sec)) return (-1);

On Fri, Feb 08, 2019 at 10:01:02AM +0100, Roman Kapl wrote:
Arguments are const and belong to the caller. Calling date in a hush loop will yield different results from the second invocation.
Signed-off-by: Roman Kapl rka@sysgo.com
Applied to u-boot/master, thanks!
participants (2)
-
Roman Kapl
-
Tom Rini