[PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n
This driver uses simple_strtol(), so it needs SPL_STRTO. Before commit 88ca8e26958b6 ("disk: Add an option for partitions in SPL"), SPL_STRTO was always selected indirectly. Now it is not, so select it here.
Signed-off-by: Samuel Holland samuel@sholland.org ---
drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 89068c7800..b955543e97 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -347,6 +347,7 @@ config SANDBOX_GPIO_COUNT config SUNXI_GPIO bool "Allwinner GPIO driver" depends on ARCH_SUNXI + select SPL_STRTO if SPL help Support the GPIO device in Allwinner SoCs.
On Tue, 10 May 2022 19:03:34 -0500 Samuel Holland samuel@sholland.org wrote:
Hi,
This driver uses simple_strtol(), so it needs SPL_STRTO. Before commit 88ca8e26958b6 ("disk: Add an option for partitions in SPL"), SPL_STRTO was always selected indirectly. Now it is not, so select it here.
Signed-off-by: Samuel Holland samuel@sholland.org
From what I can see, CONFIG_MMC is the trigger, calling sunxi_name_to_gpio(), which is the actual user of simple_strtol() in the SPL. For the three boards not using MMC I don't see simple_strol() being mentioned in the objdump. But I think this patch is a more robust solution (compared to tying it to MMC usage), so:
Reviewed-by: Andre Przywara andre.przywara@arm.com
Cheers, Andre
drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 89068c7800..b955543e97 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -347,6 +347,7 @@ config SANDBOX_GPIO_COUNT config SUNXI_GPIO bool "Allwinner GPIO driver" depends on ARCH_SUNXI
- select SPL_STRTO if SPL help Support the GPIO device in Allwinner SoCs.
On Tue, 10 May 2022 19:03:34 -0500 Samuel Holland samuel@sholland.org wrote:
This driver uses simple_strtol(), so it needs SPL_STRTO. Before commit 88ca8e26958b6 ("disk: Add an option for partitions in SPL"), SPL_STRTO was always selected indirectly. Now it is not, so select it here.
Signed-off-by: Samuel Holland samuel@sholland.org
Applied to sunxi/master, for v2022.07.
Thanks, Andre
drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 89068c7800..b955543e97 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -347,6 +347,7 @@ config SANDBOX_GPIO_COUNT config SUNXI_GPIO bool "Allwinner GPIO driver" depends on ARCH_SUNXI
- select SPL_STRTO if SPL help Support the GPIO device in Allwinner SoCs.
participants (2)
-
Andre Przywara -
Samuel Holland