[U-Boot] [PATCH] mx6sxsabreauto: Remove legacy CONFIG_PCA953X
When this board was switched to using more DM drivers we didn't disable the legacy PCA953X driver. This in turn learn to a build time warning about implicit functions as i2c.h would not say anything about 'i2c_read' nor 'i2c_write'. But this was not a fatal error as none of the legacy driver would be linked in either.
Fixes: e389033f72b5 ("imx: mx6sxsabreauto: enable more dm drivers") Signed-off-by: Tom Rini trini@konsulko.com --- include/configs/mx6sxsabreauto.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/configs/mx6sxsabreauto.h b/include/configs/mx6sxsabreauto.h index 0742b4bf2ec9..448b575c2897 100644 --- a/include/configs/mx6sxsabreauto.h +++ b/include/configs/mx6sxsabreauto.h @@ -182,7 +182,4 @@ #define CONFIG_SYS_MMC_ENV_DEV 0 /*USDHC3*/ #endif
-#define CONFIG_PCA953X -#define CONFIG_SYS_I2C_PCA953X_WIDTH { {0x30, 8}, {0x32, 8}, {0x34, 8} } - #endif /* __CONFIG_H */
On 05/04/2017 16:46, Tom Rini wrote:
When this board was switched to using more DM drivers we didn't disable the legacy PCA953X driver. This in turn learn to a build time warning about implicit functions as i2c.h would not say anything about 'i2c_read' nor 'i2c_write'. But this was not a fatal error as none of the legacy driver would be linked in either.
Fixes: e389033f72b5 ("imx: mx6sxsabreauto: enable more dm drivers") Signed-off-by: Tom Rini trini@konsulko.com
include/configs/mx6sxsabreauto.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/configs/mx6sxsabreauto.h b/include/configs/mx6sxsabreauto.h index 0742b4bf2ec9..448b575c2897 100644 --- a/include/configs/mx6sxsabreauto.h +++ b/include/configs/mx6sxsabreauto.h @@ -182,7 +182,4 @@ #define CONFIG_SYS_MMC_ENV_DEV 0 /*USDHC3*/ #endif
-#define CONFIG_PCA953X -#define CONFIG_SYS_I2C_PCA953X_WIDTH { {0x30, 8}, {0x32, 8}, {0x34, 8} }
#endif /* __CONFIG_H */
Reviewed-by: Stefano Babic sbabic@denx.de
Best regards, Stefano Babic
On Wed, Apr 05, 2017 at 05:36:42PM +0200, Stefano Babic wrote:
On 05/04/2017 16:46, Tom Rini wrote:
When this board was switched to using more DM drivers we didn't disable the legacy PCA953X driver. This in turn learn to a build time warning about implicit functions as i2c.h would not say anything about 'i2c_read' nor 'i2c_write'. But this was not a fatal error as none of the legacy driver would be linked in either.
Fixes: e389033f72b5 ("imx: mx6sxsabreauto: enable more dm drivers") Signed-off-by: Tom Rini trini@konsulko.com
include/configs/mx6sxsabreauto.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/configs/mx6sxsabreauto.h b/include/configs/mx6sxsabreauto.h index 0742b4bf2ec9..448b575c2897 100644 --- a/include/configs/mx6sxsabreauto.h +++ b/include/configs/mx6sxsabreauto.h @@ -182,7 +182,4 @@ #define CONFIG_SYS_MMC_ENV_DEV 0 /*USDHC3*/ #endif
-#define CONFIG_PCA953X -#define CONFIG_SYS_I2C_PCA953X_WIDTH { {0x30, 8}, {0x32, 8}, {0x34, 8} }
#endif /* __CONFIG_H */
Reviewed-by: Stefano Babic sbabic@denx.de
Applied to u-boot/master, thanks!
participants (2)
-
Stefano Babic -
Tom Rini