Hi,
Can someone clear me purpose of mii_phy.h? It looks like that it is really ancient file which hasn't been touched from 2003.
It is use for two files [monstr@monstr u-boot]$ grep -rn "mii_phy.h" * board/ep8260/mii_phy.c:2:#include <mii_phy.h> board/rpxsuper/mii_phy.c:2:#include <mii_phy.h>
+ different numbers of arguments against new "version" [monstr@monstr u-boot]$ grep -rn "mii_discover_phy" * arch/m68k/include/asm/fec.h:359:int mii_discover_phy(struct eth_device *dev); arch/powerpc/cpu/mpc8xx/fec.c:63:static int mii_discover_phy(struct eth_device *dev); arch/powerpc/cpu/mpc8xx/fec.c:728: efis->actual_phy_addr = mii_discover_phy (dev); arch/powerpc/cpu/mpc8xx/fec.c:872:static int mii_discover_phy(struct eth_device *dev) arch/powerpc/cpu/mpc85xx/ether_fcc.c:237: mii_discover_phy(); arch/powerpc/cpu/mpc8260/ether_fcc.c:234: mii_discover_phy(); board/ep8260/mii_phy.c:10:mii_discover_phy(void) board/rpxsuper/mii_phy.c:10:mii_discover_phy(void) drivers/net/mcfmii.c:150:int mii_discover_phy(struct eth_device *dev) drivers/net/mcfmii.c:253: info->phy_addr = mii_discover_phy(dev); include/mii_phy.h:4:void mii_discover_phy(void);
+ that functions without arg are not called either arch/powerpc/cpu/mpc85xx/ether_fcc.c:237: mii_discover_phy(); arch/powerpc/cpu/mpc8260/ether_fcc.c:234: mii_discover_phy();
I found that Frank Panno is ep8260 maintainer. Any comment?
The best will be to remove mii_phy entirely. Wolfgang: What do you think?
Thanks, Michal
On Thursday, August 25, 2011 03:25:32 Michal Simek wrote:
Can someone clear me purpose of mii_phy.h? It looks like that it is really ancient file which hasn't been touched from 2003.
It is use for two files [monstr@monstr u-boot]$ grep -rn "mii_phy.h" * board/ep8260/mii_phy.c:2:#include <mii_phy.h> board/rpxsuper/mii_phy.c:2:#include <mii_phy.h>
yes, if you look at old files, you often see people using generic names when they should have been driver or arch specific, or people who thought about starting a framework but then nothing ever materialized.
The best will be to remove mii_phy entirely.
sounds good to me ... i imagine the existing functionality might need to be converted into one of the common net frameworks that has been adopted ? -mike
Mike Frysinger wrote:
On Thursday, August 25, 2011 03:25:32 Michal Simek wrote:
Can someone clear me purpose of mii_phy.h? It looks like that it is really ancient file which hasn't been touched from 2003.
It is use for two files [monstr@monstr u-boot]$ grep -rn "mii_phy.h" * board/ep8260/mii_phy.c:2:#include <mii_phy.h> board/rpxsuper/mii_phy.c:2:#include <mii_phy.h>
yes, if you look at old files, you often see people using generic names when they should have been driver or arch specific, or people who thought about starting a framework but then nothing ever materialized.
The best will be to remove mii_phy entirely.
sounds good to me ... i imagine the existing functionality might need to be converted into one of the common net frameworks that has been adopted ?
Who is responsible for ep8260 and rpxsuper boards?
For ep8260: I cc'ed Frank Panno but his email address doesn't work.
Thanks, Michal
Dear Michal Simek,
In message 4E573AEE.2060406@monstr.eu you wrote:
Who is responsible for ep8260 and rpxsuper boards?
For ep8260: I cc'ed Frank Panno but his email address doesn't work.
I guess it's safe to assume these boards are orphaned / unmaintained.
Shall we remove them?
Best regards,
Wolfgang Denk
participants (3)
-
Michal Simek -
Mike Frysinger -
Wolfgang Denk