[U-Boot] NULL base_name for hwaddr env lookup
in net/eth.c there is this function call with test:
if (eth_write_hwaddr(dev, NULL, eth_number))
If I understand correctly this test will always be true as NULL is used.
I think it should be "eth" instead of NULL.
Am I wrong ?
If not I can submit a patch.
Regards,
Stany
On Mon, Sep 5, 2011 at 3:53 PM, stany MARCEL stany.marcel@novasys-ingenierie.com wrote:
in net/eth.c there is this function call with test:
if (eth_write_hwaddr(dev, NULL, eth_number))
If I understand correctly this test will always be true as NULL is used.
I think it should be "eth" instead of NULL.
Am I wrong ?
If not I can submit a patch.
Regards,
Stany _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Ok it's corrected by a commit few minutes ago.
Hello MARCEL,
stany MARCEL wrote:
in net/eth.c there is this function call with test:
if (eth_write_hwaddr(dev, NULL, eth_number))
If I understand correctly this test will always be true as NULL is used.
I think it should be "eth" instead of NULL.
Am I wrong ?
No.
If not I can submit a patch.
See fix for this issue here:
http://patchwork.ozlabs.org/patch/112361/
bye, Heiko
participants (3)
-
Heiko Schocher -
Stany MARCEL -
stany MARCEL