[U-Boot] [PATCH 1/3] mx7ulp_evk: Disable CONFIG_NET
Currently the following build warning is seen:
===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ===================================================
Since the mx7ulp-evk board does not have networking support, explicitly disable networking.
Signed-off-by: Fabio Estevam festevam@gmail.com --- configs/mx7ulp_evk_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/mx7ulp_evk_defconfig b/configs/mx7ulp_evk_defconfig index ffd217d515..d79c39d621 100644 --- a/configs/mx7ulp_evk_defconfig +++ b/configs/mx7ulp_evk_defconfig @@ -17,6 +17,7 @@ CONFIG_CMD_FAT=y CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="imx7ulp-evk" CONFIG_ENV_IS_IN_MMC=y +# CONFIG_NET is not set CONFIG_DM=y CONFIG_DM_GPIO=y CONFIG_IMX_RGPIO2P=y
As we use the driver model for ESDHC there is no need for defining CONFIG_SYS_FSL_USDHC_NUM and CONFIG_SYS_FSL_ESDHC_ADDR, so simply remove them.
Signed-off-by: Fabio Estevam festevam@gmail.com --- include/configs/mx7ulp_evk.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/configs/mx7ulp_evk.h b/include/configs/mx7ulp_evk.h index 3b02362498..141036310b 100644 --- a/include/configs/mx7ulp_evk.h +++ b/include/configs/mx7ulp_evk.h @@ -18,9 +18,6 @@ #define IRAM_BASE_ADDR OCRAM_0_BASE #define IOMUXC_BASE_ADDR IOMUXC1_RBASE
-#define CONFIG_SYS_FSL_USDHC_NUM 1 - -#define CONFIG_SYS_FSL_ESDHC_ADDR 0 #define CONFIG_SYS_MMC_ENV_DEV 0 /* USDHC1 */ #define CONFIG_SYS_MMC_ENV_PART 0 /* user area */ #define CONFIG_MMCROOT "/dev/mmcblk0p2" /* USDHC1 */
Subject: [PATCH 2/3] mx7ulp_evk: Remove unneeded SDHC definitions
As we use the driver model for ESDHC there is no need for defining CONFIG_SYS_FSL_USDHC_NUM and CONFIG_SYS_FSL_ESDHC_ADDR, so simply remove them.
Signed-off-by: Fabio Estevam festevam@gmail.com
include/configs/mx7ulp_evk.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/configs/mx7ulp_evk.h b/include/configs/mx7ulp_evk.h index 3b02362498..141036310b 100644 --- a/include/configs/mx7ulp_evk.h +++ b/include/configs/mx7ulp_evk.h @@ -18,9 +18,6 @@ #define IRAM_BASE_ADDR OCRAM_0_BASE #define IOMUXC_BASE_ADDR IOMUXC1_RBASE
-#define CONFIG_SYS_FSL_USDHC_NUM 1
-#define CONFIG_SYS_FSL_ESDHC_ADDR 0 #define CONFIG_SYS_MMC_ENV_DEV 0 /* USDHC1 */ #define CONFIG_SYS_MMC_ENV_PART 0 /* user area */ #define CONFIG_MMCROOT "/dev/mmcblk0p2" /* USDHC1 */
Reviewed-by: Peng Fan peng.fan@nxp.com
-- 2.17.1
SoC base addresses should better go into a common SoC file instead of repeating the definition in each board file.
Signed-off-by: Fabio Estevam festevam@gmail.com --- arch/arm/include/asm/arch-mx7ulp/imx-regs.h | 4 ++++ include/configs/mx7ulp_evk.h | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/include/asm/arch-mx7ulp/imx-regs.h b/arch/arm/include/asm/arch-mx7ulp/imx-regs.h index 3c82e9921e..9a420dc30b 100644 --- a/arch/arm/include/asm/arch-mx7ulp/imx-regs.h +++ b/arch/arm/include/asm/arch-mx7ulp/imx-regs.h @@ -946,6 +946,10 @@ #define SNVS_LPCR_DPEN (0x20) #define SNVS_LPCR_SRTC_ENV (0x1)
+#define SRC_BASE_ADDR CMC1_RBASE +#define IRAM_BASE_ADDR OCRAM_0_BASE +#define IOMUXC_BASE_ADDR IOMUXC1_RBASE + #if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__))
#include <asm/types.h> diff --git a/include/configs/mx7ulp_evk.h b/include/configs/mx7ulp_evk.h index 141036310b..6d70fb45ae 100644 --- a/include/configs/mx7ulp_evk.h +++ b/include/configs/mx7ulp_evk.h @@ -14,10 +14,6 @@ #define CONFIG_BOARD_POSTCLK_INIT #define CONFIG_SYS_BOOTM_LEN 0x1000000
-#define SRC_BASE_ADDR CMC1_RBASE -#define IRAM_BASE_ADDR OCRAM_0_BASE -#define IOMUXC_BASE_ADDR IOMUXC1_RBASE - #define CONFIG_SYS_MMC_ENV_DEV 0 /* USDHC1 */ #define CONFIG_SYS_MMC_ENV_PART 0 /* user area */ #define CONFIG_MMCROOT "/dev/mmcblk0p2" /* USDHC1 */
Subject: [PATCH 3/3] mx7ulp: Move SoC base address to a common file
SoC base addresses should better go into a common SoC file instead of repeating the definition in each board file.
Signed-off-by: Fabio Estevam festevam@gmail.com
arch/arm/include/asm/arch-mx7ulp/imx-regs.h | 4 ++++ include/configs/mx7ulp_evk.h | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/include/asm/arch-mx7ulp/imx-regs.h b/arch/arm/include/asm/arch-mx7ulp/imx-regs.h index 3c82e9921e..9a420dc30b 100644 --- a/arch/arm/include/asm/arch-mx7ulp/imx-regs.h +++ b/arch/arm/include/asm/arch-mx7ulp/imx-regs.h @@ -946,6 +946,10 @@ #define SNVS_LPCR_DPEN (0x20) #define SNVS_LPCR_SRTC_ENV (0x1)
+#define SRC_BASE_ADDR CMC1_RBASE +#define IRAM_BASE_ADDR OCRAM_0_BASE +#define IOMUXC_BASE_ADDR IOMUXC1_RBASE
#if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__))
#include <asm/types.h> diff --git a/include/configs/mx7ulp_evk.h b/include/configs/mx7ulp_evk.h index 141036310b..6d70fb45ae 100644 --- a/include/configs/mx7ulp_evk.h +++ b/include/configs/mx7ulp_evk.h @@ -14,10 +14,6 @@ #define CONFIG_BOARD_POSTCLK_INIT #define CONFIG_SYS_BOOTM_LEN 0x1000000
-#define SRC_BASE_ADDR CMC1_RBASE -#define IRAM_BASE_ADDR OCRAM_0_BASE -#define IOMUXC_BASE_ADDR IOMUXC1_RBASE
#define CONFIG_SYS_MMC_ENV_DEV 0 /* USDHC1 */ #define CONFIG_SYS_MMC_ENV_PART 0 /* user area */ #define CONFIG_MMCROOT "/dev/mmcblk0p2" /* USDHC1 */
Reviewed-by: Peng Fan peng.fan@nxp.com
-- 2.17.1
Subject: [PATCH 1/3] mx7ulp_evk: Disable CONFIG_NET
Currently the following build warning is seen:
===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ===================================================
Since the mx7ulp-evk board does not have networking support, explicitly disable networking.
Signed-off-by: Fabio Estevam festevam@gmail.com
configs/mx7ulp_evk_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/mx7ulp_evk_defconfig b/configs/mx7ulp_evk_defconfig index ffd217d515..d79c39d621 100644 --- a/configs/mx7ulp_evk_defconfig +++ b/configs/mx7ulp_evk_defconfig @@ -17,6 +17,7 @@ CONFIG_CMD_FAT=y CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="imx7ulp-evk" CONFIG_ENV_IS_IN_MMC=y +# CONFIG_NET is not set CONFIG_DM=y CONFIG_DM_GPIO=y CONFIG_IMX_RGPIO2P=y
Reviewed-by: Peng Fan peng.fan@nxp.com
-- 2.17.1
Hi Stefano,
On Wed, Oct 23, 2019 at 11:08 AM Fabio Estevam festevam@gmail.com wrote:
Currently the following build warning is seen:
===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ===================================================
Since the mx7ulp-evk board does not have networking support, explicitly disable networking.
Signed-off-by: Fabio Estevam festevam@gmail.com
It seems that this series has been forgotten. Would you like me to resend it?
Hi Fabio,
On 15/01/20 16:46, Fabio Estevam wrote:
Hi Stefano,
On Wed, Oct 23, 2019 at 11:08 AM Fabio Estevam festevam@gmail.com wrote:
Currently the following build warning is seen:
===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ===================================================
Since the mx7ulp-evk board does not have networking support, explicitly disable networking.
Signed-off-by: Fabio Estevam festevam@gmail.com
It seems that this series has been forgotten.
..I will say lost...
Would you like me to resend it?
I found the series in patchwork, I rebased 1/3 and applied the whole series to -next branch. It flows into -master at my next PR.
Thanks for pointing to this, Stefano
participants (3)
-
Fabio Estevam -
Peng Fan -
Stefano Babic