[U-Boot] [PATCH 0/2] Fixes and simplification to omap3_pandora boot configuration

First patch fixes the syntax used for loading a boot script from mmc.
The second patch makes use of the "load" command provided by CONFIG_CMD_FS_GENERIC.
Vagrant Cascadian (2): omap3_pandora: Fix mmc loading of autoboot script to use correct syntax. omap3_pandora: Switch to using "load" command to load the autoboot script.
include/configs/omap3_pandora.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

fatload/ext2load both require that the device and partition be specified after specifying the device type. Specify the first partition on mmc device 0, which is the only mmc device currently configured on the pandora.
Signed-off-by: Vagrant Cascadian vagrant@debian.org ---
include/configs/omap3_pandora.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/omap3_pandora.h b/include/configs/omap3_pandora.h index 380ec12..6ff9375 100644 --- a/include/configs/omap3_pandora.h +++ b/include/configs/omap3_pandora.h @@ -93,8 +93,8 @@ "mtdparts=" MTDPARTS_DEFAULT "\0" \
#define CONFIG_BOOTCOMMAND \ - "if mmc rescan && fatload mmc1 0 ${loadaddr} autoboot.scr || " \ - "ext2load mmc1 0 ${loadaddr} autoboot.scr; then " \ + "if mmc rescan && fatload mmc 0:1 ${loadaddr} autoboot.scr || " \ + "ext2load mmc 0:1 ${loadaddr} autoboot.scr; then " \ "source ${loadaddr}; " \ "fi; " \ "ubi part boot && ubifsmount ubi:boot && " \

On Mon, Aug 29, 2016 at 10:56 AM, Vagrant Cascadian vagrant@debian.org wrote:
fatload/ext2load both require that the device and partition be specified after specifying the device type. Specify the first partition on mmc device 0, which is the only mmc device currently configured on the pandora.
Signed-off-by: Vagrant Cascadian vagrant@debian.org
Acked-by: Grazvydas Ignotas notasas@gmail.com
include/configs/omap3_pandora.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/omap3_pandora.h b/include/configs/omap3_pandora.h index 380ec12..6ff9375 100644 --- a/include/configs/omap3_pandora.h +++ b/include/configs/omap3_pandora.h @@ -93,8 +93,8 @@ "mtdparts=" MTDPARTS_DEFAULT "\0" \
#define CONFIG_BOOTCOMMAND \
"if mmc rescan && fatload mmc1 0 ${loadaddr} autoboot.scr || " \
"ext2load mmc1 0 ${loadaddr} autoboot.scr; then " \
"if mmc rescan && fatload mmc 0:1 ${loadaddr} autoboot.scr || " \
"ext2load mmc 0:1 ${loadaddr} autoboot.scr; then " \ "source ${loadaddr}; " \ "fi; " \ "ubi part boot && ubifsmount ubi:boot && " \
-- 2.9.3

On Mon, Aug 29, 2016 at 12:56:05AM -0700, Vagrant Cascadian wrote:
fatload/ext2load both require that the device and partition be specified after specifying the device type. Specify the first partition on mmc device 0, which is the only mmc device currently configured on the pandora.
Signed-off-by: Vagrant Cascadian vagrant@debian.org Acked-by: Grazvydas Ignotas notasas@gmail.com
Applied to u-boot/master, thanks!

CONFIG_CMD_FS_GENERIC is enabled; use it to load the autoboot script, rather than first attempting with fatload and falling back to ext2load.
Signed-off-by: Vagrant Cascadian vagrant@debian.org ---
include/configs/omap3_pandora.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/configs/omap3_pandora.h b/include/configs/omap3_pandora.h index 6ff9375..0d733bd 100644 --- a/include/configs/omap3_pandora.h +++ b/include/configs/omap3_pandora.h @@ -93,8 +93,7 @@ "mtdparts=" MTDPARTS_DEFAULT "\0" \
#define CONFIG_BOOTCOMMAND \ - "if mmc rescan && fatload mmc 0:1 ${loadaddr} autoboot.scr || " \ - "ext2load mmc 0:1 ${loadaddr} autoboot.scr; then " \ + "if mmc rescan && load mmc 0:1 ${loadaddr} autoboot.scr; then " \ "source ${loadaddr}; " \ "fi; " \ "ubi part boot && ubifsmount ubi:boot && " \

On Mon, Aug 29, 2016 at 10:56 AM, Vagrant Cascadian vagrant@debian.org wrote:
CONFIG_CMD_FS_GENERIC is enabled; use it to load the autoboot script, rather than first attempting with fatload and falling back to ext2load.
Signed-off-by: Vagrant Cascadian vagrant@debian.org
Acked-by: Grazvydas Ignotas notasas@gmail.com
include/configs/omap3_pandora.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/configs/omap3_pandora.h b/include/configs/omap3_pandora.h index 6ff9375..0d733bd 100644 --- a/include/configs/omap3_pandora.h +++ b/include/configs/omap3_pandora.h @@ -93,8 +93,7 @@ "mtdparts=" MTDPARTS_DEFAULT "\0" \
#define CONFIG_BOOTCOMMAND \
"if mmc rescan && fatload mmc 0:1 ${loadaddr} autoboot.scr || " \
"ext2load mmc 0:1 ${loadaddr} autoboot.scr; then " \
"if mmc rescan && load mmc 0:1 ${loadaddr} autoboot.scr; then " \ "source ${loadaddr}; " \ "fi; " \ "ubi part boot && ubifsmount ubi:boot && " \
-- 2.9.3

On Mon, Aug 29, 2016 at 12:56:06AM -0700, Vagrant Cascadian wrote:
CONFIG_CMD_FS_GENERIC is enabled; use it to load the autoboot script, rather than first attempting with fatload and falling back to ext2load.
Signed-off-by: Vagrant Cascadian vagrant@debian.org Acked-by: Grazvydas Ignotas notasas@gmail.com
Applied to u-boot/master, thanks!
participants (3)
-
Grazvydas Ignotas
-
Tom Rini
-
Vagrant Cascadian