[U-Boot] [PATCH] sf: Remove #ifdef #endif in Makefile

The #ifdef #endif in drivers/mtd/spi/Makefile actually does nothing but causes confusion. Remove it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
drivers/mtd/spi/Makefile | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index cf4e7e1..6ca1b72 100644 --- a/drivers/mtd/spi/Makefile +++ b/drivers/mtd/spi/Makefile @@ -12,9 +12,7 @@ obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o obj-$(CONFIG_SPL_SPI_BOOT) += fsl_espi_spl.o endif
-#ifndef CONFIG_DM_SPI obj-$(CONFIG_SPI_FLASH) += sf_probe.o -#endif obj-$(CONFIG_CMD_SF) += sf.o obj-$(CONFIG_SPI_FLASH) += sf_ops.o sf_params.o obj-$(CONFIG_SPI_FLASH_DATAFLASH) += sf_dataflash.o

Hi Bin,
On 1 December 2015 at 15:37, Bin Meng bmeng.cn@gmail.com wrote:
The #ifdef #endif in drivers/mtd/spi/Makefile actually does nothing but causes confusion. Remove it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
drivers/mtd/spi/Makefile | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index cf4e7e1..6ca1b72 100644 --- a/drivers/mtd/spi/Makefile +++ b/drivers/mtd/spi/Makefile @@ -12,9 +12,7 @@ obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o obj-$(CONFIG_SPL_SPI_BOOT) += fsl_espi_spl.o endif
-#ifndef CONFIG_DM_SPI obj-$(CONFIG_SPI_FLASH) += sf_probe.o -#endif obj-$(CONFIG_CMD_SF) += sf.o obj-$(CONFIG_SPI_FLASH) += sf_ops.o sf_params.o obj-$(CONFIG_SPI_FLASH_DATAFLASH) += sf_dataflash.o
Sent similar change on this [1] patch
[1] https://patchwork.ozlabs.org/patch/549041/
thanks!

Hi Jagan,
On Thu, Dec 3, 2015 at 6:17 PM, Jagan Teki jteki@openedev.com wrote:
Hi Bin,
On 1 December 2015 at 15:37, Bin Meng bmeng.cn@gmail.com wrote:
The #ifdef #endif in drivers/mtd/spi/Makefile actually does nothing but causes confusion. Remove it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
drivers/mtd/spi/Makefile | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index cf4e7e1..6ca1b72 100644 --- a/drivers/mtd/spi/Makefile +++ b/drivers/mtd/spi/Makefile @@ -12,9 +12,7 @@ obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o obj-$(CONFIG_SPL_SPI_BOOT) += fsl_espi_spl.o endif
-#ifndef CONFIG_DM_SPI obj-$(CONFIG_SPI_FLASH) += sf_probe.o -#endif obj-$(CONFIG_CMD_SF) += sf.o obj-$(CONFIG_SPI_FLASH) += sf_ops.o sf_params.o obj-$(CONFIG_SPI_FLASH_DATAFLASH) += sf_dataflash.o
Sent similar change on this [1] patch
Ah, yes! Thanks.
thanks!
Regards, Bin
participants (2)
-
Bin Meng
-
Jagan Teki