[U-Boot] [PATCH] Create configuration option for restricted ns16550 functions
This patch will create a configuration option for a minimum configuration for the ns16550 serial driver at drivers/serial/ns16550.c which will exclude all functions with exception of NS16550_putc and NS16550_init. This will be used primarily to save space and remove unused code from builds in which space is limited.
Signed-off-by: Ron Madrid ron_madrid@sbcglobal.net --- drivers/serial/ns16550.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 93c2243..3e2a3c2 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -39,6 +39,7 @@ void NS16550_init (NS16550_t com_port, int baud_divisor) #endif }
+#ifndef CONFIG_NS16550_MIN_FUNCTIONS void NS16550_reinit (NS16550_t com_port, int baud_divisor) { com_port->ier = 0x00; @@ -53,6 +54,7 @@ void NS16550_reinit (NS16550_t com_port, int baud_divisor) com_port->dlm = (baud_divisor >> 8) & 0xff; com_port->lcr = LCRVAL; } +#endif /* CONFIG_NS16550_MIN_FUNCTIONS */
void NS16550_putc (NS16550_t com_port, char c) { @@ -60,6 +62,7 @@ void NS16550_putc (NS16550_t com_port, char c) com_port->thr = c; }
+#ifndef CONFIG_NS16550_MIN_FUNCTIONS char NS16550_getc (NS16550_t com_port) { while ((com_port->lsr & LSR_DR) == 0) { @@ -75,5 +78,5 @@ int NS16550_tstc (NS16550_t com_port) { return ((com_port->lsr & LSR_DR) != 0); } - +#endif /* CONFIG_NS16550_MIN_FUNCTIONS */ #endif
--- On Fri, 1/30/09, Ron Madrid ron_madrid@sbcglobal.net wrote:
From: Ron Madrid ron_madrid@sbcglobal.net Subject: [PATCH] Create configuration option for restricted ns16550 functions To: u-boot@lists.denx.de Cc: "Ron Madrid" ron_madrid@sbcglobal.net Date: Friday, January 30, 2009, 3:45 PM This patch will create a configuration option for a minimum configuration for the ns16550 serial driver at drivers/serial/ns16550.c which will exclude all functions with exception of NS16550_putc and NS16550_init. This will be used primarily to save space and remove unused code from builds in which space is limited.
Signed-off-by: Ron Madrid ron_madrid@sbcglobal.net
drivers/serial/ns16550.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 93c2243..3e2a3c2 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -39,6 +39,7 @@ void NS16550_init (NS16550_t com_port, int baud_divisor) #endif }
+#ifndef CONFIG_NS16550_MIN_FUNCTIONS void NS16550_reinit (NS16550_t com_port, int baud_divisor) { com_port->ier = 0x00; @@ -53,6 +54,7 @@ void NS16550_reinit (NS16550_t com_port, int baud_divisor) com_port->dlm = (baud_divisor >> 8) & 0xff; com_port->lcr = LCRVAL; } +#endif /* CONFIG_NS16550_MIN_FUNCTIONS */
void NS16550_putc (NS16550_t com_port, char c) { @@ -60,6 +62,7 @@ void NS16550_putc (NS16550_t com_port, char c) com_port->thr = c; }
+#ifndef CONFIG_NS16550_MIN_FUNCTIONS char NS16550_getc (NS16550_t com_port) { while ((com_port->lsr & LSR_DR) == 0) { @@ -75,5 +78,5 @@ int NS16550_tstc (NS16550_t com_port) { return ((com_port->lsr & LSR_DR) != 0); }
+#endif /* CONFIG_NS16550_MIN_FUNCTIONS */
#endif
1.5.5.1
Did this get looked at? I don't remember seeing anything about it. If it is still being looked at, just let me know.
Thanks,
Ron
Dear Ron Madrid,
In message 1233359127-7339-1-git-send-email-ron_madrid@sbcglobal.net you wrote:
This patch will create a configuration option for a minimum configuration for the ns16550 serial driver at drivers/serial/ns16550.c which will exclude all functions with exception of NS16550_putc and NS16550_init. This will be used primarily to save space and remove unused code from builds in which space is limited.
Signed-off-by: Ron Madrid ron_madrid@sbcglobal.net
drivers/serial/ns16550.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
This also has to be documented in the README.
Best regards,
Wolfgang Denk
--- On Wed, 2/11/09, Wolfgang Denk wd@denx.de wrote:
In message 1233359127-7339-1-git-send-email-ron_madrid@sbcglobal.net you wrote:
This patch will create a configuration option for a
minimum configuration for
the ns16550 serial driver at drivers/serial/ns16550.c
which will exclude all
functions with exception of NS16550_putc and
NS16550_init. This will be used
primarily to save space and remove unused code from
builds in which space is
limited.
Signed-off-by: Ron Madrid
drivers/serial/ns16550.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
This also has to be documented in the README.
My apologies for missing that. I just now read the note in the README regarding the creation of new configuration options.
I have been searching for an appropriate location to place the description of the new configuration option within the README file but have been unable to settle on one. Should it go under the section titled "Configuration Settings:" This seems like the best place for it although most of the options listed in this section are of the CONFIG_SYS_ flavor.
Please let me know what you think or if there is a more appropriate place.
Ron
participants (2)
-
Ron Madrid -
Wolfgang Denk