[U-Boot] [PATCH v2 0/5] Enhance fs tests
The first 3 patches do some cleanups for the current test, especially TC11 had some issues (strange match for expected output, use of unitialized variable).
The last two patches add test cases for handling ".". Ext4 used to crash, as a match on the first entry of a directory block was not handled correctly.
v2: Updated: test/fs: Restructure file path specification to allow some flexibility * avoid creation of paths with double slashes test/fs: Check writes using "." (same dir) relative path * fix issues copied from TC11 * delete written file in cleanup Added: test/fs: remove use of undefined WRITE_FILE variable test/fs: strip noise from filesystem code prior to checking results
Stefan Brüns (5): test/fs: Restructure file path specification to allow some flexibility test/fs: remove use of undefined WRITE_FILE variable test/fs: strip noise from filesystem code prior to checking results test/fs: Check ext4 behaviour if dirent is first entry in directory block test/fs: Check writes using "." (same dir) relative path
test/fs/fs-test.sh | 131 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 78 insertions(+), 53 deletions(-)
Hi Stefan,
On 13 September 2016 at 17:01, Stefan Brüns stefan.bruens@rwth-aachen.de wrote:
The first 3 patches do some cleanups for the current test, especially TC11 had some issues (strange match for expected output, use of unitialized variable).
The last two patches add test cases for handling ".". Ext4 used to crash, as a match on the first entry of a directory block was not handled correctly.
I think we should move these to pytest before enhancing them.
v2: Updated: test/fs: Restructure file path specification to allow some flexibility * avoid creation of paths with double slashes test/fs: Check writes using "." (same dir) relative path * fix issues copied from TC11 * delete written file in cleanup Added: test/fs: remove use of undefined WRITE_FILE variable test/fs: strip noise from filesystem code prior to checking results
Stefan Brüns (5): test/fs: Restructure file path specification to allow some flexibility test/fs: remove use of undefined WRITE_FILE variable test/fs: strip noise from filesystem code prior to checking results test/fs: Check ext4 behaviour if dirent is first entry in directory block test/fs: Check writes using "." (same dir) relative path
test/fs/fs-test.sh | 131 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 78 insertions(+), 53 deletions(-)
-- 2.10.0
Regards, Simon
On Wed, Sep 14, 2016 at 07:32:47AM -0600, Simon Glass wrote:
Hi Stefan,
On 13 September 2016 at 17:01, Stefan Brüns stefan.bruens@rwth-aachen.de wrote:
The first 3 patches do some cleanups for the current test, especially TC11 had some issues (strange match for expected output, use of unitialized variable).
The last two patches add test cases for handling ".". Ext4 used to crash, as a match on the first entry of a directory block was not handled correctly.
I think we should move these to pytest before enhancing them.
For the moment, I disagree. We have fs issues, and we're fixing fs issues and getting tests while we're doing that is important. It would be good, and would make my (and everyone else that has one too) setup easier if these were migrated but I don't want to blocks more tests on having them be made into different but equivalent tests first.
Hi Tom,
On 14 September 2016 at 07:38, Tom Rini trini@konsulko.com wrote:
On Wed, Sep 14, 2016 at 07:32:47AM -0600, Simon Glass wrote:
Hi Stefan,
On 13 September 2016 at 17:01, Stefan Brüns stefan.bruens@rwth-aachen.de wrote:
The first 3 patches do some cleanups for the current test, especially TC11 had some issues (strange match for expected output, use of unitialized variable).
The last two patches add test cases for handling ".". Ext4 used to crash, as a match on the first entry of a directory block was not handled correctly.
I think we should move these to pytest before enhancing them.
For the moment, I disagree. We have fs issues, and we're fixing fs issues and getting tests while we're doing that is important. It would be good, and would make my (and everyone else that has one too) setup easier if these were migrated but I don't want to blocks more tests on having them be made into different but equivalent tests first.
Fair enough, I've seen the issues and these are not large additions.
Regards, Simon
participants (3)
-
Simon Glass -
Stefan Brüns -
Tom Rini