[U-Boot] [PATCH v10 0/14] Add some missing buildman features and deprecate MAKEALL
Buildman has been around for a little over a year and is used by a fair number of U-Boot developers. However quite a few people still use MAKEALL.
Buildman was intended to replace MAKEALL, so perhaps now is a good time to start that process.
The reasons to deprecate MAKEALL are: - We don't want to maintain two build systems - Buildman is typically faster - Buildman has a lot more features
This series adds a few features to buildman to fill some gaps, adds some information into the README on how to migrate from MAKEALL, and adds a deprecation message to MAKEALL.
Changes in v10: - Remove the directory prefix more aggressively - Track prefixes and postfixes for warnings/errors
Changes in v9: - Add new patch to avoid changing the order of tags - Add new patch to set the return code to indicate build result - Add new patch to allow make-flags variables to include '-' and '_' - Add new patch to implement --exclude option - Add new patch to remove the directory prefix from each error line - Add new patch to support showing which boards caused which errors - Add new patch to separate out display of warnings and errors - Add new patch to fix detection of git version
Changes in v8: - Add new patch to disable the pager in git
Changes in v7: - Add new patch to fix the 'reverse' bug - Remove already-applied patches from the series - Add the deprecation message at the end of the build also - Drop the 'colour' patch sadly
Changes in v6: - Add new patch to fix indentation in teminal.py - Add new patch to fix patman unit tests - Add new patch to remove patman's -a option
Changes in v5: - Drop patch to search for *cc instead of *gcc for the compiler
Simon Glass (14): patman: Support the 'reverse' option for 'git log' patman: Fix indentation in terminal.py patman: Correct unit tests to run correctly patman: Remove the -a option patman: Use --no-pager' to stop git from forking a pager patman: Avoid changing the order of tags buildman: Set the return code to indicate build result buildman: Allow make-flags variables to include '-' and '_' buildman: Implement an option to exclude boards from the build buildman: Remove the directory prefix from each error line buildman: Add an option to show which boards caused which errors buildman: Separate out display of warnings and errors patman: Fix detection of git version RFC: Deprecate MAKEALL
MAKEALL | 10 +++ tools/buildman/README | 27 ++++++-- tools/buildman/board.py | 31 +++++++-- tools/buildman/builder.py | 139 ++++++++++++++++++++++++++++++++++------ tools/buildman/builderthread.py | 4 +- tools/buildman/buildman.py | 8 ++- tools/buildman/control.py | 20 ++++-- tools/buildman/toolchain.py | 2 +- tools/patman/gitutil.py | 102 +++-------------------------- tools/patman/patchstream.py | 21 ++---- tools/patman/patman.py | 7 -- tools/patman/terminal.py | 112 +++++++++++++++++--------------- tools/patman/test.py | 13 ++-- 13 files changed, 286 insertions(+), 210 deletions(-)
This option is currently not supported, but needs to be, for buildman to operate as expected.
Reported-by: York Sun yorksun@freescale.com Signed-off-by: Simon Glass sjg@chromium.org ---
Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: - Add new patch to fix the 'reverse' bug
Changes in v6: None Changes in v5: None
tools/patman/gitutil.py | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/patman/gitutil.py b/tools/patman/gitutil.py index 735c8dd..e2b4959 100644 --- a/tools/patman/gitutil.py +++ b/tools/patman/gitutil.py @@ -38,6 +38,8 @@ def LogCmd(commit_range, git_dir=None, oneline=False, reverse=False, cmd.append('--oneline') if use_no_decorate: cmd.append('--no-decorate') + if reverse: + cmd.append('--reverse') if count is not None: cmd.append('-n%d' % count) if commit_range:
On 28 August 2014 09:21, Simon Glass sjg@chromium.org wrote:
This option is currently not supported, but needs to be, for buildman to operate as expected.
Reported-by: York Sun yorksun@freescale.com Signed-off-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86/patman.
Hi Simon,
2014-09-06 4:34 GMT+09:00 Simon Glass sjg@chromium.org:
On 28 August 2014 09:21, Simon Glass sjg@chromium.org wrote:
This option is currently not supported, but needs to be, for buildman to operate as expected.
Reported-by: York Sun yorksun@freescale.com Signed-off-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86/patman.
Really?
This patch is already on u-boot/master.
commit 042a732cf50568e77a20c540341fccf28ba62bcf Author: Simon Glass sjg@chromium.org AuthorDate: Thu Aug 14 21:59:11 2014 -0600 Commit: Simon Glass sjg@chromium.org CommitDate: Thu Aug 28 07:56:19 2014 -0700
patman: Support the 'reverse' option for 'git log'
This option is currently not supported, but needs to be, for buildman to operate as expected.
Reported-by: York Sun yorksun@freescale.com Signed-off-by: Simon Glass sjg@chromium.org
If you really succeeded in applying it, it means u-boot-x86 is out of sync with u-boot/master.
I recommend to have your repo fast-forwarded against Tom's one, and then appy patches onto it so as not to double commits.
Hi Simon,
2014-09-06 4:34 GMT+09:00 Simon Glass sjg@chromium.org:
On 28 August 2014 09:21, Simon Glass sjg@chromium.org wrote:
This option is currently not supported, but needs to be, for buildman to operate as expected.
Reported-by: York Sun yorksun@freescale.com Signed-off-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86/patman.
This one. You had already sent a pull-req to Tom.
http://lists.denx.de/pipermail/u-boot/2014-August/187433.html
Hi Masahiro,
On 6 September 2014 09:11, Masahiro YAMADA yamada.m@jp.panasonic.com wrote:
Hi Simon,
2014-09-06 4:34 GMT+09:00 Simon Glass sjg@chromium.org:
On 28 August 2014 09:21, Simon Glass sjg@chromium.org wrote:
This option is currently not supported, but needs to be, for buildman to operate as expected.
Reported-by: York Sun yorksun@freescale.com Signed-off-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86/patman.
This one. You had already sent a pull-req to Tom.
http://lists.denx.de/pipermail/u-boot/2014-August/187433.html
For patches that don't come through a master tree, I don't reply to the mailing list with 'applied' until they are actually applied to mainline. Otherwise I worry that people will wonder what on earth it is applied to. Also, it is possible that these non-master trees will not actually be pulled by Tom.
In this case I realised that I hadn't replied, so did so (much after the fact).
I'm happy to change my process if there is a better one.
Regards, Simon
participants (2)
-
Masahiro YAMADA -
Simon Glass