[U-Boot-Users] [PATCH] ppc flush_cache: add watch-dog triggering into the loops.
From: Yuri Tikhonov yur@emcraft.com
Some boards (e.g. lwmon5) need rather a frequent watch-dog kicking. Since the time it takes for the flush_cache() function to complete its job depends on the size of data being flushed, one may encounter watch-dog resets on such boards when, for example, download big files over ethernet.
Signed-off-by: Yuri Tikhonov yur@emcraft.com --- lib_ppc/cache.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/lib_ppc/cache.c b/lib_ppc/cache.c index 27e1a82..5bfb220 100644 --- a/lib_ppc/cache.c +++ b/lib_ppc/cache.c @@ -23,6 +23,7 @@
#include <common.h> #include <asm/cache.h> +#include <watchdog.h>
void flush_cache (ulong start_addr, ulong size) { @@ -35,6 +36,7 @@ void flush_cache (ulong start_addr, ulong size) addr < end_addr; addr += CFG_CACHELINE_SIZE) { asm ("dcbst 0,%0": :"r" (addr)); + WATCHDOG_RESET(); } asm ("sync"); /* Wait for all dcbst to complete on bus */
@@ -42,6 +44,7 @@ void flush_cache (ulong start_addr, ulong size) addr < end_addr; addr += CFG_CACHELINE_SIZE) { asm ("icbi 0,%0": :"r" (addr)); + WATCHDOG_RESET(); } } asm ("sync"); /* Always flush prefetch queue in any case */
On Apr 29, 2008, at 7:50 AM, Wolfgang Denk wrote:
From: Yuri Tikhonov yur@emcraft.com
Some boards (e.g. lwmon5) need rather a frequent watch-dog kicking. Since the time it takes for the flush_cache() function to complete its job depends on the size of data being flushed, one may encounter watch-dog resets on such boards when, for example, download big files over ethernet.
is this because the size argument being passed to flush_cache is well beyond the size of the cache itself?
- k
Dear Kumar,
in message DD1539F4-3992-4D8E-92D1-8C53826FDB06@kernel.crashing.org you wrote:
Some boards (e.g. lwmon5) need rather a frequent watch-dog kicking. Since the time it takes for the flush_cache() function to complete its job depends on the size of data being flushed, one may encounter watch-dog resets on such boards when, for example, download big files over ethernet.
is this because the size argument being passed to flush_cache is well beyond the size of the cache itself?
Yes - the thing is that after a TFTP download flush_cache() is called for the size of the downloaded filr; this may be 8 or 32 MiB or more ;-)
Best regards,
Wolfgang Denk
On Apr 29, 2008, at 8:47 AM, Wolfgang Denk wrote:
Dear Kumar,
in message DD1539F4-3992-4D8E-92D1-8C53826FDB06@kernel.crashing.org you wrote:
Some boards (e.g. lwmon5) need rather a frequent watch-dog kicking. Since the time it takes for the flush_cache() function to complete its job depends on the size of data being flushed, one may encounter watch-dog resets on such boards when, for example, download big files over ethernet.
is this because the size argument being passed to flush_cache is well beyond the size of the cache itself?
Yes - the thing is that after a TFTP download flush_cache() is called for the size of the downloaded filr; this may be 8 or 32 MiB or more ;-)
Seems like we should have a max flush size that is know to flush the whole cache.
Something like:
void flush_cache (ulong start_addr, ulong size) { #ifndef CONFIG_5xx ulong addr, end_addr; size = MIN(MAX_CACHE_SIZE_TO_FLUSH, size); end_addr = start_addr + size; ...
oh well.
- k
participants (2)
-
Kumar Gala -
Wolfgang Denk