[U-Boot] tools/env/fw_env.h comment/code mismatch
tools/env/fw_env.h states:
/* * To build the utility with the run-time configuration * uncomment the next line. * See included "fw_env.config" sample file * for notes on configuration. */ #define CONFIG_FILE "/etc/fw_env.config"
However the define is already uncommented. I see two possible fixes:
1: add a // before the #define to make the code in accordance with the comment
2: reprase the comment so it is in accordance with the code
Whatever is preferred?
Frans
Dear Frans Meulenbroeks,
In message CACW_hTaiy-1qKik1H5f3yOR31fJ62eV2bAN-q7nx+BpyfrFMFQ@mail.gmail.com you wrote:
I see two possible fixes:
1: add a // before the #define to make the code in accordance with the comment
That would trigger a checkpatch error (no C++ commnts) ;-)
2: reprase the comment so it is in accordance with the code
Whatever is preferred?
It appears that the use of "/etc/fw_env.config" has become pretty much standard, so we should probably change the comment to reflect current use. Thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Frans Meulenbroeks -
Wolfgang Denk