[U-Boot] FW: [PATCH 1/2] drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able to work in a cached environment (I$D$ support).
[[ ... to get attention again ... see below ...]] On 2/8/2013 6:22 PM, Frank Dols wrote:
Good afternoon Vipin and Albert, I where wondering, is there any review/update news on the patches I submitted a short while ago? Regards, Frank. Sorry, first excluded " u-boot@lists.denx.de" from this email to prevent from noice on mailing list.
There is no reason to remove the list. This is not noise I believe. Infact by including the list, you are intimating other developers that such work would be available soon
Albert, do you think any different.
Sorry, I have to clarify here a bit more. The descriptors are 16 bytes in length and a cache line is in most architectures more than 16 bytes in length (in our case either 32 or 64). This means that cached accesses is not an option for these descriptors. Background, two adjacent descriptors as be on one cache line may be owned by different entities (host cpu / network ip).
Yes, this is a problem and I can't think of a clean solution. Specially because u-boot (as of today) does not support non-cached memory
Albert?
Explicit cache calls that we are added in patch 2/2 are meant for payload of the package. And these are made cache line aligned with patch 1/2.
Yes, that is what I thought
Unfortunately we can't align the descriptors on cache line boundaries due to hardware limitations (for architectures with cache line longer than 16 bytes) !
Yes, I know that. The descriptors are 16 bytes and they need to be contiguous in memory
PS: I have not added the list but I strongly feel that this mail should also go to the uboot list
-Vipin
With kind regards, greetings, Frank.
Hi Frank,
On Fri, Mar 1, 2013 at 4:05 AM, Frank Dols Frank.Dols@synopsys.com wrote:
[[ ... to get attention again ... see below ...]] On 2/8/2013 6:22 PM, Frank Dols wrote:
Good afternoon Vipin and Albert, I where wondering, is there any review/update news on the patches I submitted a short while ago? Regards, Frank. Sorry, first excluded " u-boot@lists.denx.de" from this email to prevent from noice on mailing list.
There is no reason to remove the list. This is not noise I believe. Infact by including the list, you are intimating other developers that such work would be available soon
Albert, do you think any different.
Yes, this is appropriate for the list.
Sorry, I have to clarify here a bit more. The descriptors are 16 bytes in length and a cache line is in most architectures more than 16 bytes in length (in our case either 32 or 64). This means that cached accesses is not an option for these descriptors. Background, two adjacent descriptors as be on one cache line may be owned by different entities (host cpu / network ip).
Yes, this is a problem and I can't think of a clean solution. Specially because u-boot (as of today) does not support non-cached memory
Albert?
Explicit cache calls that we are added in patch 2/2 are meant for payload of the package. And these are made cache line aligned with patch 1/2.
Yes, that is what I thought
Unfortunately we can't align the descriptors on cache line boundaries due to hardware limitations (for architectures with cache line longer than 16 bytes) !
Yes, I know that. The descriptors are 16 bytes and they need to be contiguous in memory
PS: I have not added the list but I strongly feel that this mail should also go to the uboot list
-Vipin
With kind regards, greetings, Frank.
I attempted to apply these 2 patches (and fix your improper commit message... please see http://www.denx.de/wiki/U-Boot/Patches ), but your change causes build errors and warnings even then.
Please address these issues and resubmit.
Thanks, -Joe
Configuring for spear300 - Board: spear3xx_evb, Options: spear300 arm-none-linux-gnueabi-size: '/tmp/u-boot-build//x600/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/x600/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/x600/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear300_nand - Board: spear3xx_evb, Options: spear300,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear300/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear300/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear300/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear300_usbtty - Board: spear3xx_evb, Options: spear300,usbtty arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear300_nand/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear300_nand/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear300_nand/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear300_usbtty_nand - Board: spear3xx_evb, Options: spear300,usbtty,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear300_usbtty/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear300_usbtty/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear300_usbtty/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear310 - Board: spear3xx_evb, Options: spear310 arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear300_usbtty_nand/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear300_usbtty_nand/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear300_usbtty_nand/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear310_nand - Board: spear3xx_evb, Options: spear310,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear310/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear310/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear310/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear310_pnor - Board: spear3xx_evb, Options: spear310,FLASH_PNOR arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear310_nand/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear310_nand/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear310_nand/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear310_usbtty - Board: spear3xx_evb, Options: spear310,usbtty arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear310_pnor/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear310_pnor/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear310_pnor/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear310_usbtty_nand - Board: spear3xx_evb, Options: spear310,usbtty,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear310_usbtty/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear310_usbtty/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear310_usbtty/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear310_usbtty_pnor - Board: spear3xx_evb, Options: spear310,usbtty,FLASH_PNOR arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear310_usbtty_nand/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear310_usbtty_nand/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear310_usbtty_nand/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear320 - Board: spear3xx_evb, Options: spear320 arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear310_usbtty_pnor/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear310_usbtty_pnor/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear310_usbtty_pnor/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear320_nand - Board: spear3xx_evb, Options: spear320,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear320/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear320/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear320/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear320_pnor - Board: spear3xx_evb, Options: spear320,FLASH_PNOR arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear320_nand/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear320_nand/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear320_nand/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear320_usbtty - Board: spear3xx_evb, Options: spear320,usbtty arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear320_pnor/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear320_pnor/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear320_pnor/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear320_usbtty_nand - Board: spear3xx_evb, Options: spear320,usbtty,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear320_usbtty/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear320_usbtty/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear320_usbtty/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear320_usbtty_pnor - Board: spear3xx_evb, Options: spear320,usbtty,FLASH_PNOR arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear320_usbtty_nand/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear320_usbtty_nand/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear320_usbtty_nand/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear600 - Board: spear6xx_evb, Options: spear600 arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear320_usbtty_pnor/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear320_usbtty_pnor/drivers/net/designware.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [/tmp/u-boot-build/spear320_usbtty_pnor/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear600_nand - Board: spear6xx_evb, Options: spear600,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear600/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear600/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear600/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear600_usbtty - Board: spear6xx_evb, Options: spear600,usbtty arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear600_nand/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear600_nand/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear600_nand/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for spear600_usbtty_nand - Board: spear6xx_evb, Options: spear600,usbtty,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear600_usbtty/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear600_usbtty/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear600_usbtty/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs.... Configuring for versatileab - Board: versatile, Options: ARCH_VERSATILE_AB arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear600_usbtty_nand/u-boot': No such file In file included from designware.c:18:0: designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function) designware.c: In function 'tx_descs_init': designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'rx_descs_init': designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c: In function 'dw_eth_send': designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration] designware.c: In function 'dw_eth_recv': designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32' make[1]: *** [/tmp/u-boot-build/spear600_usbtty_nand/drivers/net/designware.o] Error 1 make: *** [/tmp/u-boot-build/spear600_usbtty_nand/drivers/net/built-in.o] Error 2 make: *** Waiting for unfinished jobs....
participants (2)
-
Frank Dols -
Joe Hershberger