Re: [U-Boot-Users] [PATCH] Make MPC83xx one step closer to full relocation.
On Tuesday 08 April 2008, Joakim Tjernlund wrote:
Anyhow, we can go with the other solution instead, define the symbol in start.S instead, if one is needed.
If it cannot be avoided ;-)
... Stefan, maybe you can #define EXC_OFF_SYS_RESET for 405 to something that fits with my relocation patch?
Not sure if this could be done, since EXC_OFF_SYS_RESET is used for other things as well, and changing its value might bring other problems. And this really sounds like a bad hack, to change EXC_OFF_SYS_RESET to something "strange". So, no I don't want to fix this problem this way.
Since I'm really short in time currently, and I need U-Boot running on 4xx again, I vote for reverting this patch now. I'll try to come up with a "generic" solution for the next merge window.
Wolfgang? What do you think?
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
In message 200804091140.45661.sr@denx.de you wrote:
Since I'm really short in time currently, and I need U-Boot running on 4xx again, I vote for reverting this patch now. I'll try to come up with a "generic" solution for the next merge window.
Wolfgang? What do you think?
I agree. This patch is too invasive at this point of the development cycle. Please revert it. We will handle this in the next merge window, then.
Best regards,
Wolfgang Denk
On Wed, 2008-04-09 at 12:44 +0200, Wolfgang Denk wrote:
In message 200804091140.45661.sr@denx.de you wrote:
Since I'm really short in time currently, and I need U-Boot running on 4xx again, I vote for reverting this patch now. I'll try to come up with a "generic" solution for the next merge window.
Wolfgang? What do you think?
I agree. This patch is too invasive at this point of the development cycle. Please revert it. We will handle this in the next merge window, then.
I rather see a #ifdef for ppc4xx instead.
Jocke
On Wednesday 09 April 2008, Joakim Tjernlund wrote:
On Wed, 2008-04-09 at 12:44 +0200, Wolfgang Denk wrote:
In message 200804091140.45661.sr@denx.de you wrote:
Since I'm really short in time currently, and I need U-Boot running on 4xx again, I vote for reverting this patch now. I'll try to come up with a "generic" solution for the next merge window.
Wolfgang? What do you think?
I agree. This patch is too invasive at this point of the development cycle. Please revert it. We will handle this in the next merge window, then.
I rather see a #ifdef for ppc4xx instead.
I disagree. As we would need different symbols for 405 and 440, this would look really ugly. So let's fix it correctly in the next merge window.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
In message 1207739685.5826.63.camel@gentoo-jocke.transmode.se you wrote:
I agree. This patch is too invasive at this point of the development cycle. Please revert it. We will handle this in the next merge window, then.
I rather see a #ifdef for ppc4xx instead.
Yes - in the next window, please.
Best regards,
Wolfgang Denk
participants (3)
-
Joakim Tjernlund -
Stefan Roese -
Wolfgang Denk