[U-Boot] [PATCH 1/2] board/t4240rdb: Disable the non-existent ethernet port on T4240RDB
From: Ying Zhang b40530@freescale.com
There are 12 ethernet port on T4240RDB, but there need to set 16 MAC addressed for ethernets.
There need to disable non-existent ethernet ports in U-boot
Signed-off-by: Ying Zhang b40530@freescale.com --- board/freescale/t4rdb/eth.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/board/freescale/t4rdb/eth.c b/board/freescale/t4rdb/eth.c index e563a61..ae2451e 100644 --- a/board/freescale/t4rdb/eth.c +++ b/board/freescale/t4rdb/eth.c @@ -77,6 +77,9 @@ int board_eth_init(bd_t *bis) puts("Invalid SerDes1 protocol for T4240RDB\n"); }
+ fm_disable_port(FM1_DTSEC5); + fm_disable_port(FM1_DTSEC6); + for (i = FM1_DTSEC1; i < FM1_DTSEC1 + CONFIG_SYS_NUM_FM1_DTSEC; i++) { interface = fm_info_get_enet_if(i); switch (interface) { @@ -115,6 +118,8 @@ int board_eth_init(bd_t *bis) puts("Invalid SerDes2 protocol for T4240RDB\n"); }
+ fm_disable_port(FM2_DTSEC5); + fm_disable_port(FM2_DTSEC6); for (i = FM2_DTSEC1; i < FM2_DTSEC1 + CONFIG_SYS_NUM_FM2_DTSEC; i++) { interface = fm_info_get_enet_if(i); switch (interface) {
From: Ying Zhang b40530@freescale.com
FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
Signed-off-by: Ying Zhang b40530@freescale.com --- drivers/net/fm/t4240.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index ae5aca4..70887fa 100644 --- a/drivers/net/fm/t4240.c +++ b/drivers/net/fm/t4240.c @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port port) if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) && ((is_serdes_configured(XFI_FM1_MAC9)) || (is_serdes_configured(XFI_FM1_MAC10)))) - return PHY_INTERFACE_MODE_XGMII; + return PHY_INTERFACE_MODE_NONE;
if ((port == FM2_10GEC1 || port == FM2_10GEC2) && ((is_serdes_configured(XAUI_FM2_MAC9)) ||
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of ying.zhang@freescale.com Sent: Friday, April 15, 2016 2:19 PM To: u-boot@lists.denx.de Cc: yorksun@freescale.com; Ying Zhang b40530@freescale.com Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
From: Ying Zhang b40530@freescale.com
FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
Signed-off-by: Ying Zhang b40530@freescale.com
drivers/net/fm/t4240.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index ae5aca4..70887fa 100644 --- a/drivers/net/fm/t4240.c +++ b/drivers/net/fm/t4240.c @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port port) if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) && ((is_serdes_configured(XFI_FM1_MAC9)) || (is_serdes_configured(XFI_FM1_MAC10))))
return PHY_INTERFACE_MODE_XGMII;
return PHY_INTERFACE_MODE_NONE;
This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should be configured when RCW uses the these MACs. -Shengzhou
Dear ying.zhang@freescale.com,
In message 1460701149-36278-2-git-send-email-ying.zhang@freescale.com you wrote:
From: Ying Zhang b40530@freescale.com
FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
Can you please explain (and add the explanation to the commit message) what this means?
Are this ports detected, but not predent on this board? Or should they be hidden for some purpose? Why? Or what else?
Best regards,
Wolfgang Denk
-----Original Message----- From: Shengzhou Liu Sent: Friday, April 15, 2016 3:45 PM To: 'ying.zhang@freescale.com' ying.zhang@freescale.com; u- boot@lists.denx.de Cc: yorksun@freescale.com; Ying Zhang b40530@freescale.com Subject: RE: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of ying.zhang@freescale.com Sent: Friday, April 15, 2016 2:19 PM To: u-boot@lists.denx.de Cc: yorksun@freescale.com; Ying Zhang b40530@freescale.com Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
From: Ying Zhang b40530@freescale.com
FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
Signed-off-by: Ying Zhang b40530@freescale.com
drivers/net/fm/t4240.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index ae5aca4..70887fa 100644 --- a/drivers/net/fm/t4240.c +++ b/drivers/net/fm/t4240.c @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port
port)
if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) && ((is_serdes_configured(XFI_FM1_MAC9)) || (is_serdes_configured(XFI_FM1_MAC10))))
return PHY_INTERFACE_MODE_XGMII;
return PHY_INTERFACE_MODE_NONE;This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should be configured when RCW uses the these MACs. -Shengzhou
Sorry, I missed the condition, the change is right. Shengzhou
Hi Ying,
The commit message should be more clear about what is wrong. Like when using protocols to support 10G on MAC9 and MAC10, these MACs should not be identified as 1G interface, otherwise, one MAC will be Listed as two Ethernet ports, for ex. MAC9 will be listed as FM1@TGEC1 And FM1@DTSEC9.
Thanks, Shaohui
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Shengzhou Liu Sent: Friday, April 15, 2016 3:58 PM To: ying.zhang@freescale.com; u-boot@lists.denx.de Cc: yorksun@freescale.com; Ying Zhang b40530@freescale.com Subject: Re: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
-----Original Message----- From: Shengzhou Liu Sent: Friday, April 15, 2016 3:45 PM To: 'ying.zhang@freescale.com' ying.zhang@freescale.com; u- boot@lists.denx.de Cc: yorksun@freescale.com; Ying Zhang b40530@freescale.com Subject: RE: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of ying.zhang@freescale.com Sent: Friday, April 15, 2016 2:19 PM To: u-boot@lists.denx.de Cc: yorksun@freescale.com; Ying Zhang b40530@freescale.com Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
From: Ying Zhang b40530@freescale.com
FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
Signed-off-by: Ying Zhang b40530@freescale.com
drivers/net/fm/t4240.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index ae5aca4..70887fa 100644 --- a/drivers/net/fm/t4240.c +++ b/drivers/net/fm/t4240.c @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port
port)
if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) && ((is_serdes_configured(XFI_FM1_MAC9)) || (is_serdes_configured(XFI_FM1_MAC10))))
return PHY_INTERFACE_MODE_XGMII;
return PHY_INTERFACE_MODE_NONE;This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should be configured when RCW uses the these MACs. -Shengzhou
Sorry, I missed the condition, the change is right. Shengzhou _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
participants (4)
-
Shaohui Xie -
Shengzhou Liu -
Wolfgang Denk -
ying.zhang＠freescale.com