[U-Boot] [PATCH 0/5] ARM: Enable CMD_TIME on all TI platforms
This series enables CMD_TIME on all TI platforms.
Lokesh Vutla (5): configs: am335x: Enable CMD_TIME configs: am43xx: Enable CMD_TIME configs: am57xx: Enable CMD_TIME configs: dra7xx: Enable CMD_TIME configs: ks2: Enable CMD_TIME
configs/am335x_boneblack_defconfig | 1 + configs/am335x_evm_defconfig | 1 + configs/am335x_evm_nor_defconfig | 1 + configs/am335x_evm_norboot_defconfig | 1 + configs/am335x_evm_spiboot_defconfig | 1 + configs/am335x_evm_usbspl_defconfig | 1 + configs/am43xx_evm_defconfig | 1 + configs/am43xx_evm_ethboot_defconfig | 1 + configs/am43xx_evm_qspiboot_defconfig | 1 + configs/am43xx_evm_usbhost_boot_defconfig | 1 + configs/am43xx_hs_evm_defconfig | 1 + configs/am57xx_evm_defconfig | 1 + configs/am57xx_hs_evm_defconfig | 1 + configs/dra7xx_evm_defconfig | 1 + configs/dra7xx_hs_evm_defconfig | 1 + configs/k2e_evm_defconfig | 1 + configs/k2g_evm_defconfig | 1 + configs/k2hk_evm_defconfig | 1 + configs/k2l_evm_defconfig | 1 + 19 files changed, 19 insertions(+)
Enable CONFIG_CMD_TIME for all am335x platforms
Signed-off-by: Lokesh Vutla lokeshvutla@ti.com --- configs/am335x_boneblack_defconfig | 1 + configs/am335x_evm_defconfig | 1 + configs/am335x_evm_nor_defconfig | 1 + configs/am335x_evm_norboot_defconfig | 1 + configs/am335x_evm_spiboot_defconfig | 1 + configs/am335x_evm_usbspl_defconfig | 1 + 6 files changed, 6 insertions(+)
diff --git a/configs/am335x_boneblack_defconfig b/configs/am335x_boneblack_defconfig index d310e0b..5eebd2a 100644 --- a/configs/am335x_boneblack_defconfig +++ b/configs/am335x_boneblack_defconfig @@ -43,3 +43,4 @@ CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 CONFIG_OF_LIBFDT=y +CONFIG_CMD_TIME=y diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig index 6885230..2e11ac4 100644 --- a/configs/am335x_evm_defconfig +++ b/configs/am335x_evm_defconfig @@ -50,3 +50,4 @@ CONFIG_SPL_OF_LIBFDT=y CONFIG_SPL_LOAD_FIT=y CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2" CONFIG_DM_I2C=y +CONFIG_CMD_TIME=y diff --git a/configs/am335x_evm_nor_defconfig b/configs/am335x_evm_nor_defconfig index 76a004e..f2e1bf9 100644 --- a/configs/am335x_evm_nor_defconfig +++ b/configs/am335x_evm_nor_defconfig @@ -39,3 +39,4 @@ CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 CONFIG_OF_LIBFDT=y CONFIG_SPL_NET_VCI_STRING="AM335x U-Boot SPL" +CONFIG_CMD_TIME=y diff --git a/configs/am335x_evm_norboot_defconfig b/configs/am335x_evm_norboot_defconfig index 99fc555..70a3167 100644 --- a/configs/am335x_evm_norboot_defconfig +++ b/configs/am335x_evm_norboot_defconfig @@ -36,3 +36,4 @@ CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 CONFIG_OF_LIBFDT=y CONFIG_SPL_NET_VCI_STRING="AM335x U-Boot SPL" +CONFIG_CMD_TIME=y diff --git a/configs/am335x_evm_spiboot_defconfig b/configs/am335x_evm_spiboot_defconfig index 2fe1a25..11637c0 100644 --- a/configs/am335x_evm_spiboot_defconfig +++ b/configs/am335x_evm_spiboot_defconfig @@ -39,3 +39,4 @@ CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 CONFIG_OF_LIBFDT=y +CONFIG_CMD_TIME=y diff --git a/configs/am335x_evm_usbspl_defconfig b/configs/am335x_evm_usbspl_defconfig index cba5e84..5269484 100644 --- a/configs/am335x_evm_usbspl_defconfig +++ b/configs/am335x_evm_usbspl_defconfig @@ -39,3 +39,4 @@ CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 CONFIG_OF_LIBFDT=y CONFIG_SPL_NET_VCI_STRING="AM335x U-Boot SPL" +CONFIG_CMD_TIME=y
Enable CONFIG_CMD_TIME for all am43xx platforms
Signed-off-by: Lokesh Vutla lokeshvutla@ti.com --- configs/am43xx_evm_defconfig | 1 + configs/am43xx_evm_ethboot_defconfig | 1 + configs/am43xx_evm_qspiboot_defconfig | 1 + configs/am43xx_evm_usbhost_boot_defconfig | 1 + configs/am43xx_hs_evm_defconfig | 1 + 5 files changed, 5 insertions(+)
diff --git a/configs/am43xx_evm_defconfig b/configs/am43xx_evm_defconfig index b3fe269..9cb06aa 100644 --- a/configs/am43xx_evm_defconfig +++ b/configs/am43xx_evm_defconfig @@ -56,3 +56,4 @@ CONFIG_G_DNL_VENDOR_NUM=0x0403 CONFIG_G_DNL_PRODUCT_NUM=0xbd00 CONFIG_SPL_OF_LIBFDT=y CONFIG_DM_I2C=y +CONFIG_CMD_TIME=y diff --git a/configs/am43xx_evm_ethboot_defconfig b/configs/am43xx_evm_ethboot_defconfig index 3b958d7..aef1144 100644 --- a/configs/am43xx_evm_ethboot_defconfig +++ b/configs/am43xx_evm_ethboot_defconfig @@ -42,3 +42,4 @@ CONFIG_G_DNL_VENDOR_NUM=0x0403 CONFIG_G_DNL_PRODUCT_NUM=0xbd00 CONFIG_OF_LIBFDT=y CONFIG_SPL_NET_VCI_STRING="AM43xx U-Boot SPL" +CONFIG_CMD_TIME=y diff --git a/configs/am43xx_evm_qspiboot_defconfig b/configs/am43xx_evm_qspiboot_defconfig index c6bc8e4..e4b65c6 100644 --- a/configs/am43xx_evm_qspiboot_defconfig +++ b/configs/am43xx_evm_qspiboot_defconfig @@ -42,3 +42,4 @@ CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0403 CONFIG_G_DNL_PRODUCT_NUM=0xbd00 CONFIG_OF_LIBFDT=y +CONFIG_CMD_TIME=y diff --git a/configs/am43xx_evm_usbhost_boot_defconfig b/configs/am43xx_evm_usbhost_boot_defconfig index 34c875e..d993a13 100644 --- a/configs/am43xx_evm_usbhost_boot_defconfig +++ b/configs/am43xx_evm_usbhost_boot_defconfig @@ -57,3 +57,4 @@ CONFIG_FIT=y CONFIG_SPL_OF_LIBFDT=y CONFIG_SPL_LOAD_FIT=y CONFIG_OF_LIST="am437x-gp-evm am437x-sk-evm am43x-epos-evm am437x-idk-evm" +CONFIG_CMD_TIME=y diff --git a/configs/am43xx_hs_evm_defconfig b/configs/am43xx_hs_evm_defconfig index c8ce723..388bb1b 100644 --- a/configs/am43xx_hs_evm_defconfig +++ b/configs/am43xx_hs_evm_defconfig @@ -59,3 +59,4 @@ CONFIG_G_DNL_VENDOR_NUM=0x0403 CONFIG_G_DNL_PRODUCT_NUM=0xbd00 CONFIG_SPL_OF_LIBFDT=y CONFIG_DM_I2C=y +CONFIG_CMD_TIME=y
Enable CONFIG_CMD_TIME for all am57x platforms
Signed-off-by: Lokesh Vutla lokeshvutla@ti.com --- configs/am57xx_evm_defconfig | 1 + configs/am57xx_hs_evm_defconfig | 1 + 2 files changed, 2 insertions(+)
diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig index c95f45a..1649466 100644 --- a/configs/am57xx_evm_defconfig +++ b/configs/am57xx_evm_defconfig @@ -46,3 +46,4 @@ CONFIG_DM_SPI_FLASH=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_TI_QSPI=y CONFIG_CMD_SF=y +CONFIG_CMD_TIME=y diff --git a/configs/am57xx_hs_evm_defconfig b/configs/am57xx_hs_evm_defconfig index a4bfdd5..2ef92ce 100644 --- a/configs/am57xx_hs_evm_defconfig +++ b/configs/am57xx_hs_evm_defconfig @@ -48,3 +48,4 @@ CONFIG_DM_SPI_FLASH=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_TI_QSPI=y CONFIG_CMD_SF=y +CONFIG_CMD_TIME=y
Enable CONFIG_CMD_TIME for all dra7xx platforms
Signed-off-by: Lokesh Vutla lokeshvutla@ti.com --- configs/dra7xx_evm_defconfig | 1 + configs/dra7xx_hs_evm_defconfig | 1 + 2 files changed, 2 insertions(+)
diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig index 81d2a0e..b6df7ae 100644 --- a/configs/dra7xx_evm_defconfig +++ b/configs/dra7xx_evm_defconfig @@ -59,3 +59,4 @@ CONFIG_SPL_LOAD_FIT=y CONFIG_OF_LIST="dra7-evm dra72-evm" CONFIG_DM_I2C=y CONFIG_PCF8575_GPIO=y +CONFIG_CMD_TIME=y diff --git a/configs/dra7xx_hs_evm_defconfig b/configs/dra7xx_hs_evm_defconfig index ab68b1c..2848094 100644 --- a/configs/dra7xx_hs_evm_defconfig +++ b/configs/dra7xx_hs_evm_defconfig @@ -62,3 +62,4 @@ CONFIG_SPL_FIT_IMAGE_POST_PROCESS=y CONFIG_OF_LIST="dra7-evm dra72-evm" CONFIG_DM_I2C=y CONFIG_PCF8575_GPIO=y +CONFIG_CMD_TIME=y
Enable CMD_TIME on all keystone2 platforms
Signed-off-by: Lokesh Vutla lokeshvutla@ti.com --- configs/k2e_evm_defconfig | 1 + configs/k2g_evm_defconfig | 1 + configs/k2hk_evm_defconfig | 1 + configs/k2l_evm_defconfig | 1 + 4 files changed, 4 insertions(+)
diff --git a/configs/k2e_evm_defconfig b/configs/k2e_evm_defconfig index 04c52f0..155e567 100644 --- a/configs/k2e_evm_defconfig +++ b/configs/k2e_evm_defconfig @@ -39,3 +39,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_LIB_RAND=y CONFIG_NET_RANDOM_ETHADDR=y +CONFIG_CMD_TIME=y diff --git a/configs/k2g_evm_defconfig b/configs/k2g_evm_defconfig index 5d44e8d..d412f52 100644 --- a/configs/k2g_evm_defconfig +++ b/configs/k2g_evm_defconfig @@ -39,3 +39,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_BAR=y +CONFIG_CMD_TIME=y diff --git a/configs/k2hk_evm_defconfig b/configs/k2hk_evm_defconfig index c050f07..bc41392 100644 --- a/configs/k2hk_evm_defconfig +++ b/configs/k2hk_evm_defconfig @@ -39,3 +39,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_LIB_RAND=y CONFIG_NET_RANDOM_ETHADDR=y +CONFIG_CMD_TIME=y diff --git a/configs/k2l_evm_defconfig b/configs/k2l_evm_defconfig index e1386f7..6eb0141 100644 --- a/configs/k2l_evm_defconfig +++ b/configs/k2l_evm_defconfig @@ -39,3 +39,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_LIB_RAND=y CONFIG_NET_RANDOM_ETHADDR=y +CONFIG_CMD_TIME=y
On Thu, Aug 11, 2016 at 06:39:12PM +0530, Lokesh Vutla wrote:
This series enables CMD_TIME on all TI platforms.
Lokesh Vutla (5): configs: am335x: Enable CMD_TIME configs: am43xx: Enable CMD_TIME configs: am57xx: Enable CMD_TIME configs: dra7xx: Enable CMD_TIME configs: ks2: Enable CMD_TIME
configs/am335x_boneblack_defconfig | 1 + configs/am335x_evm_defconfig | 1 + configs/am335x_evm_nor_defconfig | 1 + configs/am335x_evm_norboot_defconfig | 1 + configs/am335x_evm_spiboot_defconfig | 1 + configs/am335x_evm_usbspl_defconfig | 1 + configs/am43xx_evm_defconfig | 1 + configs/am43xx_evm_ethboot_defconfig | 1 + configs/am43xx_evm_qspiboot_defconfig | 1 + configs/am43xx_evm_usbhost_boot_defconfig | 1 + configs/am43xx_hs_evm_defconfig | 1 + configs/am57xx_evm_defconfig | 1 + configs/am57xx_hs_evm_defconfig | 1 + configs/dra7xx_evm_defconfig | 1 + configs/dra7xx_hs_evm_defconfig | 1 + configs/k2e_evm_defconfig | 1 + configs/k2g_evm_defconfig | 1 + configs/k2hk_evm_defconfig | 1 + configs/k2l_evm_defconfig | 1 + 19 files changed, 19 insertions(+)
This would have been a 1 line change to include/configs/ti_armv7_common.h and is now 19 files and 19 lines, so a step backwards. Further, this isn't a SoC thing, it's a TI eval platform consistency (and I imagine testing) thing. I think it's time to look at adding in board/ti/Kconfig (and other vendors too given the existing include/configs/*common* files) for style things that don't belong in arch/arm/cpu/armv7/omap-common/Kconfig (which needs to get moved to arch/arm/mach-omap to match other platforms, yes) in this case.
The first patch to introduce board/ti/Kconfig will be "big" as the board/ti/*/Kconfig will need to bring it in but follow up migration of stuff out of include/configs/ti_*common.h will be smaller.
Thanks!
On Thursday 11 August 2016 07:01 PM, Tom Rini wrote:
On Thu, Aug 11, 2016 at 06:39:12PM +0530, Lokesh Vutla wrote:
This series enables CMD_TIME on all TI platforms.
Lokesh Vutla (5): configs: am335x: Enable CMD_TIME configs: am43xx: Enable CMD_TIME configs: am57xx: Enable CMD_TIME configs: dra7xx: Enable CMD_TIME configs: ks2: Enable CMD_TIME
configs/am335x_boneblack_defconfig | 1 + configs/am335x_evm_defconfig | 1 + configs/am335x_evm_nor_defconfig | 1 + configs/am335x_evm_norboot_defconfig | 1 + configs/am335x_evm_spiboot_defconfig | 1 + configs/am335x_evm_usbspl_defconfig | 1 + configs/am43xx_evm_defconfig | 1 + configs/am43xx_evm_ethboot_defconfig | 1 + configs/am43xx_evm_qspiboot_defconfig | 1 + configs/am43xx_evm_usbhost_boot_defconfig | 1 + configs/am43xx_hs_evm_defconfig | 1 + configs/am57xx_evm_defconfig | 1 + configs/am57xx_hs_evm_defconfig | 1 + configs/dra7xx_evm_defconfig | 1 + configs/dra7xx_hs_evm_defconfig | 1 + configs/k2e_evm_defconfig | 1 + configs/k2g_evm_defconfig | 1 + configs/k2hk_evm_defconfig | 1 + configs/k2l_evm_defconfig | 1 + 19 files changed, 19 insertions(+)
This would have been a 1 line change to include/configs/ti_armv7_common.h and is now 19 files and 19 lines, so a
IIRC, this solution was rejected as CMD_TIME has Kconfig and has to be enabled in defconfig.
step backwards. Further, this isn't a SoC thing, it's a TI eval platform consistency (and I imagine testing) thing. I think it's time to look at adding in board/ti/Kconfig (and other vendors too given the existing include/configs/*common* files) for style things that don't belong in arch/arm/cpu/armv7/omap-common/Kconfig (which needs to get moved to arch/arm/mach-omap to match other platforms, yes) in this case.
The first patch to introduce board/ti/Kconfig will be "big" as the board/ti/*/Kconfig will need to bring it in but follow up migration of stuff out of include/configs/ti_*common.h will be smaller.
Okay, ill work on this.
Thanks and regards, Lokesh
Thanks!
participants (2)
-
Lokesh Vutla -
Tom Rini