Re: [U-Boot] Bug in new at91 clock framework?

Jean-Christophe PLAGNIOL-VILLARD schrieb:
On 12:15 Wed 22 Apr , Daniel Gorsulowski wrote:
Hello Jean-Christophe,
I'm not sure, but I think there is a bug in your new at91 clock framework. My board does only boot, if CONFIG_USB_ATMEL is defined. But the board does not have any usb-ports, so there is no need to define CONFIG_USB_ATMEL. The board is based on an Atmel AT91SAM9263 SoC.
I've seen in with the one on my clock branch but if you use the one for the pull request normaly not
I've test it on my 9263EK
Best Regards, J.
I'm working on git://git.denx.de/u-boot-at91.git branch clock I also have an AT91SAM9263-EK, but with a 16.0 MHz main oscillator. Everything is fine, as long as no changes were made. But if I undef CONFIG_USB_ATMEL and CONFIG_CMD_USB, the board does not boot. Only some cryptical characters appear after the "RomBOOT" term. It's the same behavior as on my own board.
If i do the same on git://git.denx.de/u-boot.git branch master, everything works fine. (as well AT91SAM9263-EK as my board) Do you have any advice for debugging that problem?
Best regards, Daniel Gorsulowski

I'm working on git://git.denx.de/u-boot-at91.git branch clock I also have an AT91SAM9263-EK, but with a 16.0 MHz main oscillator. Everything is fine, as long as no changes were made. But if I undef CONFIG_USB_ATMEL and CONFIG_CMD_USB, the board does not boot. Only some cryptical characters appear after the "RomBOOT" term. It's the same behavior as on my own board.
use git://git.denx.de/u-boot-at91.git branch master
Best Regards, J.

Jean-Christophe PLAGNIOL-VILLARD schrieb:
I'm working on git://git.denx.de/u-boot-at91.git branch clock I also have an AT91SAM9263-EK, but with a 16.0 MHz main oscillator. Everything is fine, as long as no changes were made. But if I undef CONFIG_USB_ATMEL and CONFIG_CMD_USB, the board does not boot. Only some cryptical characters appear after the "RomBOOT" term. It's the same behavior as on my own board.
use git://git.denx.de/u-boot-at91.git branch master
Best Regards, J.
Thank you, it works now. But I have to apply the attached patch. Otherwise, I get a compiler error cpu/arm926ejs/at91/libat91.a(clock.o): In function `at91_clock_init': /data/home/danielg/git/u-boot-at91_new/cpu/arm926ejs/at91/clock.c:167: undefined reference to `at91_pll_rate'
--- From 730db691fabf958d1b3d74e678f7f47a0776df16 Mon Sep 17 00:00:00 2001 From: Daniel Gorsulowski Daniel.Gorsulowski@esd.eu Date: Thu, 23 Apr 2009 15:37:16 +0200 Subject: [PATCH] at91: fixed cpu/arm926ejs/at91/clock.c
Signed-off-by: Daniel Gorsulowski Daniel.Gorsulowski@esd.eu --- cpu/arm926ejs/at91/clock.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpu/arm926ejs/at91/clock.c b/cpu/arm926ejs/at91/clock.c index 31e53b3..f776f70 100644 --- a/cpu/arm926ejs/at91/clock.c +++ b/cpu/arm926ejs/at91/clock.c @@ -126,6 +126,7 @@ static unsigned at91_pll_calc(unsigned main_freq, unsigned out_freq) fail: return 0; } +#endif
static u32 at91_pll_rate(u32 freq, u32 reg) { @@ -141,7 +142,6 @@ static u32 at91_pll_rate(u32 freq, u32 reg)
return freq; } -#endif
int at91_clock_init(unsigned long main_clock) {
participants (2)
-
Daniel Gorsulowski
-
Jean-Christophe PLAGNIOL-VILLARD