[PATCH] arm: dts: rockpro64: Add RockPro64 smbios
--- arch/arm/dts/rk3399-rockpro64.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64.dtsi b/arch/arm/dts/rk3399-rockpro64.dtsi index 6bff8db7d3..cf850a69e6 100644 --- a/arch/arm/dts/rk3399-rockpro64.dtsi +++ b/arch/arm/dts/rk3399-rockpro64.dtsi @@ -20,6 +20,26 @@ stdout-path = "serial2:1500000n8"; };
+ smbios { + compatible = "u-boot,sysinfo-smbios"; + smbios { + system { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + + baseboard { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + + chassis { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + }; + }; + clkin_gmac: external-gmac-clock { compatible = "fixed-clock"; clock-frequency = <125000000>;
On Fri, Nov 10, 2023 at 11:58:06PM +0000, Shantur Rathore wrote:
arch/arm/dts/rk3399-rockpro64.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64.dtsi b/arch/arm/dts/rk3399-rockpro64.dtsi index 6bff8db7d3..cf850a69e6 100644 --- a/arch/arm/dts/rk3399-rockpro64.dtsi +++ b/arch/arm/dts/rk3399-rockpro64.dtsi @@ -20,6 +20,26 @@ stdout-path = "serial2:1500000n8"; };
- smbios {
compatible = "u-boot,sysinfo-smbios";
This needs to be in a -u-boot.dtsi file.
Signed-off-by: Shantur Rathore i@shantur.com --- arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..a4453e76f6 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; }; + + smbios { + compatible = "u-boot,sysinfo-smbios"; + smbios { + system { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + + baseboard { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + + chassis { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + }; + }; + + };
&sdhci {
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com --- Changes v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..a4453e76f6 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; }; + + smbios { + compatible = "u-boot,sysinfo-smbios"; + smbios { + system { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + + baseboard { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + + chassis { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + }; + }; + + };
&sdhci { diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 4cd6b76665..affb6137e0 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYS_NS16550_MEM32=y CONFIG_ROCKCHIP_SPI=y +CONFIG_SYSINFO=y +CONFIG_SYSINFO_SMBIOS=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y
On 2023-11-13 11:01, Shantur Rathore wrote:
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com
Changes v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..a4453e76f6 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; };
smbios {compatible = "u-boot,sysinfo-smbios";smbios {system {manufacturer = "PINE64";product = "RockPro64";};baseboard {manufacturer = "PINE64";product = "RockPro64";};chassis {manufacturer = "PINE64";product = "RockPro64";};};};};
Perhaps it would be better to use "Pine64" instead of "PINE64", because "Pine64" is already used in multiple places. Also, it might be better to use "ROCKPro64" instead of "RockPro64", because that's actually the official name of the board, but I'm also perfectly fine with "RockPro64".
&sdhci { diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 4cd6b76665..affb6137e0 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYS_NS16550_MEM32=y CONFIG_ROCKCHIP_SPI=y +CONFIG_SYSINFO=y +CONFIG_SYSINFO_SMBIOS=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com --- Changes v4: Change PINE64 to Pine64 v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..089732524a 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; }; + + smbios { + compatible = "u-boot,sysinfo-smbios"; + smbios { + system { + manufacturer = "Pine64"; + product = "RockPro64"; + }; + + baseboard { + manufacturer = "Pine64"; + product = "RockPro64"; + }; + + chassis { + manufacturer = "Pine64"; + product = "RockPro64"; + }; + }; + }; + + };
&sdhci { diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 4cd6b76665..affb6137e0 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYS_NS16550_MEM32=y CONFIG_ROCKCHIP_SPI=y +CONFIG_SYSINFO=y +CONFIG_SYSINFO_SMBIOS=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y
Hi,
On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore i@shantur.com wrote:
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com
Changes v4: Change PINE64 to Pine64 v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..089732524a 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; };
smbios {compatible = "u-boot,sysinfo-smbios";smbios {system {manufacturer = "Pine64";product = "RockPro64";};baseboard {manufacturer = "Pine64";product = "RockPro64";};chassis {manufacturer = "Pine64";product = "RockPro64";};};};};
&sdhci { diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 4cd6b76665..affb6137e0 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYS_NS16550_MEM32=y CONFIG_ROCKCHIP_SPI=y +CONFIG_SYSINFO=y +CONFIG_SYSINFO_SMBIOS=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y -- 2.40.1
Can this please be merged if no changes are required?
[0] - https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-1-i@s...
Kind regards, Shantur
On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
Hi,
On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore i@shantur.com wrote:
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com
Changes v4: Change PINE64 to Pine64 v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..089732524a 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; };
smbios {compatible = "u-boot,sysinfo-smbios";smbios {system {manufacturer = "Pine64";product = "RockPro64";};baseboard {manufacturer = "Pine64";product = "RockPro64";};chassis {manufacturer = "Pine64";product = "RockPro64";};};};};
&sdhci { diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 4cd6b76665..affb6137e0 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYS_NS16550_MEM32=y CONFIG_ROCKCHIP_SPI=y +CONFIG_SYSINFO=y +CONFIG_SYSINFO_SMBIOS=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y -- 2.40.1
Can this please be merged if no changes are required?
[0] - https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-1-i@s...
Yes, we should just defer this and pickup the SMBIOS series that Ilias has posted.
Hi Tom,
On Mon, 11 Dec 2023 at 13:53, Tom Rini trini@konsulko.com wrote:
On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
Hi,
On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore i@shantur.com wrote:
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com
Changes v4: Change PINE64 to Pine64 v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..089732524a 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; };
smbios {compatible = "u-boot,sysinfo-smbios";smbios {system {manufacturer = "Pine64";product = "RockPro64";};baseboard {manufacturer = "Pine64";product = "RockPro64";};chassis {manufacturer = "Pine64";product = "RockPro64";};};};};
&sdhci { diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 4cd6b76665..affb6137e0 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYS_NS16550_MEM32=y CONFIG_ROCKCHIP_SPI=y +CONFIG_SYSINFO=y +CONFIG_SYSINFO_SMBIOS=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y -- 2.40.1
Can this please be merged if no changes are required?
[0] - https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-1-i@s...
Yes, we should just defer this and pickup the SMBIOS series that Ilias has posted.
I don't think it is a suitable substitute, it is just a fallback.
So I believe this patch should be applied.
Reviewed-by: Simon Glass sjg@chromium.org
Regards, Simon
On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
Hi Tom,
On Mon, 11 Dec 2023 at 13:53, Tom Rini trini@konsulko.com wrote:
On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
Hi,
On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore i@shantur.com wrote:
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com
Changes v4: Change PINE64 to Pine64 v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..089732524a 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; };
smbios {compatible = "u-boot,sysinfo-smbios";smbios {system {manufacturer = "Pine64";product = "RockPro64";};
[snip]
Yes, we should just defer this and pickup the SMBIOS series that Ilias has posted.
I don't think it is a suitable substitute, it is just a fallback.
So I believe this patch should be applied.
Please note that this patch is adding _less_ details than the top-level model field contains today for the platform. The only difference is "Pine64" vs "pine64".
Hi Tom,
On Wed, 13 Dec 2023 at 13:29, Tom Rini trini@konsulko.com wrote:
On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
Hi Tom,
On Mon, 11 Dec 2023 at 13:53, Tom Rini trini@konsulko.com wrote:
On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
Hi,
On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore i@shantur.com wrote:
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com
Changes v4: Change PINE64 to Pine64 v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..089732524a 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; };
smbios {compatible = "u-boot,sysinfo-smbios";smbios {system {manufacturer = "Pine64";product = "RockPro64";};[snip]
Yes, we should just defer this and pickup the SMBIOS series that Ilias has posted.
I don't think it is a suitable substitute, it is just a fallback.
So I believe this patch should be applied.
Please note that this patch is adding _less_ details than the top-level model field contains today for the platform. The only difference is "Pine64" vs "pine64".
The top-level model is "Pine64 RockPro64 v2.1", I believe. But:
- the first part of that is the manufacturer, not the product - the second part is what we have in this patch - the third part is the version
SMBIOS tries to split things up into separate fields.
So, perhaps a new version of this patch could add:
system { version = "2.1"; };
Regards, Simon
Hi,
On Wed, Dec 13, 2023 at 8:41 PM Simon Glass sjg@chromium.org wrote:
Hi Tom,
On Wed, 13 Dec 2023 at 13:29, Tom Rini trini@konsulko.com wrote:
On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
Hi Tom,
On Mon, 11 Dec 2023 at 13:53, Tom Rini trini@konsulko.com wrote:
On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
Hi,
On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore i@shantur.com wrote:
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com
Changes v4: Change PINE64 to Pine64 v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..089732524a 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; };
smbios {compatible = "u-boot,sysinfo-smbios";smbios {system {manufacturer = "Pine64";product = "RockPro64";};[snip]
Yes, we should just defer this and pickup the SMBIOS series that Ilias has posted.
I don't think it is a suitable substitute, it is just a fallback.
So I believe this patch should be applied.
Please note that this patch is adding _less_ details than the top-level model field contains today for the platform. The only difference is "Pine64" vs "pine64".
The top-level model is "Pine64 RockPro64 v2.1", I believe. But:
- the first part of that is the manufacturer, not the product
- the second part is what we have in this patch
- the third part is the version
SMBIOS tries to split things up into separate fields.
So, perhaps a new version of this patch could add:
system { version = "2.1"; };
I can add the above or any more details needed to a new patch Will that be enough to make it merge-able
Kind regards, Shantur
Hi Shantur,
On Thu, 14 Dec 2023 at 07:14, Shantur Rathore i@shantur.com wrote:
Hi,
On Wed, Dec 13, 2023 at 8:41 PM Simon Glass sjg@chromium.org wrote:
Hi Tom,
On Wed, 13 Dec 2023 at 13:29, Tom Rini trini@konsulko.com wrote:
On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
Hi Tom,
On Mon, 11 Dec 2023 at 13:53, Tom Rini trini@konsulko.com wrote:
On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
Hi,
On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore i@shantur.com wrote: > > Add smbios information for Pine64 RockPro64 board and enable in > config > > Signed-off-by: Shantur Rathore i@shantur.com > --- > Changes > v4: Change PINE64 to Pine64 > v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig > > arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ > configs/rockpro64-rk3399_defconfig | 2 ++ > 2 files changed, 24 insertions(+) > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi > index 732727d9b0..089732524a 100644 > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi > @@ -9,6 +9,28 @@ > chosen { > u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; > }; > + > + smbios { > + compatible = "u-boot,sysinfo-smbios"; > + smbios { > + system { > + manufacturer = "Pine64"; > + product = "RockPro64"; > + };
[snip]
Yes, we should just defer this and pickup the SMBIOS series that Ilias has posted.
I don't think it is a suitable substitute, it is just a fallback.
So I believe this patch should be applied.
Please note that this patch is adding _less_ details than the top-level model field contains today for the platform. The only difference is "Pine64" vs "pine64".
The top-level model is "Pine64 RockPro64 v2.1", I believe. But:
- the first part of that is the manufacturer, not the product
- the second part is what we have in this patch
- the third part is the version
SMBIOS tries to split things up into separate fields.
So, perhaps a new version of this patch could add:
system { version = "2.1"; };
I can add the above or any more details needed to a new patch Will that be enough to make it merge-able
From my POV, yes. Having dug into this a bit, patches like this are
the only way we can get authoritative SMBIOS data. There are various user-space workarounds, but these should not cause any problems.
Regards, Simon
On 2023/11/13 19:23, Shantur Rathore wrote:
Add smbios information for Pine64 RockPro64 board and enable in config
Signed-off-by: Shantur Rathore i@shantur.com
Reviewed-by: Kever Yang kever.yang@rock-chips.com
Thanks, - Kever
Changes v4: Change PINE64 to Pine64 v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++ configs/rockpro64-rk3399_defconfig | 2 ++ 2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi index 732727d9b0..089732524a 100644 --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi @@ -9,6 +9,28 @@ chosen { u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci; };
smbios {compatible = "u-boot,sysinfo-smbios";smbios {system {manufacturer = "Pine64";product = "RockPro64";};baseboard {manufacturer = "Pine64";product = "RockPro64";};chassis {manufacturer = "Pine64";product = "RockPro64";};};};};
&sdhci {
diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 4cd6b76665..affb6137e0 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYS_NS16550_MEM32=y CONFIG_ROCKCHIP_SPI=y +CONFIG_SYSINFO=y +CONFIG_SYSINFO_SMBIOS=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y
participants (5)
-
Dragan Simic -
Kever Yang -
Shantur Rathore -
Simon Glass -
Tom Rini