[U-Boot] [PATCH] davinci: omapl138_lcdk: enable time command
Enable time command for OMAP-L138 LCDK board.
The patch was generated using savedefconfig method.
Signed-off-by: Sekhar Nori nsekhar@ti.com --- configs/omapl138_lcdk_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/omapl138_lcdk_defconfig b/configs/omapl138_lcdk_defconfig index 7a5a78f4944b..d6de9b82787e 100644 --- a/configs/omapl138_lcdk_defconfig +++ b/configs/omapl138_lcdk_defconfig @@ -25,6 +25,7 @@ CONFIG_CMD_PART=y CONFIG_CMD_DHCP=y CONFIG_CMD_MII=y CONFIG_CMD_PING=y +CONFIG_CMD_TIME=y CONFIG_CMD_EXT2=y CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENERIC=y
On Wednesday 10 May 2017 04:27 PM, Sekhar Nori wrote:
Enable time command for OMAP-L138 LCDK board.
The patch was generated using savedefconfig method.
Signed-off-by: Sekhar Nori nsekhar@ti.com
Instead of enabling each command like this, I was about to ask to include TI_COMMON_CMD_OPTIONS( defined inside board/ti/common/Kconfig) for omapl138. Realized that omapl138 is under "board/davinci/" and cannot include board/ti/common/Kconfig directly. May be I am missing some history here, why can't all davinci boards be under board/ti?
Thanks and regards, Lokesh
On Wed, May 10, 2017 at 04:44:45PM +0530, Lokesh Vutla wrote:
On Wednesday 10 May 2017 04:27 PM, Sekhar Nori wrote:
Enable time command for OMAP-L138 LCDK board.
The patch was generated using savedefconfig method.
Signed-off-by: Sekhar Nori nsekhar@ti.com
Instead of enabling each command like this, I was about to ask to include TI_COMMON_CMD_OPTIONS( defined inside board/ti/common/Kconfig) for omapl138. Realized that omapl138 is under "board/davinci/" and cannot include board/ti/common/Kconfig directly. May be I am missing some history here, why can't all davinci boards be under board/ti?
History is the answer here, yes. But is there really a reason davinci couldn't source board/ti/common/Kconfig ?
On Wednesday 10 May 2017 04:56 PM, Tom Rini wrote:
On Wed, May 10, 2017 at 04:44:45PM +0530, Lokesh Vutla wrote:
On Wednesday 10 May 2017 04:27 PM, Sekhar Nori wrote:
Enable time command for OMAP-L138 LCDK board.
The patch was generated using savedefconfig method.
Signed-off-by: Sekhar Nori nsekhar@ti.com
Instead of enabling each command like this, I was about to ask to include TI_COMMON_CMD_OPTIONS( defined inside board/ti/common/Kconfig) for omapl138. Realized that omapl138 is under "board/davinci/" and cannot include board/ti/common/Kconfig directly. May be I am missing some history here, why can't all davinci boards be under board/ti?
History is the answer here, yes. But is there really a reason davinci couldn't source board/ti/common/Kconfig ?
Nothing. Can be sourced easily just that it appears like a Kconfig from a different vendor is being included.
Then instead of this patch, ti/common Kconfig should be included and enable TI_COMMON_CMD_OPTIONS for omapl138.
Thanks and regards, Lokesh
On Wednesday 10 May 2017 04:56 PM, Tom Rini wrote:
On Wed, May 10, 2017 at 04:44:45PM +0530, Lokesh Vutla wrote:
On Wednesday 10 May 2017 04:27 PM, Sekhar Nori wrote:
Enable time command for OMAP-L138 LCDK board.
The patch was generated using savedefconfig method.
Signed-off-by: Sekhar Nori nsekhar@ti.com
Instead of enabling each command like this, I was about to ask to include TI_COMMON_CMD_OPTIONS( defined inside board/ti/common/Kconfig) for omapl138. Realized that omapl138 is under "board/davinci/" and cannot include board/ti/common/Kconfig directly. May be I am missing some history here, why can't all davinci boards be under board/ti?
History is the answer here, yes. But is there really a reason davinci couldn't source board/ti/common/Kconfig ?
No reason, I think. I will try and send a v2. I did notice TI_COMMON_CMD_OPTIONS before sending that patch, but dropped the idea again because it was in a different directory.
Thanks, Sekhar
On Wed, May 10, 2017 at 04:27:07PM +0530, Sekhar Nori wrote:
Enable time command for OMAP-L138 LCDK board.
The patch was generated using savedefconfig method.
Signed-off-by: Sekhar Nori nsekhar@ti.com
Reviewed-by: Tom Rini trini@konsulko.com
... but do you perhaps want to be setting TI_COMMON_CMD_OPTIONS on this board?
participants (3)
-
Lokesh Vutla -
Sekhar Nori -
Tom Rini