[U-Boot] [PATCH] m68k: Fix bug, "address of" operator was forgotten

in_be16() shall be passed a pointer to register and not its value. This is clearly a typo resulting in a wrong memory access, so fix it.
Cc: Alison Wang b18965@freescale.com, Jason Jin Jason.jin@freescale.com Signed-off-by: Vasili Galka vvv444@gmail.com --- arch/m68k/cpu/mcf5445x/speed.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/cpu/mcf5445x/speed.c b/arch/m68k/cpu/mcf5445x/speed.c index 07a9b35..4e363a4 100644 --- a/arch/m68k/cpu/mcf5445x/speed.c +++ b/arch/m68k/cpu/mcf5445x/speed.c @@ -115,7 +115,7 @@ void setup_5441x_clocks(void) gd->cpu_clk = vco / temp; /* cpu clock */ gd->arch.flb_clk = vco / temp; /* FlexBus clock */ gd->arch.flb_clk >>= 1; - if (in_be16(ccm->misccr2) & 2) /* fsys/4 */ + if (in_be16(&ccm->misccr2) & 2) /* fsys/4 */ gd->arch.flb_clk >>= 1;
temp = ((pdr & PLL_DR_OUTDIV2_BITS) >> 5) + 1;

On Mon, Jun 30, 2014 at 12:59:06PM +0300, Vasili Galka wrote:
in_be16() shall be passed a pointer to register and not its value. This is clearly a typo resulting in a wrong memory access, so fix it.
Cc: Alison Wang b18965@freescale.com, Jason Jin Jason.jin@freescale.com Signed-off-by: Vasili Galka vvv444@gmail.com
Applied to u-boot/master, thanks!
participants (2)
-
Tom Rini
-
Vasili Galka