[U-Boot] [PATCH v2] cmd: dfu: Add error handling for board_usb_init
board_usb_init() can failed and error should be handled properly.
Signed-off-by: Michal Simek michal.simek@xilinx.com ---
Changes in v2: - Fix type in return error value
common/dfu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/common/dfu.c b/common/dfu.c index 4c529f7c36f9..0e9f5f59c80a 100644 --- a/common/dfu.c +++ b/common/dfu.c @@ -24,7 +24,11 @@ int run_usb_dnl_gadget(int usbctrl_index, char *usb_dnl_gadget) bool dfu_reset = false; int ret, i = 0;
- board_usb_init(usbctrl_index, USB_INIT_DEVICE); + ret = board_usb_init(usbctrl_index, USB_INIT_DEVICE); + if (ret) { + error("board usb init failed\n"); + return CMD_RET_FAILURE; + } g_dnl_clear_detach(); ret = g_dnl_register(usb_dnl_gadget); if (ret) {
Hi Michal,
board_usb_init() can failed and error should be handled properly.
Signed-off-by: Michal Simek michal.simek@xilinx.com
Changes in v2:
- Fix type in return error value
common/dfu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/common/dfu.c b/common/dfu.c index 4c529f7c36f9..0e9f5f59c80a 100644 --- a/common/dfu.c +++ b/common/dfu.c @@ -24,7 +24,11 @@ int run_usb_dnl_gadget(int usbctrl_index, char *usb_dnl_gadget) bool dfu_reset = false; int ret, i = 0;
- board_usb_init(usbctrl_index, USB_INIT_DEVICE);
- ret = board_usb_init(usbctrl_index, USB_INIT_DEVICE);
- if (ret) {
error("board usb init failed\n");return CMD_RET_FAILURE;- } g_dnl_clear_detach(); ret = g_dnl_register(usb_dnl_gadget); if (ret) {
Acked-by: Lukasz Majewski l.majewski@samsung.com
Thanks for the patch.
Hello Michal,
Am 30.08.2016 um 15:32 schrieb Michal Simek:
board_usb_init() can failed and error should be handled properly.
Signed-off-by: Michal Simek michal.simek@xilinx.com
Changes in v2:
Fix type in return error value
common/dfu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Heiko Schocherhs@denx.de
bye, Heiko
diff --git a/common/dfu.c b/common/dfu.c index 4c529f7c36f9..0e9f5f59c80a 100644 --- a/common/dfu.c +++ b/common/dfu.c @@ -24,7 +24,11 @@ int run_usb_dnl_gadget(int usbctrl_index, char *usb_dnl_gadget) bool dfu_reset = false; int ret, i = 0;
- board_usb_init(usbctrl_index, USB_INIT_DEVICE);
- ret = board_usb_init(usbctrl_index, USB_INIT_DEVICE);
- if (ret) {
error("board usb init failed\n");return CMD_RET_FAILURE;- } g_dnl_clear_detach(); ret = g_dnl_register(usb_dnl_gadget); if (ret) {
participants (3)
-
Heiko Schocher -
Lukasz Majewski -
Michal Simek