[U-Boot-Users] PATCH cpu/at91rm9200/start.S

Hi there,
since enabling the "main oscillator" of Atmel's AT91RM9200 is very board specific and must not be done on some boards (which use external clock oscilators instead of crystals) I suggest
* Patch by Steven Scholz, 13 Dec 2004: Move code for AT91 "main oscillator" into board specific memsetup.S files

In message 41BD53FA.1010002@imc-berlin.de you wrote:
since enabling the "main oscillator" of Atmel's AT91RM9200 is very board specific and must not be done on some boards (which use external clock oscilators instead of crystals) I suggest
- Patch by Steven Scholz, 13 Dec 2004: Move code for AT91 "main oscillator" into board specific memsetup.S files
I reject this patch as it causes a duplication of the same code into several files. My understanding is that this code is poretty generic for all boards that use it; #undef'fing it for boards which don;t use it seems to be the better choice here.
Best regards,
Wolfgang Denk

Wolfgang Denk wrote:
In message 41BD53FA.1010002@imc-berlin.de you wrote:
since enabling the "main oscillator" of Atmel's AT91RM9200 is very board specific and must not be done on some boards (which use external clock oscilators instead of crystals) I suggest
- Patch by Steven Scholz, 13 Dec 2004: Move code for AT91 "main oscillator" into board specific memsetup.S files
I reject this patch as it causes a duplication of the same code into several files. My understanding is that this code is poretty generic for all boards that use it; #undef'fing it for boards which don;t use it seems to be the better choice here.
I did not start the duplication! memsetup.S for at91rm9200dk and cmc_pu2 look pretty much the same already! The clock setup for both boards is done in memsetup.S.
I thought about a CFG_USE_MAIN_OSCILLATOR. But since we want to move cpu/at91rm9200 to cpu/arm920t/at91rm9200 someday we realy should not put such board and SoC specific code into start.S.
I aggree that duplicating code is bad and a generic cpu/at91rm9200/clocks.S would be better. But why did you accept the other patch
* Update for AT91RM9200DK and CMC_PU2 boards: - Enable booting directly from flash
in the first place???
-- Steven Scholz

In message 41BD666D.7060207@imc-berlin.de you wrote:
I did not start the duplication! memsetup.S for at91rm9200dk and cmc_pu2 look pretty much the same already! The clock setup for both boards is done in memsetup.S.
I know :-(
I aggree that duplicating code is bad and a generic cpu/at91rm9200/clocks.S would be better. But why did you accept the other patch
- Update for AT91RM9200DK and CMC_PU2 boards:
- Enable booting directly from flash
in the first place???
Because it was needed to get a project running for a paying customer, and I didn't have enough time to clean it upo myself :-(
Best regards,
Wolfgang Denk

Wolfgang Denk wrote:
In message 41BD666D.7060207@imc-berlin.de you wrote:
I did not start the duplication! memsetup.S for at91rm9200dk and cmc_pu2 look pretty much the same already! The clock setup for both boards is done in memsetup.S.
I know :-(
So would you accept a patch that merges board/at91rm9200dk/memsetup.S and board/cmc_pu2/memsetup.s into a cpu/at91rm9200/lowlevel.S ?
Because it was needed to get a project running for a paying customer, and I didn't have enough time to clean it upo myself :-(
I guess it does not count if I tell you that I need the sent patch "get a project running for a paying customer" (a.k.a. my boss) ... ;-)
-- Steven

In message 41BD6B31.9000405@imc-berlin.de you wrote:
So would you accept a patch that merges board/at91rm9200dk/memsetup.S and board/cmc_pu2/memsetup.s into a cpu/at91rm9200/lowlevel.S ?
Sure.
Because it was needed to get a project running for a paying customer, and I didn't have enough time to clean it upo myself :-(
I guess it does not count if I tell you that I need the sent patch "get a project running for a paying customer" (a.k.a. my boss) ... ;-)
Not really - unless he starts paying me, too :-)
Best regards,
Wolfgang Denk

Wolfgang Denk wrote:
In message 41BD6B31.9000405@imc-berlin.de you wrote:
So would you accept a patch that merges board/at91rm9200dk/memsetup.S and board/cmc_pu2/memsetup.s into a cpu/at91rm9200/lowlevel.S ?
Sure.
Ok. Here we go:
* Patch by Steven Scholz, 13 Dec 2004: Remove duplicated code by merging memsetup.S files for at91rm9200 boards into one cpu/at91rm9200/lowlevel.S
-- Steven

In message 41BD8E08.2080502@imc-berlin.de you wrote:
- Patch by Steven Scholz, 13 Dec 2004: Remove duplicated code by merging memsetup.S files for at91rm9200 boards into one cpu/at91rm9200/lowlevel.S
Added, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Steven Scholz
-
Wolfgang Denk