My dear old Mr. 'mir-doch-egal',

I don't dare to remember your old times at your previous company ... I think it would be funny for other's to post some of Stefan's code here from his pre-Denx era. The comments would explose the list's size limit :-)

Yes, I will fix the issue below. Just a minute.

BTW, what about removing some lines when quoting such a huge patch.

On Wednesday 16 January 2008 12:19, Stefan Roese wrote:

On Wednesday 16 January 2008, Matthias Fuchs wrote:

...

Signed-off-by: Matthias Fuchs matthias.fuchs@esd-electronics.com

Still some comments below.

...

• if(dvi_init())

Space after "(" please.

...

• du440_post_errors++;
  

...

+int last_stage_init(void) +{

• int e, i;

Empty newline after variable declaration.

...

• /* everyting is ok: turn on POST-LED */

...

• int U;

Upper case variables? Please use something else here.

...

• oldbus = I2C_GET_BUS();

...

+{

• int U;

Again.

...

• */

Yes, please don't forget about this. Sounds interesting. :)

...

+int do_time(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])

You are welcome to do this before me.

Matthias