On 12:00 Thu 02 Jul , Marek Vasut wrote:

Dne Čt 2. července 2009 09:08:43 Anatolij Gustschin napsal(a):

...

Hi,

Marek Vasut wrote:

...

I'd like to get this patch in. It adds support for Palm Tungsten|C (a pxa255 based handheld device).

The patch is available here (it's not all that hacky anymore):

patches for inclusion must be sent to the list. The merge window for next release is open until Sun Jul 19, 2009. See also http://www.denx.de/wiki/U-Boot/Patches

Thanks, Anatolij

Patch is included in this mail. Do you also need S-O-B line?

From 983470aca6ab55c1f617af1f6a30ace81638eedb Mon Sep 17 00:00:00 2001 From: Marek Vasut marek.vasut@gmail.com Date: Tue, 9 Jun 2009 00:32:18 +0200 Subject: [PATCH] Hacky PalmTC support for uboot

---

Makefile | 3 + board/palmtc/Makefile | 54 ++++++ board/palmtc/config.mk | 3 + board/palmtc/lowlevel_init.S | 435 ++++++++++++++++++++++++++++++++++++++++++ board/palmtc/palmtc.c | 72 +++++++ board/palmtc/u-boot.lds | 56 ++++++ cpu/pxa/pxafb.c | 34 ++++ include/configs/palmtc.h | 238 +++++++++++++++++++++++ 8 files changed, 895 insertions(+), 0 deletions(-) create mode 100644 board/palmtc/Makefile create mode 100644 board/palmtc/config.mk create mode 100644 board/palmtc/lowlevel_init.S create mode 100644 board/palmtc/palmtc.c create mode 100644 board/palmtc/u-boot.lds create mode 100644 include/configs/palmtc.h

diff --git a/Makefile b/Makefile index 24e6410..3fdb1c9 100644 --- a/Makefile +++ b/Makefile @@ -3041,6 +3041,9 @@ scpu_config: unconfig pxa255_idp_config: unconfig @$(MKCONFIG) $(@:_config=) arm pxa pxa255_idp

+palmtc_config: unconfig

• @$(MKCONFIG) $(@:_config=) arm pxa palmtc

trizepsiv_config : unconfig @$(MKCONFIG) $(@:_config=) arm pxa trizepsiv

diff --git a/board/palmtc/Makefile b/board/palmtc/Makefile new file mode 100644 index 0000000..92e5288 --- /dev/null +++ b/board/palmtc/Makefile @@ -0,0 +1,54 @@

+# +# Copyright (C) 2009 +# Marek Vasut marek.vasut@gmail.com +# +# Heavily based on pxa255_idp platform +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +#

+include $(TOPDIR)/config.mk

+LIB = $(obj)lib$(BOARD).a

+COBJS := palmtc.o +SOBJS := lowlevel_init.o

+SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS))

+$(LIB): $(obj).depend $(OBJS) $(SOBJS)

• $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)

+clean:

• rm -f $(SOBJS) $(OBJS)

+distclean: clean

• rm -f $(LIB) core *.bak $(obj).depend

+#########################################################################

+# defines $(obj).depend target +include $(SRCTREE)/rules.mk

+sinclude $(obj).depend

+######################################################################### diff --git a/board/palmtc/config.mk b/board/palmtc/config.mk new file mode 100644 index 0000000..bcb42e7 --- /dev/null +++ b/board/palmtc/config.mk @@ -0,0 +1,3 @@ +#TEXT_BASE = 0xa1700000 +TEXT_BASE = 0xa1000000 +#TEXT_BASE = 0 diff --git a/board/palmtc/lowlevel_init.S b/board/palmtc/lowlevel_init.S new file mode 100644 index 0000000..325bfbd --- /dev/null +++ b/board/palmtc/lowlevel_init.S @@ -0,0 +1,435 @@ +/*

• • Most of this taken from Redboot hal_platform_setup.h with cleanup
• • NOTE: I haven't clean this up considerably, just enough to get it
• • running. See hal_platform_setup.h for the source. See
• • board/cradle/lowlevel_init.S for another PXA250 setup that is
• • much cleaner.
• • See file CREDITS for list of people who contributed to this
• • project.
• • This program is free software; you can redistribute it and/or
• • modify it under the terms of the GNU General Public License as
• • published by the Free Software Foundation; either version 2 of
• • the License, or (at your option) any later version.
• • This program is distributed in the hope that it will be useful,
• • but WITHOUT ANY WARRANTY; without even the implied warranty of
• • MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
• • GNU General Public License for more details.
• • You should have received a copy of the GNU General Public License
• • along with this program; if not, write to the Free Software
• • Foundation, Inc., 59 Temple Place, Suite 330, Boston,
• • MA 02111-1307 USA
• */

+#include <config.h> +#include <version.h> +#include <asm/arch/pxa-regs.h>

+DRAM_SIZE: .long CONFIG_SYS_DRAM_SIZE

+/* wait for coprocessor write complete */

• .macro CPWAIT reg
• mrc p15,0,\reg,c2,c0,0
• mov \reg,\reg
• sub pc,pc,#4
• .endm

+/* wait for clock to stabilize */

• .macro CLKWAIT

please lowercase and this style

.macro wait_clk ldr r3, =OSCR /* reset the OS Timer Count to zero */ mov r2, #0 str r2, [r3] ldr r4, =0x300 /* really 0x2E1 is about 200usec, * so 0x300 should be plenty */ 1: ldr r2, [r3] cmp r4, r2 bgt 1b .endm

and wait we have wait_timer macro

+/*

• • Memory setup
• */

+.globl lowlevel_init +lowlevel_init:

• /* save jump address */
• mov r10, lr
• /* Set up GPIO pins first ----------------------------------------- */
• ldr r0, =GPSR0
• ldr r1, =CONFIG_SYS_GPSR0_VAL
• str r1, [r0]

please write32

• ldr r0, =GPSR1
• ldr r1, =CONFIG_SYS_GPSR1_VAL
• str r1, [r0]

ditto

• ldr r0, =GPSR2
• ldr r1, =CONFIG_SYS_GPSR2_VAL
• str r1, [r0]

ditto etc...

• ldr r0, =GPCR0
• ldr r1, =CONFIG_SYS_GPCR0_VAL
• str r1, [r0]
• CLKWAIT

+

• /* disable all sdram banks */

+#ifndef CONFIG_BOOT_PALMOS

• bic r4, r4, #(MDCNFG_DE0|MDCNFG_DE1)

+#endif

why?

• bic r4, r4, #(MDCNFG_DE2|MDCNFG_DE3)

+endlowlevel_init:

no need please remove

• mov pc, r10

diff --git a/board/palmtc/palmtc.c b/board/palmtc/palmtc.c new file mode 100644 index 0000000..f865a96 --- /dev/null +++ b/board/palmtc/palmtc.c @@ -0,0 +1,72 @@ +/*

• • Copyright (C) 2009
• • Marek Vasut marek.vasut@gmail.com
• • Heavily based on pxa255_idp platform
• • See file CREDITS for list of people who contributed to this
• • project.
• • This program is free software; you can redistribute it and/or
• • modify it under the terms of the GNU General Public License as
• • published by the Free Software Foundation; either version 2 of
• • the License, or (at your option) any later version.
• • This program is distributed in the hope that it will be useful,
• • but WITHOUT ANY WARRANTY; without even the implied warranty of
• • MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
• • GNU General Public License for more details.
• • You should have received a copy of the GNU General Public License
• • along with this program; if not, write to the Free Software
• • Foundation, Inc., 59 Temple Place, Suite 330, Boston,
• • MA 02111-1307 USA
• */

+#include <common.h> +#include <command.h>

+DECLARE_GLOBAL_DATA_PTR;

+/*

• • Miscelaneous platform dependent initialisations
• */

+int board_init (void) +{

• /* memory and cpu-speed are setup before relocation */
• /* so we do _nothing_ here */
• /* arch number of Lubbock-Board */
• gd->bd->bi_arch_number = MACH_TYPE_PALMTC;
• /* Adress of boot parameters */
• gd->bd->bi_boot_params = 0xa0000100;

please this style RAM_BASE + 0x100;

• /* Set PWM for LCD */
• PWM_CTRL1 = 0x5f;
• PWM_PERVAL1 = 0x3ff;
• PWM_PWDUTY1 = 892;

please use proper acessor writex

• return 0;

+}

+int board_late_init(void) +{ +#ifdef CONFIG_LCD

• setenv("stdout", "lcd");
• setenv("stderr", "lcd");

+#else

• setenv("stdout", "serial");
• setenv("stderr", "serial");

+#endif

you can use iomux to have the both active at the sametime

• return 0;

+}

+int dram_init (void) +{

• gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
• gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
• return 0;

+} diff --git a/board/palmtc/u-boot.lds b/board/palmtc/u-boot.lds

no need please remove

diff --git a/cpu/pxa/pxafb.c b/cpu/pxa/pxafb.c

please do this in onther patch

index 97efcb6..8d86edf 100644 --- a/cpu/pxa/pxafb.c +++ b/cpu/pxa/pxafb.c @@ -147,6 +147,40 @@ vidinfo_t panel_info = { #endif /* CONFIG_HITACHI_SX14 */

/*----------------------------------------------------------------------*/ +#ifdef CONFIG_ACX517AKN

+# define LCD_BPP LCD_COLOR8 +# define LCD_INVERT_COLORS /* This looks more 1337 (or how do they call it) ;-) */

+/* you have to set lccr0 and lccr3 (including pcd) */ +# define REG_LCCR0 0x003008f9 +# define REG_LCCR3 0x03700006

+vidinfo_t panel_info = {

• vl_col: 320,
• vl_row: 320,
• vl_width: 320,
• vl_height: 320,
• vl_clkp: CONFIG_SYS_HIGH,
• vl_oep: CONFIG_SYS_LOW,
• vl_hsp: CONFIG_SYS_LOW,
• vl_vsp: CONFIG_SYS_LOW,
• vl_dp: CONFIG_SYS_HIGH,
• vl_bpix: LCD_BPP,
• vl_lbw: 0,
• vl_splt: 1,
• vl_clor: 1,
• vl_tft: 1,
• vl_hpw: 0x04,
• vl_blw: 0x1c,
• vl_elw: 0x08,
• vl_vpw: 0x01,
• vl_bfw: 0x07,
• vl_efw: 0x08,

+}; +#endif /* CONFIG_ACX517AKN */

+/*----------------------------------------------------------------------*/

#if LCD_BPP == LCD_COLOR8 void lcd_setcolreg (ushort regno, ushort red, ushort green, ushort blue); diff --git a/include/configs/palmtc.h b/include/configs/palmtc.h new file mode 100644 index 0000000..187a165 --- /dev/null +++ b/include/configs/palmtc.h @@ -0,0 +1,238 @@ +/*

• • Copyright (C) 2009
• • Marek Vasut marek.vasut@gmail.com
• • Configuration settings for Palm Tungsten|C
• • Heavily based on pxa255_idp platform
• • See file CREDITS for list of people who contributed to this
• • project.
• • This program is free software; you can redistribute it and/or
• • modify it under the terms of the GNU General Public License as
• • published by the Free Software Foundation; either version 2 of
• • the License, or (at your option) any later version.
• • This program is distributed in the hope that it will be useful,
• • but WITHOUT ANY WARRANTY; without even the implied warranty of
• • MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
• • GNU General Public License for more details.
• • You should have received a copy of the GNU General Public License
• • along with this program; if not, write to the Free Software
• • Foundation, Inc., 59 Temple Place, Suite 330, Boston,
• • MA 02111-1307 USA
• */

+#ifndef __CONFIG_H +#define __CONFIG_H

+#include <asm/arch/pxa-regs.h>

+/*

• • High Level Configuration Options
• • (easy to change)
• */

+#define CONFIG_PXA250 1 /* This is an PXA250 CPU */ +#define CONFIG_PALMTC 1 /* Palm Tungsten|C board */ +#define BOARD_LATE_INIT 1 +#define CONFIG_BOOT_PALMOS 1 /* Dont disable memory we are running from */ +#define CONFIG_SHOW_BOOT_PROGRESS 1 +#define CONFIG_MMC 1 /* Enable MMC card */ +#define CONFIG_LCD

+#ifdef CONFIG_LCD +#define CONFIG_ACX517AKN +#define CONFIG_VIDEO_LOGO +#endif

+#ifdef CONFIG_MMC +#define CONFIG_DOS_PARTITION +#define CONFIG_PXA_MMC +#define CONFIG_CMD_MMC +#define CONFIG_SYS_MMC_BASE 0xF0000000 +#endif

+#undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */

+/* we will never enable dcache, because we have to setup MMU first */ +#define CONFIG_SYS_NO_DCACHE

no need please remove

+/*

• • Size of malloc() pool
• */

+#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + CONFIG_STACKSIZE) +#define CONFIG_SYS_GBL_DATA_SIZE 512 /* size in bytes reserved for initial data */

+/*

• • select serial console configuration
• */

+#define CONFIG_FFUART 1 /* we use FFUART on PalmTC */

+/* allow to overwrite serial and ethaddr */ +#define CONFIG_ENV_OVERWRITE

+/* Default baudrate on FFUART */ +#define CONFIG_BAUDRATE 57600

why not 115200?

+/*

• • Command line configuration.
• */

+#include <config_cmd_default.h>

+#define CONFIG_CMD_FAT +#undef CONFIG_CMD_NET +#undef CONFIG_CMD_NFS +#undef CONFIG_CMD_BOOTD

+#define CONFIG_BOOTDELAY 1 +#define CONFIG_BOOTCOMMAND "mmc init || bootm 0x80000 ; echo "Booting uImage from mmc[0]:/uImage" ; fatload mmc 0 0xa3000000 uImage ; bootm 0xa3000000"

too long please fix

+#define CONFIG_BOOTARGS "root=/dev/mtdblock2 console=ttyS0,57600"

+#define CONFIG_CMDLINE_TAG 1 /* enable passing of ATAGs */ +#define CONFIG_SETUP_MEMORY_TAGS 1 +#define CONFIG_INITRD_TAG 1

+#if defined(CONFIG_CMD_KGDB) +#define CONFIG_KGDB_BAUDRATE 57600 /* speed to run kgdb serial port */ +#define CONFIG_KGDB_SER_INDEX 2 /* which serial port to use */ +#endif

are sure this work?

+/*

• • Miscellaneous configurable options
• */

+#define CONFIG_SYS_HUSH_PARSER 1 +#define CONFIG_SYS_PROMPT_HUSH_PS2 "> "

+#define CONFIG_SYS_LONGHELP /* undef to save memory */ +#ifdef CONFIG_SYS_HUSH_PARSER +#define CONFIG_SYS_PROMPT "$ " /* Monitor Command Prompt */ +#else +#define CONFIG_SYS_PROMPT "=> " /* Monitor Command Prompt */ +#endif

why different?

+#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16) /* Print Buffer Size */ +#define CONFIG_SYS_MAXARGS 16 /* max number of command args */ +#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size */ +#define CONFIG_SYS_DEVICE_NULLDEV 1

+#define CONFIG_SYS_MEMTEST_START 0xa0400000 /* memtest works on */ +#define CONFIG_SYS_MEMTEST_END 0xa0800000 /* 4 ... 8 MB in DRAM */

+#define CONFIG_SYS_LOAD_ADDR 0xa2000000 /* default load address */

+#define CONFIG_SYS_HZ 1000 +#define CONFIG_SYS_CPUSPEED 0x161 /* set core clock to 400/200/100 MHz */

+#define RTC 1 /* enable 32KHz osc */

please use CONFIG_ something

• 				/* valid baudrates */
  

+#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }

please near the default board rate define

+/*

• • Stack sizes
• • The stack sizes are set up in start.S using the settings below
• */

+#define CONFIG_STACKSIZE (128*1024) /* regular stack */

please add a space before and after '*'

+#ifdef CONFIG_USE_IRQ +#define CONFIG_STACKSIZE_IRQ (4*1024) /* IRQ stack */ +#define CONFIG_STACKSIZE_FIQ (4*1024) /* FIQ stack */ +#endif

+/*

• • Physical Memory Map
• */

+#define CONFIG_NR_DRAM_BANKS 1 /* we have 1 banks of DRAM */ +#define PHYS_SDRAM_1 0xa0000000 /* SDRAM Bank #1 */ +#define PHYS_SDRAM_1_SIZE 0x04000000 /* 64 MB */

+#define PHYS_FLASH_1 0x00000000 /* Flash Bank #1 */ +#define PHYS_FLASH_2 0x04000000 /* Flash Bank #2 */

why define 2 if you only use 1?

+#define PHYS_FLASH_SIZE 0x01000000 /* 16 MB */ +#define PHYS_FLASH_BANK_SIZE 0x01000000 /* 16 MB Banks */ +#define PHYS_FLASH_SECT_SIZE 0x00040000 /* 2*128 KB sectors (x16) */

+#define CONFIG_SYS_DRAM_BASE 0xa0000000 +#define CONFIG_SYS_DRAM_SIZE 0x04000000

+#define CONFIG_SYS_FLASH_BASE PHYS_FLASH_1

Best Regards, J.