[U-Boot] [patch] net: micrel: configure skew values for
This adds skew timing configuration for micrel ksz9021 configuration. With this patch, I can add
#define CONFIG_KSZ9021_CLK_SKEW_ENV "micrel-ksz9021-clk-skew" #define CONFIG_KSZ9021_CLK_SKEW_VAL 0xf0f0 #define CONFIG_KSZ9021_DATA_SKEW_ENV "micrel-ksz9021-data-skew" #define CONFIG_KSZ9021_DATA_SKEW_VAL 0x0
to my board's configuration file, and get working networking in u-boot.
Signed-off-by: Pavel Machek pavel@denx.de
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 507b9a3..7e4dbd6 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -117,12 +119,31 @@ static int ksz9021_config(struct phy_device *phydev) { unsigned ctrl1000 = 0; const unsigned master = CTRL1000_PREFER_MASTER | - CTRL1000_CONFIG_MASTER | CTRL1000_MANUAL_CONFIG; + CTRL1000_CONFIG_MASTER | CTRL1000_MANUAL_CONFIG; unsigned features = phydev->drv->features;
+ /* min rx data delay */ + if (ksz9021_phy_extended_write(phydev, + MII_KSZ9021_EXT_RGMII_RX_DATA_SKEW, + getenv_ulong(CONFIG_KSZ9021_DATA_SKEW_ENV, 16, + CONFIG_KSZ9021_DATA_SKEW_VAL)) < 0) + return -1; + /* min tx data delay */ + if (ksz9021_phy_extended_write(phydev, + MII_KSZ9021_EXT_RGMII_TX_DATA_SKEW, + getenv_ulong(CONFIG_KSZ9021_DATA_SKEW_ENV, 16, + CONFIG_KSZ9021_DATA_SKEW_VAL)) < 0) + return -1; + /* max rx/tx clock delay, min rx/tx control */ + if (ksz9021_phy_extended_write(phydev, + MII_KSZ9021_EXT_RGMII_CLOCK_SKEW, + getenv_ulong(CONFIG_KSZ9021_CLK_SKEW_ENV, 16, + CONFIG_KSZ9021_CLK_SKEW_VAL)) < 0) + return -1; + if (getenv("disable_giga")) features &= ~(SUPPORTED_1000baseT_Half | - SUPPORTED_1000baseT_Full); + SUPPORTED_1000baseT_Full); /* force master mode for 1000BaseT due to chip errata */ if (features & SUPPORTED_1000baseT_Half) ctrl1000 |= ADVERTISE_1000HALF | master;
On Saturday, October 25, 2014 at 01:27:52 PM, Pavel Machek wrote:
This adds skew timing configuration for micrel ksz9021 configuration. With this patch, I can add
#define CONFIG_KSZ9021_CLK_SKEW_ENV "micrel-ksz9021-clk-skew" #define CONFIG_KSZ9021_CLK_SKEW_VAL 0xf0f0 #define CONFIG_KSZ9021_DATA_SKEW_ENV "micrel-ksz9021-data-skew" #define CONFIG_KSZ9021_DATA_SKEW_VAL 0x0
to my board's configuration file, and get working networking in u-boot.
Signed-off-by: Pavel Machek pavel@denx.de
CC boundary devices guys, since they already have this on Nitrogen6x, but they placed the PHY tuning into the board file (which I think is more correct).
See the attachment, I think this might be a stab on what you want to do.
Also, I don't think it's necessary to explicitly define new ad-hoc env variables, actually I doubt there's any need for any env variables at all.
Best regards, Marek Vasut
On Saturday, October 25, 2014 at 01:27:52 PM, Pavel Machek wrote:
This adds skew timing configuration for micrel ksz9021 configuration. With this patch, I can add
#define CONFIG_KSZ9021_CLK_SKEW_ENV "micrel-ksz9021-clk-skew" #define CONFIG_KSZ9021_CLK_SKEW_VAL 0xf0f0 #define CONFIG_KSZ9021_DATA_SKEW_ENV "micrel-ksz9021-data-skew" #define CONFIG_KSZ9021_DATA_SKEW_VAL 0x0
to my board's configuration file, and get working networking in u-boot.
Signed-off-by: Pavel Machek pavel@denx.de
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 507b9a3..7e4dbd6 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -117,12 +119,31 @@ static int ksz9021_config(struct phy_device *phydev) { unsigned ctrl1000 = 0; const unsigned master = CTRL1000_PREFER_MASTER |
CTRL1000_CONFIG_MASTER | CTRL1000_MANUAL_CONFIG;
CTRL1000_CONFIG_MASTER | CTRL1000_MANUAL_CONFIG;unsigned features = phydev->drv->features;
/* min rx data delay */
if (ksz9021_phy_extended_write(phydev,
MII_KSZ9021_EXT_RGMII_RX_DATA_SKEW,
getenv_ulong(CONFIG_KSZ9021_DATA_SKEW_ENV, 16,
CONFIG_KSZ9021_DATA_SKEW_VAL)) < 0)
return -1;
You should probably get rid of the getenv altogether and just let the board define a static value in it's configuration (for now). In the long run, this configuration value should be passed via the platform data or DT.
The new CONFIG_* macros should be documented, otherwise the sheer amount of CONFIG_* in U-Boot will become impossible to manage. Speaking of CONFIG_*, given that there is no default value for any of the new CONFIG_* macros, the patch will break all boards using the Micrel PHY which do not define those macros explicitly.
On a final note, not all boards using the Micrel PHY need to override those registers, so this must also be solved in some way such that the behavior of this driver doesn't change for the boards which do not implement this override.
I am also curious if there will be more registers which would need such explicit override configuration option in the future or if these are all of them. I guess we cannot tell right now.
[...]
Best regards, Marek Vasut
participants (2)
-
Marek Vasut -
Pavel Machek