[U-Boot] [PATCH 1/2] ubifs: BUG realpath string must be ended with NULL
If the memory used to copy the link_make is "dirty" the string wont be ended with NULL, throwing out multiple memory bugs.
Signed-off-by: Ricardo Ribalda Delgado ricardo.ribalda@uam.es --- v3: s/ZERO/NULL/, s/=/ = / v2: better doc and remove duplicated memcpy
fs/ubifs/ubifs.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c index 32f9ff8..427d84a 100644 --- a/fs/ubifs/ubifs.c +++ b/fs/ubifs/ubifs.c @@ -641,6 +641,7 @@ int ubifs_load(char *filename, u32 addr, u32 size) ui = ubifs_inode(inode); if (((inode->i_mode & S_IFMT) == S_IFLNK) && ui->data_len) { memcpy(link_name, ui->data, ui->data_len); + link_name[ui->data_len] = '\0'; printf("%s is linked to %s!\n", filename, link_name); ubifs_iput(inode);
On Monday 27 April 2009, Ricardo Ribalda Delgado wrote:
If the memory used to copy the link_make is "dirty" the string wont be ended with NULL, throwing out multiple memory bugs.
Signed-off-by: Ricardo Ribalda Delgado ricardo.ribalda@uam.es
Acked-by: Stefan Roese sr@denx.de
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
Dear Ricardo Ribalda Delgado,
In message 1240816411-16585-1-git-send-email-ricardo.ribalda@uam.es you wrote:
If the memory used to copy the link_make is "dirty" the string wont be ended with NULL, throwing out multiple memory bugs.
Signed-off-by: Ricardo Ribalda Delgado ricardo.ribalda@uam.es
v3: s/ZERO/NULL/, s/=/ = / v2: better doc and remove duplicated memcpy
Applied, thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Ricardo Ribalda Delgado -
Stefan Roese -
Wolfgang Denk