On 05.09.18 22:21, Heinrich Schuchardt wrote:

Hello Alex,

in your efi-next tree you have merged efi_loader: SIMPLE_TEXT_INPUT_EX plus wire up objects properly https://github.com/agraf/u-boot/commit/3486573794a0809d987fd690b1bf6c9093124...

Sure, removed again.

The EFI_SIMPLE_TEXT_INPUT_PROTOCOL can be tested with:

setenv efi_selftest text input bootefi selftest

Before the patch entering CTRL+C resulted in:

Executing 'text input' Waiting for your input To terminate type 'x'

Unicode char 3 (unknown), scan code 0 (Null)

With this patch CTRC+C is not interpreted as 0x03 anymore.

So, please, remove the patch from the repository, rework it and subject it to review.

No promises on the rework anytime soon :)

I will try to write a Python test for EFI_SIMPLE_TEXT_INPUT_PROTOCOL so that we do not miss the problem again.

Thanks!

Alex

We need testing for the EFISIMPLE_TEXT_INPUT_EX_PROTOCOL too.

Best regards

Heinrich