[U-Boot] [PATCH 3/3] cmd: add missing line breaks for pr_err()

After the commit 9b643e312d52 ("treewide: replace with error() with pr_err()"), there are some pr_err() with no line break. Add missing line breaks.
Signed-off-by: Seung-Woo Kim sw0312.kim@samsung.com --- cmd/fastboot.c | 2 +- cmd/regulator.c | 2 +- cmd/thordown.c | 6 +++--- cmd/usb_mass_storage.c | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/cmd/fastboot.c b/cmd/fastboot.c index 557257a..e6ae057 100644 --- a/cmd/fastboot.c +++ b/cmd/fastboot.c @@ -48,7 +48,7 @@ static int do_fastboot_usb(int argc, char *const argv[],
ret = board_usb_init(controller_index, USB_INIT_DEVICE); if (ret) { - pr_err("USB init failed: %d", ret); + pr_err("USB init failed: %d\n", ret); return CMD_RET_FAILURE; }
diff --git a/cmd/regulator.c b/cmd/regulator.c index 89461b6..ed8d778 100644 --- a/cmd/regulator.c +++ b/cmd/regulator.c @@ -70,7 +70,7 @@ static int curr_dev_and_platdata(struct udevice **devp,
*uc_pdata = dev_get_uclass_platdata(*devp); if (!*uc_pdata) { - pr_err("Regulator: %s - missing platform data!", currdev->name); + pr_err("Regulator: %s - missing platform data!\n", currdev->name); return CMD_RET_FAILURE; }
diff --git a/cmd/thordown.c b/cmd/thordown.c index e297de2..2615ada 100644 --- a/cmd/thordown.c +++ b/cmd/thordown.c @@ -32,7 +32,7 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int controller_index = simple_strtoul(usb_controller, NULL, 0); ret = board_usb_init(controller_index, USB_INIT_DEVICE); if (ret) { - pr_err("USB init failed: %d", ret); + pr_err("USB init failed: %d\n", ret); ret = CMD_RET_FAILURE; goto exit; } @@ -41,14 +41,14 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
ret = thor_init(); if (ret) { - pr_err("THOR DOWNLOAD failed: %d", ret); + pr_err("THOR DOWNLOAD failed: %d\n", ret); ret = CMD_RET_FAILURE; goto exit; }
ret = thor_handle(); if (ret) { - pr_err("THOR failed: %d", ret); + pr_err("THOR failed: %d\n", ret); ret = CMD_RET_FAILURE; goto exit; } diff --git a/cmd/usb_mass_storage.c b/cmd/usb_mass_storage.c index 89b9ddf..0d55114 100644 --- a/cmd/usb_mass_storage.c +++ b/cmd/usb_mass_storage.c @@ -161,21 +161,21 @@ static int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag, controller_index = (unsigned int)(simple_strtoul( usb_controller, NULL, 0)); if (board_usb_init(controller_index, USB_INIT_DEVICE)) { - pr_err("Couldn't init USB controller."); + pr_err("Couldn't init USB controller.\n"); rc = CMD_RET_FAILURE; goto cleanup_ums_init; }
rc = fsg_init(ums, ums_count); if (rc) { - pr_err("fsg_init failed"); + pr_err("fsg_init failed\n"); rc = CMD_RET_FAILURE; goto cleanup_board; }
rc = g_dnl_register("usb_dnl_ums"); if (rc) { - pr_err("g_dnl_register failed"); + pr_err("g_dnl_register failed\n"); rc = CMD_RET_FAILURE; goto cleanup_board; }

On 3 June 2018 at 23:04, Seung-Woo Kim sw0312.kim@samsung.com wrote:
After the commit 9b643e312d52 ("treewide: replace with error() with pr_err()"), there are some pr_err() with no line break. Add missing line breaks.
Signed-off-by: Seung-Woo Kim sw0312.kim@samsung.com
cmd/fastboot.c | 2 +- cmd/regulator.c | 2 +- cmd/thordown.c | 6 +++--- cmd/usb_mass_storage.c | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org

On Mon, Jun 04, 2018 at 04:04:51PM +0900, Seung-Woo Kim wrote:
After the commit 9b643e312d52 ("treewide: replace with error() with pr_err()"), there are some pr_err() with no line break. Add missing line breaks.
Signed-off-by: Seung-Woo Kim sw0312.kim@samsung.com
Applied to u-boot/master, thanks!
participants (3)
-
Seung-Woo Kim
-
Simon Glass
-
Tom Rini