[U-Boot-Users] [PATCH 6/6] ATSTK1000 and ATSTK1002 board support
The attached patch adds support for the ATSTK1000 development board and the ATSTK1002 CPU daughterboard for AT32AP7000. Please see the patch header for details.
CHANGELOG: Add support for the ATSTK1000 development board
Haavard
On Wed, 6 Sep 2006 16:25:25 +0200 Haavard Skinnemoen hskinnemoen@atmel.com wrote:
The attached patch adds support for the ATSTK1000 development board and the ATSTK1002 CPU daughterboard for AT32AP7000. Please see the patch header for details.
This patch is exactly the same as the previous patch I submitted, except that it adds the ATSTK1000 board-specific directory under boards/atmel instead of under boards, as suggested by Stefan Roese.
Please let me know if there are more changes you want me to make before it's acceptable for mainline.
CHANGELOG: Add support for the ATSTK1000 development board
Haavard
In message 20060912145748.1fc3bed4@cad-250-152.norway.atmel.com you wrote:
This patch is exactly the same as the previous patch I submitted, except that it adds the ATSTK1000 board-specific directory under boards/atmel instead of under boards, as suggested by Stefan Roese.
Please let me know if there are more changes you want me to make before it's acceptable for mainline.
CHANGELOG: Add support for the ATSTK1000 development board
Added, except for the top level makefile changes, which again included board specific build rules which must be moved into the board's Makefile.
Thanks.
Best regards,
Wolfgang Denk
In message 20060906162525.3aac817f@cad-250-152.norway.atmel.com you wrote:
The attached patch adds support for the ATSTK1000 development board and the ATSTK1002 CPU daughterboard for AT32AP7000. Please see the patch header for details.
CHANGELOG: Add support for the ATSTK1000 development board
Mostly added, thanks.
I omitted the folowing parts of your patch:
Index: u-boot-1.1.4-git/Makefile =================================================================== --- u-boot-1.1.4-git.orig/Makefile 2006-09-06 15:32:47.000000000 +0200 +++ u-boot-1.1.4-git/Makefile 2006-09-06 15:35:26.000000000 +0200 @@ -2060,6 +2060,13 @@ pb1000_config : unconfig ## AT32AP7xxx #########################################################################
+atstk1002_config : unconfig + @./mkconfig $(@:_config=) avr32 at32ap atstk1000 NULL at32ap7000 + +$(obj)board/atstk1000/u-boot.lds: board/atstk1000/u-boot.lds.S \ + $(obj)include/config.h + $(CPP) $(AFLAGS) -P -o $@ $< +
Please don't put "board" specific build rules in the top level Makefile. These belong into the board directory's makefile.
[Please submit a new, incremental patch against current top of tree in git repo.]
Thanks.
Best regards,
Wolfgang Denk
On Tue, 24 Oct 2006 14:59:52 +0200 Wolfgang Denk wd@denx.de wrote:
+$(obj)board/atstk1000/u-boot.lds: board/atstk1000/u-boot.lds.S \
$(obj)include/config.h- $(CPP) $(AFLAGS) -P -o $@ $<
Please don't put "board" specific build rules in the top level Makefile. These belong into the board directory's makefile.
Hmm...I can't quite remember the reason for doing this. I think it was that the board's config.mk was included before the default rule, so it would override it.
I'll see if I can figure out some other solution.
[Please submit a new, incremental patch against current top of tree in git repo.]
Will do. Thanks for applying my patches :-)
Btw, did you apply this one _and_ the other STK1000 patch? I only intended you to merge one of them (preferably the other one since it adds the atstk1000 directory under boards/atmel, as suggested by Stefan.)
Haavard
Hello,
in message 20061024152048.53ecf200@cad-250-152.norway.atmel.com you wrote:
Please don't put "board" specific build rules in the top level Makefile. These belong into the board directory's makefile.
Hmm...I can't quite remember the reason for doing this. I think it was that the board's config.mk was included before the default rule, so it would override it.
I'll see if I can figure out some other solution.
Thanks.
Will do. Thanks for applying my patches :-)
You are welcome. Sorry it took so long.
Btw, did you apply this one _and_ the other STK1000 patch? I only intended you to merge one of them (preferably the other one since it adds the atstk1000 directory under boards/atmel, as suggested by Stefan.)
I intended to apply the second patch only, but squeezed between a long row of phonecalls I thought I'd be missing a patch from your sequence and applied this one, too - which was wrong. Mea culpa.
Best regards,
Wolfgang Denk
participants (2)
-
Haavard Skinnemoen -
Wolfgang Denk