[U-Boot] [PATCH] apalis_imx6: fix set_emmcargs wrapper
From: Igor Opaniuk igor.opaniuk@toradex.com
Fix set_emmcargs wrapper, which prepares proper bootargs for booting from eMMC.
Signed-off-by: Igor Opaniuk igor.opaniuk@toradex.com --- include/configs/apalis_imx6.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h index 4b0a3fb26b..cffb90a690 100644 --- a/include/configs/apalis_imx6.h +++ b/include/configs/apalis_imx6.h @@ -121,8 +121,8 @@ "imx6q-apalis-cam-eval.dtb fat 0 1"
#define EMMC_BOOTCMD \ - "set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \ - "rootfstype=ext4 rootwait\0" \ + "set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \ + "ro,noatime rootfstype=ext4 rootwait\0" \ "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \ "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \ "${vidargs}; echo Booting from internal eMMC chip...; " \
On Tue, 2019-06-25 at 14:48 +0300, Igor Opaniuk wrote:
From: Igor Opaniuk igor.opaniuk@toradex.com
Fix set_emmcargs wrapper, which prepares proper bootargs for booting from eMMC.
Signed-off-by: Igor Opaniuk igor.opaniuk@toradex.com
Reviewed-by: Philippe Schenker philippe.schenker@toradex.com
include/configs/apalis_imx6.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h index 4b0a3fb26b..cffb90a690 100644 --- a/include/configs/apalis_imx6.h +++ b/include/configs/apalis_imx6.h @@ -121,8 +121,8 @@ "imx6q-apalis-cam-eval.dtb fat 0 1"
#define EMMC_BOOTCMD \
- "set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \
"rootfstype=ext4 rootwait\0" \
- "set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \
"ro,noatime rootfstype=ext4 rootwait\0" \
Hi Stefano,
On Wed, Jun 26, 2019 at 10:37 AM Philippe Schenker dev@pschenker.ch wrote:
On Tue, 2019-06-25 at 14:48 +0300, Igor Opaniuk wrote:
From: Igor Opaniuk igor.opaniuk@toradex.com
Fix set_emmcargs wrapper, which prepares proper bootargs for booting from eMMC.
Signed-off-by: Igor Opaniuk igor.opaniuk@toradex.com
Reviewed-by: Philippe Schenker philippe.schenker@toradex.com
include/configs/apalis_imx6.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h index 4b0a3fb26b..cffb90a690 100644 --- a/include/configs/apalis_imx6.h +++ b/include/configs/apalis_imx6.h @@ -121,8 +121,8 @@ "imx6q-apalis-cam-eval.dtb fat 0 1"
#define EMMC_BOOTCMD \
"set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \"rootfstype=ext4 rootwait\0" \
"set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \"ro,noatime rootfstype=ext4 rootwait\0" \ "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \ "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \ "${vidargs}; echo Booting from internal eMMC chip...; " \
This is a bug fix, currently boot on Apalis iMX6 is broken. could you please apply this patch so it's included in v2019.07 release?
Thanks!
Hi Igor,
On 27/06/19 11:26, Igor Opaniuk wrote:
Hi Stefano,
On Wed, Jun 26, 2019 at 10:37 AM Philippe Schenker dev@pschenker.ch wrote:
On Tue, 2019-06-25 at 14:48 +0300, Igor Opaniuk wrote:
From: Igor Opaniuk igor.opaniuk@toradex.com
Fix set_emmcargs wrapper, which prepares proper bootargs for booting from eMMC.
Signed-off-by: Igor Opaniuk igor.opaniuk@toradex.com
Reviewed-by: Philippe Schenker philippe.schenker@toradex.com
include/configs/apalis_imx6.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h index 4b0a3fb26b..cffb90a690 100644 --- a/include/configs/apalis_imx6.h +++ b/include/configs/apalis_imx6.h @@ -121,8 +121,8 @@ "imx6q-apalis-cam-eval.dtb fat 0 1"
#define EMMC_BOOTCMD \
"set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \"rootfstype=ext4 rootwait\0" \
"set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \"ro,noatime rootfstype=ext4 rootwait\0" \ "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \ "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \ "${vidargs}; echo Booting from internal eMMC chip...; " \This is a bug fix, currently boot on Apalis iMX6 is broken. could you please apply this patch so it's included in v2019.07 release?
I pick it up, I am sorting which fixes I should take for release. Thanks !
Best regards, Stefano
participants (3)
-
Igor Opaniuk -
Philippe Schenker -
Stefano Babic