Re: [U-Boot] [PATCH] imx: sys_proto: Fixing function imx6_is_bmode_from_gpr9()
From: Stefano Babic sbabic@denx.de Sent: Tuesday 5th November 2019 17:26
On 05/11/19 17:05, Anatolij Gustschin wrote:
Hi Stefano, Christoph,
On Tue, 5 Nov 2019 16:57:18 +0100 Stefano Babic sbabic@denx.de wrote: ...
-static inline u8 imx6_is_bmode_from_gpr9(void) +static inline u32 imx6_is_bmode_from_gpr9(void) { return readl(&src_base->gpr10) & IMX6_SRC_GPR10_BMODE; }
This is correct but it rather conflicts with another patch I already applied. Could you rebase and repost ? Thanks !
This function was removed by Claudius (see commit ID e01c8cfe5769)
Yes, but this check just one bit.
since there are no users any more.
Oh yes, you're right !
No need to rebase/repost.
OK, the commit from Claudius solves my problem and my patch is therefore outdated. It's funny that the useless function has been around for more than two years and now we're both trying to fix it at almost the same time ;-)
Regards, Christoph
On 07/11/19 11:16, Christoph Niedermaier wrote:
From: Stefano Babic sbabic@denx.de Sent: Tuesday 5th November 2019 17:26
On 05/11/19 17:05, Anatolij Gustschin wrote:
Hi Stefano, Christoph,
On Tue, 5 Nov 2019 16:57:18 +0100 Stefano Babic sbabic@denx.de wrote: ...
-static inline u8 imx6_is_bmode_from_gpr9(void) +static inline u32 imx6_is_bmode_from_gpr9(void) { return readl(&src_base->gpr10) & IMX6_SRC_GPR10_BMODE; }
This is correct but it rather conflicts with another patch I already applied. Could you rebase and repost ? Thanks !
This function was removed by Claudius (see commit ID e01c8cfe5769)
Yes, but this check just one bit.
since there are no users any more.
Oh yes, you're right !
No need to rebase/repost.
OK, the commit from Claudius solves my problem and my patch is therefore outdated. It's funny that the useless function has been around for more than two years and now we're both trying to fix it at almost the same time ;-)
It is a common path: nothing for years or all together. It happens many times ;-)
Regards, Stefano
participants (2)
-
Christoph Niedermaier -
Stefano Babic