[PATCH 1/1] net: remove duplicate definition of ip_to_string()
ip_to_string() was added to net-common.h but not removed from net-legacy.h in commit 9063dba2d326 ("net: net_utils: Move ip_to_string to lib/net_utils.c").
Fixes: 9063dba2d326 ("net: net_utils: Move ip_to_string to lib/net_utils.c") Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com --- include/net-legacy.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/net-legacy.h b/include/net-legacy.h index ca1efd17af7..5a431fc6b16 100644 --- a/include/net-legacy.h +++ b/include/net-legacy.h @@ -502,9 +502,6 @@ static inline void net_copy_u32(void *to, void *from) memcpy((void *)to, (void *)from, sizeof(u32)); }
-/* Convert an IP address to a string */ -void ip_to_string(struct in_addr x, char *s); - /** * string_to_ip() - Convert a string to ip address *
On Mon, 25 Nov 2024 at 17:09, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:
ip_to_string() was added to net-common.h but not removed from net-legacy.h in commit 9063dba2d326 ("net: net_utils: Move ip_to_string to lib/net_utils.c").
Fixes: 9063dba2d326 ("net: net_utils: Move ip_to_string to lib/net_utils.c") Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
include/net-legacy.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/net-legacy.h b/include/net-legacy.h index ca1efd17af7..5a431fc6b16 100644 --- a/include/net-legacy.h +++ b/include/net-legacy.h @@ -502,9 +502,6 @@ static inline void net_copy_u32(void *to, void *from) memcpy((void *)to, (void *)from, sizeof(u32)); }
-/* Convert an IP address to a string */ -void ip_to_string(struct in_addr x, char *s);
/**
- string_to_ip() - Convert a string to ip address
-- 2.45.2
Reviewed-by: Ilias Apalodimas ilias.apalodimas@linaro.org
On Mon, Nov 25, 2024 at 04:08:34PM +0100, Heinrich Schuchardt wrote:
ip_to_string() was added to net-common.h but not removed from net-legacy.h in commit 9063dba2d326 ("net: net_utils: Move ip_to_string to lib/net_utils.c").
Fixes: 9063dba2d326 ("net: net_utils: Move ip_to_string to lib/net_utils.c") Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
include/net-legacy.h | 3 --- 1 file changed, 3 deletions(-)
This leads to: /home/uboot/u-boot/u-boot/cmd/net.c: In function 'netboot_update_env': /home/uboot/u-boot/u-boot/cmd/net.c:214:17: warning: implicit declaration of function 'ip_to_string'; did you mean 'vlan_to_string'? [-Wimplicit-function-declaration] 214 | ip_to_string(net_gateway, tmp); | ^~~~~~~~~~~~ | vlan_to_string
participants (3)
-
Heinrich Schuchardt -
Ilias Apalodimas -
Tom Rini