Following LVDS features might be supported (according to BSP), but are unimplemented due to lack of proper hardware: - dual channel LVDS - choosing between NS or JEIDA mode - cross-polarity support

Add at least some comments about them.

Signed-off-by: Priit Laes plaes@plaes.org --- drivers/video/sunxi_display.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)

diff --git a/drivers/video/sunxi_display.c b/drivers/video/sunxi_display.c index 6f8ee01..bcd33dd 100644 --- a/drivers/video/sunxi_display.c +++ b/drivers/video/sunxi_display.c @@ -829,8 +829,20 @@ static void sunxi_lcdc_tcon0_mode_set(const struct ctfb_res_modes *mode, #endif #ifdef CONFIG_VIDEO_LCD_IF_LVDS val = (sunxi_display.depth == 18) ? 1 : 0; + /* + * TODO: LVDS features (from BSP, no hardware): + * BIT(30) - LVDS single/dual channel (single - 0, dual - 1) + * BIT(29) - 0 + * BIT(28) - 0 + * BIT(27) - LVDS mode (NS - 0, JEIDA - 1) + * BIT(23) - 0 + */ writel(SUNXI_LCDC_TCON0_LVDS_INTF_BITWIDTH(val) | SUNXI_LCDC_TCON0_LVDS_CLK_SEL_TCON0, &lcdc->tcon0_lvds_intf); + /* + * TODO: LVDS cross-polarity support (from BSP, no hardware): + * set bits (0x1f << 21) | (0x1f << 5) for lvds_ana1 register + */ #endif

if (sunxi_display.depth == 18 || sunxi_display.depth == 16) {