[U-Boot] [PATCH] dm: bcm6345_gpio: Set proper output level in bcm6345_gpio_direction_output
Current code does not set output level in bcm6345_gpio_direction_output, fix it.
Signed-off-by: Axel Lin axel.lin@ingics.com --- drivers/gpio/bcm6345_gpio.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/bcm6345_gpio.c b/drivers/gpio/bcm6345_gpio.c index 009e2fc..b9100cd 100644 --- a/drivers/gpio/bcm6345_gpio.c +++ b/drivers/gpio/bcm6345_gpio.c @@ -64,6 +64,8 @@ static int bcm6345_gpio_direction_output(struct udevice *dev, unsigned offset, { struct bcm6345_gpio_priv *priv = dev_get_priv(dev);
+ bcm6345_gpio_set_value(dev, offset, value); + return bcm6345_gpio_set_direction(priv->reg_dirout, offset, 0); }
On Thu, Jun 08, 2017 at 05:20:12PM +0800, Axel Lin wrote:
Current code does not set output level in bcm6345_gpio_direction_output, fix it.
Signed-off-by: Axel Lin axel.lin@ingics.com
Reviewed-by: Tom Rini trini@konsulko.com
On 8 June 2017 at 03:20, Axel Lin axel.lin@ingics.com wrote:
Current code does not set output level in bcm6345_gpio_direction_output, fix it.
Signed-off-by: Axel Lin axel.lin@ingics.com
drivers/gpio/bcm6345_gpio.c | 2 ++ 1 file changed, 2 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org
Thanks for finding this Axel!
Reviewed-by: Álvaro Fernández Rojas noltari@gmail.com
El 08/06/2017 a las 11:20, Axel Lin escribió:
Current code does not set output level in bcm6345_gpio_direction_output, fix it.
Signed-off-by: Axel Lin axel.lin@ingics.com
drivers/gpio/bcm6345_gpio.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/bcm6345_gpio.c b/drivers/gpio/bcm6345_gpio.c index 009e2fc..b9100cd 100644 --- a/drivers/gpio/bcm6345_gpio.c +++ b/drivers/gpio/bcm6345_gpio.c @@ -64,6 +64,8 @@ static int bcm6345_gpio_direction_output(struct udevice *dev, unsigned offset, { struct bcm6345_gpio_priv *priv = dev_get_priv(dev);
- bcm6345_gpio_set_value(dev, offset, value);
- return bcm6345_gpio_set_direction(priv->reg_dirout, offset, 0);
}
participants (4)
-
Axel Lin -
Simon Glass -
Tom Rini -
Álvaro Fernández Rojas