[U-Boot] Possible mistake in the csu_cslx_ind enum (ns_access.h)
Hi, I started to port my kernel to the secure world on a LS1021a board, so I started to read the reference manual on the CSU component. In Table 9.8, we can see that
- Debug EPU is CSL47[24:16] - DDDI is CSL48[24:16] - Debug GDI is CSL48[8:0]
but in ns_access.h the order doesn't seem to fit. If I understand correctly:
- CSU_CSLX_EPU and CSU_CSLX_COP_DCSR should be exchanged - CSU_CSLX_DDI and CSU_CSLX_GDI should be exchanged - CSU_CSLX_USB3_PHY should be = 116, not 117
I don't have any Errata yet, and I might be wrong, so I'd rather have a confirmation.
By the way, there are a lot of 'Reserved' entry that have a name (like CSU_CSLX_GIC for example), am I lacking some information ?
Best regards, Vincent
On 03/24/2016 01:17 AM, Vincent wrote:
Hi, I started to port my kernel to the secure world on a LS1021a board, so I started to read the reference manual on the CSU component. In Table 9.8, we can see that
- Debug EPU is CSL47[24:16]
- DDDI is CSL48[24:16]
- Debug GDI is CSL48[8:0]
but in ns_access.h the order doesn't seem to fit. If I understand correctly:
- CSU_CSLX_EPU and CSU_CSLX_COP_DCSR should be exchanged
- CSU_CSLX_DDI and CSU_CSLX_GDI should be exchanged
- CSU_CSLX_USB3_PHY should be = 116, not 117
I don't have any Errata yet, and I might be wrong, so I'd rather have a confirmation.
By the way, there are a lot of 'Reserved' entry that have a name (like CSU_CSLX_GIC for example), am I lacking some information ?
Vincent,
I can't explain. It doesn't match the document I have.
Alison/Mingkai,
Can you comment?
York
Hi, Vincent,
On 03/24/2016 01:17 AM, Vincent wrote:
Hi, I started to port my kernel to the secure world on a LS1021a board, so I started to read the reference manual on the CSU component. In Table 9.8, we can see that
- Debug EPU is CSL47[24:16]
- DDDI is CSL48[24:16]
- Debug GDI is CSL48[8:0]
but in ns_access.h the order doesn't seem to fit. If I understand
correctly:
- CSU_CSLX_EPU and CSU_CSLX_COP_DCSR should be exchanged
- CSU_CSLX_DDI and CSU_CSLX_GDI should be exchanged
- CSU_CSLX_USB3_PHY should be = 116, not 117
[Alison Wang] Yes, you are right. These modifications should be done for LS1021A. Please send a patch to fix them.
I don't have any Errata yet, and I might be wrong, so I'd rather have a confirmation.
By the way, there are a lot of 'Reserved' entry that have a name (like CSU_CSLX_GIC for example), am I lacking some information ?
[Alison Wang] I am not sure how the author gets the information. Anyway, I will try to find some docs about it.
Best Regards, Alison Wang
participants (3)
-
Huan Wang -
Vincent -
york sun