On Tue, Jul 26, 2011 at 20:14, Kumar Gala wrote:

With the following commit:

commit d2e8b911c0a0661d395ccac72156040702ac842d Author: Mike Frysinger vapier@gentoo.org Date:   Wed Jun 29 11:58:04 2011 +0000

panic: add noreturn attribute

we now get warnings like the following if we build MPC8540ADS_config:

vsprintf.c: In function 'panic': vsprintf.c:730:1: warning: 'noreturn' function does return

Seems like do_reset() needs a similar attribute?  Or some other change?

adding noreturn to do_reset() would be the way to go imo. i'm not sure if the common helpers would prevent this ?

i'm traveling atm and wont be able to test for a while ... -mike