[U-Boot] [PATCH 1/2] mx6sabresd: Return error if cpu_eth_init() fails

From: Fabio Estevam fabio.estevam@freescale.com
Currently board_eth_init() always return 0, but we should propagate the error when cpu_eth_init() fails.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/freescale/mx6sabresd/mx6sabresd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c index c832bd9..425f734 100644 --- a/board/freescale/mx6sabresd/mx6sabresd.c +++ b/board/freescale/mx6sabresd/mx6sabresd.c @@ -421,7 +421,7 @@ int board_eth_init(bd_t *bis) if (ret) printf("FEC MXC: %s:failed\n", __func__);
- return 0; + return ret; }
int board_early_init_f(void)

From: Fabio Estevam fabio.estevam@freescale.com
Currently board_eth_init() always return 0, but we should propagate the error when cpu_eth_init() fails.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/freescale/mx6qsabreauto/mx6qsabreauto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c b/board/freescale/mx6qsabreauto/mx6qsabreauto.c index 1cdf2cb..c55ee87 100644 --- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c +++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c @@ -200,7 +200,7 @@ int board_eth_init(bd_t *bis) if (ret) printf("FEC MXC: %s:failed\n", __func__);
- return 0; + return ret; }
#define BOARD_REV_B 0x200

On 13/09/2013 03:03, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Currently board_eth_init() always return 0, but we should propagate the error when cpu_eth_init() fails.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks!
Best regards, Stefano Babic

On 13/09/2013 03:03, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Currently board_eth_init() always return 0, but we should propagate the error when cpu_eth_init() fails.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks!
Best regards, Stefano Babic
participants (2)
-
Fabio Estevam
-
Stefano Babic