[U-Boot] [PATCH] tools: imagetool: Remove "INSERT BEFORE" from linker script
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error: HOSTLD tools/mkenvimage /usr/bin/ld: error: ./tools/imagetool.lds:23:8: syntax error, unexpected STRING /usr/bin/ld: fatal error: unable to parse script file ./tools/imagetool.lds collect2: error: ld returned 1 exit status make[1]: *** [tools/mkenvimage] Error 1 make: *** [tools] Error 2
The problem has already been reported, but no evident solution has been proposed: https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5
Signed-off-by: Lukasz Majewski l.majewski@samsung.com --- tools/imagetool.lds | 2 -- 1 file changed, 2 deletions(-)
diff --git a/tools/imagetool.lds b/tools/imagetool.lds index 7e92b4a..4fa996a 100644 --- a/tools/imagetool.lds +++ b/tools/imagetool.lds @@ -20,5 +20,3 @@ SECTIONS
__bss_start = .; } - -INSERT BEFORE .data;
On Mon, Feb 16, 2015 at 03:05:45PM +0100, Lukasz Majewski wrote:
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error: HOSTLD tools/mkenvimage /usr/bin/ld: error: ./tools/imagetool.lds:23:8: syntax error, unexpected STRING /usr/bin/ld: fatal error: unable to parse script file ./tools/imagetool.lds collect2: error: ld returned 1 exit status make[1]: *** [tools/mkenvimage] Error 1 make: *** [tools] Error 2
The problem has already been reported, but no evident solution has been proposed: https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
On Mon, Feb 16, 2015 at 11:55:09AM -0500, Tom Rini wrote:
On Mon, Feb 16, 2015 at 03:05:45PM +0100, Lukasz Majewski wrote:
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error: HOSTLD tools/mkenvimage /usr/bin/ld: error: ./tools/imagetool.lds:23:8: syntax error, unexpected STRING /usr/bin/ld: fatal error: unable to parse script file ./tools/imagetool.lds collect2: error: ld returned 1 exit status make[1]: *** [tools/mkenvimage] Error 1 make: *** [tools] Error 2
The problem has already been reported, but no evident solution has been proposed: https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
On second thought I'm going to go with the patch that just drops the linker script and I see you tested that one as well, thanks!
Hi Tom,
Confirmed, Andreas sent the patch and I've tested both versions. The tools still works on Ubuntu host.
Kind regards,
2015-02-16 15:12 GMT-02:00 Tom Rini trini@ti.com:
On Mon, Feb 16, 2015 at 11:55:09AM -0500, Tom Rini wrote:
On Mon, Feb 16, 2015 at 03:05:45PM +0100, Lukasz Majewski wrote:
Not all linkers are able to parse "INSERT BEFORE" part of the linker
script.
For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error: HOSTLD tools/mkenvimage /usr/bin/ld: error: ./tools/imagetool.lds:23:8: syntax error,
unexpected STRING
/usr/bin/ld: fatal error: unable to parse script file
./tools/imagetool.lds
collect2: error: ld returned 1 exit status make[1]: *** [tools/mkenvimage] Error 1 make: *** [tools] Error 2
The problem has already been reported, but no evident solution has been proposed: https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
On second thought I'm going to go with the patch that just drops the linker script and I see you tested that one as well, thanks!
-- Tom
On 16.02.15 17:55, Tom Rini wrote:
On Mon, Feb 16, 2015 at 03:05:45PM +0100, Lukasz Majewski wrote:
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error: HOSTLD tools/mkenvimage /usr/bin/ld: error: ./tools/imagetool.lds:23:8: syntax error, unexpected STRING /usr/bin/ld: fatal error: unable to parse script file ./tools/imagetool.lds collect2: error: ld returned 1 exit status make[1]: *** [tools/mkenvimage] Error 1 make: *** [tools] Error 2
The problem has already been reported, but no evident solution has been proposed: https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
I vote for 437762 [1] as replacement for this patch.
It is not only the linker script which is not understood by the Darwin linker. The linker generated lists work just differently on Darwin, therefore a93648d197df48fa46dd55f925ff70468bd81c71 broke mkimage for me. Guilherme told the RFC would work [2].
Best regards
Andreas Bießmann
[1] http://patchwork.ozlabs.org/patch/437762/ [2] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/211224
On Mon, Feb 16, 2015 at 08:50:46PM +0100, Andreas Bießmann wrote:
On 16.02.15 17:55, Tom Rini wrote:
On Mon, Feb 16, 2015 at 03:05:45PM +0100, Lukasz Majewski wrote:
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error: HOSTLD tools/mkenvimage /usr/bin/ld: error: ./tools/imagetool.lds:23:8: syntax error, unexpected STRING /usr/bin/ld: fatal error: unable to parse script file ./tools/imagetool.lds collect2: error: ld returned 1 exit status make[1]: *** [tools/mkenvimage] Error 1 make: *** [tools] Error 2
The problem has already been reported, but no evident solution has been proposed: https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
I vote for 437762 [1] as replacement for this patch.
It is not only the linker script which is not understood by the Darwin linker. The linker generated lists work just differently on Darwin, therefore a93648d197df48fa46dd55f925ff70468bd81c71 broke mkimage for me. Guilherme told the RFC would work [2].
I concur and am build testing that locally now.
Hi Andreas,
On 16.02.15 17:55, Tom Rini wrote:
On Mon, Feb 16, 2015 at 03:05:45PM +0100, Lukasz Majewski wrote:
Not all linkers are able to parse "INSERT BEFORE" part of the linker script. For example following (rather new) "gold" one:
GNU gold (GNU Binutils for Debian 2.22) 1.11
produces following error: HOSTLD tools/mkenvimage /usr/bin/ld: error: ./tools/imagetool.lds:23:8: syntax error, unexpected STRING /usr/bin/ld: fatal error: unable to parse script file ./tools/imagetool.lds collect2: error: ld returned 1 exit status make[1]: *** [tools/mkenvimage] Error 1 make: *** [tools] Error 2
The problem has already been reported, but no evident solution has been proposed: https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
Guilherme, can you please confirm that things still work as expected for you with this patch applied? Thanks!
I vote for 437762 [1] as replacement for this patch.
It is not only the linker script which is not understood by the Darwin linker. The linker generated lists work just differently on Darwin, therefore a93648d197df48fa46dd55f925ff70468bd81c71 broke mkimage for me. Guilherme told the RFC would work [2].
Best regards
Andreas Bießmann
[1] http://patchwork.ozlabs.org/patch/437762/ [2] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/211224
I can confirm that patch [1] works on my host debian machine.
Tested-by: Lukasz Majewski l.majewski@samsung.com
participants (4)
-
Andreas Bießmann -
Guilherme Ferreira -
Lukasz Majewski -
Tom Rini